GNU bug report logs - #40668
[PATCH] installer: Fix backtrace display.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40668 in the body.
You can then email your comments to 40668 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Mathieu Othacehe <m.othacehe <at> gmail.com>
Subject: [PATCH] installer: Fix backtrace display.
Date: Thu, 16 Apr 2020 19:33:54 +0200

The 'syslog' macro cannot be resolved in the pre-unwind-handler
context. Failed to resolve 'syslog' in this context resulted in the swallowing
of all installation errors.

Fixes 5c04b00cf463a543b8ffc9eb55991f6b4cc145dd.

* gnu/installer.scm (installer-program): Do not try to resolve 'syslog' macro
in the pre-unwind-handler.
---

Hello,

Since the commit 5c04b00c, error reporting in the installer is broken. Sadly
this means that every error happening in the 1.1.0 release will result in an
installer restart, without any error information reporting. 

Thanks,

Mathieu

 gnu/installer.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/installer.scm b/gnu/installer.scm
index 1051ee1e5f..eba8a7d428 100644
--- a/gnu/installer.scm
+++ b/gnu/installer.scm
@@ -436,8 +436,9 @@ selected keymap."
                      #f)))
                 (const #f)
                 (lambda (key . args)
-                  (syslog "crashing due to uncaught exception: ~s ~s~%"
-                          key args)
+                  ((@@ (gnu installer utils) syslog)
+                   "crashing due to uncaught exception: ~s ~s~%"
+                   key args)
                   (let ((error-file "/tmp/last-installer-error"))
                     (call-with-output-file error-file
                       (lambda (port)
-- 
2.26.0

Message #8 received at 40668 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 40668 <at> debbugs.gnu.org
Subject: Re: [bug#40668] [PATCH] installer: Fix backtrace display.
Date: Fri, 17 Apr 2020 23:07:05 +0200

Hello,

Mathieu Othacehe <m.othacehe <at> gmail.com> skribis:

> The 'syslog' macro cannot be resolved in the pre-unwind-handler
> context. Failed to resolve 'syslog' in this context resulted in the swallowing
> of all installation errors.
>
> Fixes 5c04b00cf463a543b8ffc9eb55991f6b4cc145dd.
>
> * gnu/installer.scm (installer-program): Do not try to resolve 'syslog' macro
> in the pre-unwind-handler.

[...]

> Since the commit 5c04b00c, error reporting in the installer is broken. Sadly
> this means that every error happening in the 1.1.0 release will result in an
> installer restart, without any error information reporting. 

Oh, that’s terrible.  :-/  Sorry about that.

> -                  (syslog "crashing due to uncaught exception: ~s ~s~%"
> -                          key args)
> +                  ((@@ (gnu installer utils) syslog)
> +                   "crashing due to uncaught exception: ~s ~s~%"
> +                   key args)

Please add (gnu installer utils) to the list of use-modules.
‘@@’ should only be used in extreme situations.

Thanks,
Ludo’.

Message #13 received at 40668-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 40668-done <at> debbugs.gnu.org
Subject: Re: [bug#40668] [PATCH] installer: Fix backtrace display.
Date: Sat, 18 Apr 2020 17:46:30 +0200

Hey,

> Please add (gnu installer utils) to the list of use-modules.
> ‘@@’ should only be used in extreme situations.

Fixed and pushed!

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.