GNU bug report logs - #40528
'guix lint' does not check whether propagated-inputs should be native

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Marius Bakke <mbakke <at> fastmail.com>
Subject: bug#40528: closed (Re: bug#40528: 'guix lint' does not check
 whether propagated-inputs should be native)
Date: Thu, 09 Apr 2020 21:51:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#40528: 'guix lint' does not check whether propagated-inputs should be native

which was filed against the guix package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 40528 <at> debbugs.gnu.org.

-- 
40528: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40528
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 40528-done <at> debbugs.gnu.org
Subject: Re: bug#40528: 'guix lint' does not check whether propagated-inputs
 should be native
Date: Fri, 10 Apr 2020 00:50:10 +0300

[Message part 3 (text/plain, inline)]

On Thu, Apr 09, 2020 at 11:42:18PM +0200, Marius Bakke wrote:
> Efraim Flashner <efraim <at> flashner.co.il> writes:
> 
> > On Thu, Apr 09, 2020 at 11:24:25PM +0200, Marius Bakke wrote:
> >> 'guix lint -c inputs-should-be-native' only checks the 'inputs' field of
> >> a package, not propagated-inputs.
> >
> > The attached patch should add the propagated inputs to the list of
> > inputs to check. Do we want to start telling it to ignore some of them?
> 
> Wow, that was incredibly fast!
> 
> > gnu/packages/check.scm:2200:2: python-nose-timer <at> 0.7.5: 'python-nose' should probably be a native input
> 
> I'm inclined to leave it.  I think many of these plugin packages should
> not be propagating the package that they plug into anyway.
> 
> LGTM!

OK, patch pushed.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Marius Bakke <mbakke <at> fastmail.com>
To: bug-guix <at> gnu.org
Subject: 'guix lint' does not check whether propagated-inputs should be native
Date: Thu, 09 Apr 2020 23:24:25 +0200

[Message part 6 (text/plain, inline)]

'guix lint -c inputs-should-be-native' only checks the 'inputs' field of
a package, not propagated-inputs.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.