GNU bug report logs - #40528
'guix lint' does not check whether propagated-inputs should be native

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40528 in the body.
You can then email your comments to 40528 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: bug-guix <at> gnu.org
Subject: 'guix lint' does not check whether propagated-inputs should be native
Date: Thu, 09 Apr 2020 23:24:25 +0200

[Message part 1 (text/plain, inline)]

'guix lint -c inputs-should-be-native' only checks the 'inputs' field of
a package, not propagated-inputs.

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 40528 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 40528 <at> debbugs.gnu.org
Subject: Re: bug#40528: 'guix lint' does not check whether propagated-inputs
 should be native
Date: Fri, 10 Apr 2020 00:31:31 +0300

[Message part 1 (text/plain, inline)]

On Thu, Apr 09, 2020 at 11:24:25PM +0200, Marius Bakke wrote:
> 'guix lint -c inputs-should-be-native' only checks the 'inputs' field of
> a package, not propagated-inputs.

The attached patch should add the propagated inputs to the list of
inputs to check. Do we want to start telling it to ignore some of them?

gnu/packages/check.scm:2200:2: python-nose-timer <at> 0.7.5: 'python-nose' should probably be a native input


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[0001-lint-Check-for-inappropriate-inputs-in-propagated-in.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 40528 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 40528 <at> debbugs.gnu.org
Subject: Re: bug#40528: 'guix lint' does not check whether propagated-inputs
 should be native
Date: Thu, 09 Apr 2020 23:42:18 +0200

[Message part 1 (text/plain, inline)]

Efraim Flashner <efraim <at> flashner.co.il> writes:

> On Thu, Apr 09, 2020 at 11:24:25PM +0200, Marius Bakke wrote:
>> 'guix lint -c inputs-should-be-native' only checks the 'inputs' field of
>> a package, not propagated-inputs.
>
> The attached patch should add the propagated inputs to the list of
> inputs to check. Do we want to start telling it to ignore some of them?

Wow, that was incredibly fast!

> gnu/packages/check.scm:2200:2: python-nose-timer <at> 0.7.5: 'python-nose' should probably be a native input

I'm inclined to leave it.  I think many of these plugin packages should
not be propagating the package that they plug into anyway.

LGTM!

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 40528-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 40528-done <at> debbugs.gnu.org
Subject: Re: bug#40528: 'guix lint' does not check whether propagated-inputs
 should be native
Date: Fri, 10 Apr 2020 00:50:10 +0300

[Message part 1 (text/plain, inline)]

On Thu, Apr 09, 2020 at 11:42:18PM +0200, Marius Bakke wrote:
> Efraim Flashner <efraim <at> flashner.co.il> writes:
> 
> > On Thu, Apr 09, 2020 at 11:24:25PM +0200, Marius Bakke wrote:
> >> 'guix lint -c inputs-should-be-native' only checks the 'inputs' field of
> >> a package, not propagated-inputs.
> >
> > The attached patch should add the propagated inputs to the list of
> > inputs to check. Do we want to start telling it to ignore some of them?
> 
> Wow, that was incredibly fast!
> 
> > gnu/packages/check.scm:2200:2: python-nose-timer <at> 0.7.5: 'python-nose' should probably be a native input
> 
> I'm inclined to leave it.  I think many of these plugin packages should
> not be propagating the package that they plug into anyway.
> 
> LGTM!

OK, patch pushed.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 40528-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Marius Bakke <mbakke <at> fastmail.com>, 40528-done <at> debbugs.gnu.org
Subject: Re: bug#40528: 'guix lint' does not check whether propagated-inputs
 should be native
Date: Fri, 10 Apr 2020 09:51:52 +0100

[Message part 1 (text/plain, inline)]

Efraim Flashner <efraim <at> flashner.co.il> writes:

> On Thu, Apr 09, 2020 at 11:42:18PM +0200, Marius Bakke wrote:
>> Efraim Flashner <efraim <at> flashner.co.il> writes:
>>
>> > On Thu, Apr 09, 2020 at 11:24:25PM +0200, Marius Bakke wrote:
>> >> 'guix lint -c inputs-should-be-native' only checks the 'inputs' field of
>> >> a package, not propagated-inputs.
>> >
>> > The attached patch should add the propagated inputs to the list of
>> > inputs to check. Do we want to start telling it to ignore some of them?
>>
>> Wow, that was incredibly fast!
>>
>> > gnu/packages/check.scm:2200:2: python-nose-timer <at> 0.7.5: 'python-nose' should probably be a native input
>>
>> I'm inclined to leave it.  I think many of these plugin packages should
>> not be propagating the package that they plug into anyway.
>>
>> LGTM!
>
> OK, patch pushed.

Looks like it's working :) [1]

1: http://data.guix.gnu.org/compare?base_commit=960abd585940c33744040c79e2a37e588d36e589&target_commit=d95252baf97adb261dd823d4e7a74a7522815c1c

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.