GNU bug report logs - #40509
Use of fsetxattr() in cp tickles an EXT leak (possibly unnecessarily so)

Previous Next

Package: coreutils;

Reported by: Gregg Leventhal <gleventhal <at> janestreet.com>

Date: Wed, 8 Apr 2020 15:11:01 UTC

Severity: normal

Full log


Message #8 received at 40509 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Gregg Leventhal <gleventhal <at> janestreet.com>
Cc: 40509 <at> debbugs.gnu.org
Subject: Re: bug#40509: Use of fsetxattr() in cp tickles an EXT leak (possibly
 unnecessarily so)
Date: Wed, 8 Apr 2020 10:32:30 -0700
On 4/8/20 7:15 AM, Gregg Leventhal wrote:

> rsync doesn't make set/get xattr calls and purports to preserve ACLs with
> -A.

I'm not quite following your bug report, but it appears that you're saying that 
cp could somehow discover that it needn't use fgetxattr and fsetxattr on files 
that lack extended attributes, and for those files cp could stick with ordinary 
POSIX syscalls (e.g., umask, chmod) to give files proper permissions, and in 
that case 'cp' would presumably (a) operate more efficiently and (b) not trigger 
a bug in the EXT filesystem.

This sounds like a worthy suggestion, though of course it would be better to 
have a concrete proposal in the form of a coreutils patch, along with a few 
performance measurements. For starters, how does rsync do it?

Also, of course EXT should be fixed regardless of what coreutils does here.




This bug report was last modified 5 years and 150 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.