GNU bug report logs - #40510
[PATCH] gnu: Add wolf-shaper.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40510 in the body.
You can then email your comments to 40510 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add wolf-shaper.
Date: Wed, 08 Apr 2020 17:31:46 +0100

[Message part 1 (text/plain, inline)]

Hi,

These patches add wolf-spectrum and wolf-shaper, 2 LV2 plugins.

Thanks,
Alex

[0002-gnu-Add-wolf-spectrum.patch (text/x-patch, attachment)]

[0001-gnu-Add-wolf-shaper.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 40510 <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: 40510 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add wolf-shaper.
Date: Wed, 08 Apr 2020 17:37:22 +0100

[Message part 1 (text/plain, inline)]

Reattaching wolf-spectrum (forgot to change the homepage).

[0002-gnu-Add-wolf-spectrum.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 40510-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Alexandros Theodotou <alex <at> zrythm.org>
Cc: 40510-done <at> debbugs.gnu.org
Subject: Re: [bug#40510] [PATCH] gnu: Add wolf-shaper.
Date: Thu, 23 Apr 2020 23:59:01 +0200

Hi Alexandros,

Alexandros Theodotou <alex <at> zrythm.org> skribis:

> From ff5050712a95e5dc84325ecceac50f84cd71ee14 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Wed, 8 Apr 2020 17:30:45 +0100
> Subject: [PATCH 2/2] gnu: Add wolf-spectrum.
>
> * gnu/packages/music.scm (wolf-spectrum): New variable.

[...]

> +    (synopsis "2D spectrogram plugin")
> +    (description "Wolf Spectrum is a real-time 2D spectrogram plugin.
> +It is provided as an LV2 plugin and as a standalone Jack application.")
> +    (home-page "https://pdesaulniers.github.io/wolf-shaper/")
> +    (license license:gpl3)))

[...]

> From 80dbd4b8eea3beea8eb312acdb56374f486bb9b7 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Wed, 8 Apr 2020 17:21:19 +0100
> Subject: [PATCH 1/2] gnu: Add wolf-shaper.
>
> * gnu/packages/music.scm (wolf-shaper): New variable.

[...]

> +    (synopsis "Waveshaper plugin")
> +    (description "Wolf Shaper is a waveshaper plugin with a graph editor.
> +It is provided as an LV2 plugin and as a standalone Jack application.")
> +    (home-page "https://pdesaulniers.github.io/wolf-shaper/")
> +    (license license:gpl3)))

Applied!

Two comments though:

  1. I believe the license is really ‘gpl3+’ because I don’t see
     anything saying “version 3 only”.  However, the situation is a bit
     confused because source files apparently still contain the ISC
     license header, perhaps an omission since the projects were
     apparently recently relicensed.

  2. The synopses could be improved: plugin for what? What application
     domain?  The descriptions could also be expounded a bit, and this
     would make ‘guix search’ happier.  :-)

Could you follow up on these two things?

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.