GNU bug report logs - #40471
[PATCH] gnu: Add lsp-plugins.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40471 in the body.
You can then email your comments to 40471 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add lsp-plugins.
Date: Mon, 06 Apr 2020 16:08:34 +0100

[Message part 1 (text/plain, inline)]

Hi,

This patch adds LSP plugins (https://lsp-plug.in/).

Thanks,
Alex

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 40471 <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: 40471 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add lsp-plugins.
Date: Tue, 07 Apr 2020 21:08:07 +0100

[Message part 1 (text/plain, inline)]

Oops, here's the patch.

[0001-gnu-Add-lsp-plugins.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 40471 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Alexandros Theodotou <alex <at> zrythm.org>
Cc: 40471 <at> debbugs.gnu.org
Subject: Re: [bug#40471] [PATCH] gnu: Add lsp-plugins.
Date: Wed, 6 May 2020 22:55:25 +0300

[Message part 1 (text/plain, inline)]

This actually failed to build for me, even when I bumped the version up
to 1.1.19. Can you take a look at it?

Thanks


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 40471 <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 40471 <at> debbugs.gnu.org
Subject: Re: [bug#40471] [PATCH] gnu: Add lsp-plugins.
Date: Wed, 27 May 2020 01:06:38 +0100

[Message part 1 (text/plain, inline)]

Fixed! The failure was due to the lv2 upgrade. The upstream has fixed
this in the new release.

See new patch attached.

Thanks,
Alex

On Wed, 2020-05-06 at 22:55 +0300, Efraim Flashner wrote:
> This actually failed to build for me, even when I bumped the version
> up
> to 1.1.19. Can you take a look at it?
> 
> Thanks
> 
> 

[0001-gnu-Add-lsp-plugins.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 40471-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Alexandros Theodotou <alex <at> zrythm.org>
Cc: 40471-done <at> debbugs.gnu.org
Subject: Re: [bug#40471] [PATCH] gnu: Add lsp-plugins.
Date: Wed, 27 May 2020 12:25:08 +0300

[Message part 1 (text/plain, inline)]

Patched pushed with a few changes:

On Wed, May 27, 2020 at 01:06:38AM +0100, Alexandros Theodotou wrote:
> Fixed! The failure was due to the lv2 upgrade. The upstream has fixed
> this in the new release.
> 
> See new patch attached.
> 
> Thanks,
> Alex
> 
> On Wed, 2020-05-06 at 22:55 +0300, Efraim Flashner wrote:
> > This actually failed to build for me, even when I bumped the version
> > up
> > to 1.1.19. Can you take a look at it?
> > 
> > Thanks
> > 
> > 

> From b3aa2ea22bc2be15a7ab11c792ea85a1ec3900d6 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Wed, 27 May 2020 01:04:42 +0100
> Subject: [PATCH] gnu: Add lsp-plugins.
> 
> * gnu/packages/music.scm (lsp-plugins): new variable.
> ---
>  gnu/packages/music.scm | 43 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
> 
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 2c6be8eba8..f01978d118 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -4863,6 +4863,49 @@ effects.  It contains a bitcrusher, delay, distortion, equalizer, compressor,
>  and reverb.")
>      (license license:gpl2+)))
>  
> +(define-public lsp-plugins
> +  (package
> +    (name "lsp-plugins")
> +    (version "1.1.21")
> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri (git-reference
> +               (url "https://github.com/sadko4u/lsp-plugins.git")
> +               (commit (string-append "lsp-plugins-" version))))
> +        (file-name (git-file-name name version))
> +        (sha256
> +          (base32
> +            "1zw0iip6ki9k65kh8dp53x7l4va4mi5rj793n2yn4p9y84qzwrz9"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:make-flags

I changed the CC=gcc line so that it can cross compile

> +       (list "CC=gcc" "BUILD_MODULES=\"lv2 ladspa jack\"" "VST_UI=0"
> +             (string-append "PREFIX=" (assoc-ref %outputs "out"))
> +             (string-append "ETC_PATH=" (assoc-ref %outputs "out") "/etc"))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure) ; no configure

I changed this to a #:test-flag

> +         (replace 'check
> +           (lambda _
> +             (invoke "make" "test"))))))

And I re-indented so that the ` was under the 'i' in inputs.
Same with native-inputs.

> +    (inputs
> +      `(("cairo", cairo)
> +        ("hicolor-icon-theme", hicolor-icon-theme)
> +        ("jack", jack-1)
> +        ("ladspa", ladspa)
> +        ("libsndfile", libsndfile)
> +        ("lv2", lv2)
> +        ("mesa", mesa)))
> +    (native-inputs
> +      `(("pkg-config", pkg-config)))
> +    (synopsis "Audio plugin collection")
> +    (description "LSP (Linux Studio Plugins) is a collection of audio
> +plugins available as LADSPA/LV2 plugins and as standalone JACK
> +applications.")
> +    (home-page "https://lsp-plug.in/")
> +    (license license:lgpl3)))
> +
>  (define-public sherlock-lv2
>    (package
>      (name "sherlock-lv2")
> -- 
> 2.26.2
> 




-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.