GNU bug report logs - #40470
[PATCH] gnu: Add tap-lv2.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40470 in the body.
You can then email your comments to 40470 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add tap-lv2.
Date: Mon, 06 Apr 2020 16:04:49 +0100

[Message part 1 (text/plain, inline)]

Hi,

This patch adds tap-lv2, an LV2 port of the TAP LADSPA plugins. I used
the date as a version because there was no tag.

Thanks,
Alex

[0001-gnu-Add-tap-lv2.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 40470 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Alexandros Theodotou <alex <at> zrythm.org>
Cc: 40470 <at> debbugs.gnu.org
Subject: Re: [bug#40470] [PATCH] gnu: Add tap-lv2.
Date: Mon, 6 Apr 2020 15:02:18 -0400

[Message part 1 (text/plain, inline)]

On Mon, Apr 06, 2020 at 04:04:49PM +0100, Alexandros Theodotou wrote:
> Hi,
> 
> This patch adds tap-lv2, an LV2 port of the TAP LADSPA plugins. I used
> the date as a version because there was no tag.

Can you revise the version number stuff based on the guidelines in the
manual section Version Numbers?

https://guix.gnu.org/manual/en/html_node/Version-Numbers.html#Version-Numbers

Otherwise LGTM

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 40470 <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 40470 <at> debbugs.gnu.org
Subject: Re: [bug#40470] [PATCH] gnu: Add tap-lv2.
Date: Mon, 06 Apr 2020 22:15:40 +0100

[Message part 1 (text/plain, inline)]

Hi Leo,

Thanks for the review.

Attaching the updated patch.

Thanks,
Alex

On Mon, 2020-04-06 at 15:02 -0400, Leo Famulari wrote:
> On Mon, Apr 06, 2020 at 04:04:49PM +0100, Alexandros Theodotou wrote:
> > Hi,
> > 
> > This patch adds tap-lv2, an LV2 port of the TAP LADSPA plugins. I
> > used
> > the date as a version because there was no tag.
> 
> Can you revise the version number stuff based on the guidelines in
> the
> manual section Version Numbers?
> 
> https://guix.gnu.org/manual/en/html_node/Version-Numbers.html#Version-Numbers
> 
> Otherwise LGTM

[0001-gnu-Add-tap-lv2.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 40470-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Alexandros Theodotou <alex <at> zrythm.org>
Cc: 40470-done <at> debbugs.gnu.org
Subject: Re: [bug#40470] [PATCH] gnu: Add tap-lv2.
Date: Tue, 7 Apr 2020 14:18:48 -0400

On Mon, Apr 06, 2020 at 10:15:40PM +0100, Alexandros Theodotou wrote:
> * gnu/packages/music.scm (tap-lv2): new variable.

Thanks for the revised patch!

> +      (home-page "http://tap-plugins.sf.net/")

I amended this link based on feedback from `guix lint`; it permanently
redirects somewhere else.

I also noticed that we could puth INSTALL_PATH in #:make-flags and not
have to replace the 'install' phase, but I didn't make that change.

Pushed as 2aaf76582d0371127a51a4e112a4d9ff5a30dd37

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.