GNU bug report logs - #40429
[PATCH] gnu: Add emacs-flymake-shellcheck.

Previous Next

Full log

View this message in rfc822 format

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: "LaFreniere\, Joseph" <joseph <at> lafreniere.xyz>
Cc: 40429 <at> debbugs.gnu.org
Subject: [bug#40429] [PATCH] gnu: Add emacs-flymake-shellcheck.
Date: Sun, 05 Apr 2020 10:11:41 +0200

Hello,

"LaFreniere, Joseph" <joseph <at> lafreniere.xyz> writes:

> Patch file is attached.

Thank you.

> +      (inputs
> +       `(("shellcheck" ,shellcheck)))
> +      (arguments
> +       '(#:phases
> +         (modify-phases %standard-phases
> +           (add-after 'unpack 'hardcode-shellcheck-path
> +             (lambda _
> +               (let ((file "flymake-shellcheck.el"))
> +                 (chmod file #o644)
> +                 (emacs-substitute-sexps file
> +                   ("(defcustom flymake-shellcheck-path"
> +                    (which "shellcheck")))))))))

You could use `emacs-substitute-variables' here.

However, I wonder if we should add "shellcheck" as an input. Of course,
the package will not work so well if "shellcheck" is not available. But,
as a user, it would not cross my mind to use "flymake-shellcheck"
without it. As another data point, "emacs-flycheck-rust" doesn't add
"rust" as an input.

WDYT?

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.