GNU bug report logs - #40430
Don’t attempt to create a module database when none are available

Previous Next

Package: guix-patches;

Reported by: Ivan Kozlov <kanichos <at> yandex.ru>

Date: Sat, 4 Apr 2020 16:17:01 UTC

Severity: normal

Tags: moreinfo

To reply to this bug, email your comments to 40430 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#40430; Package guix-patches. (Sat, 04 Apr 2020 16:17:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Ivan Kozlov <kanichos <at> yandex.ru>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 04 Apr 2020 16:17:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ivan Kozlov <kanichos <at> yandex.ru>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: Don’t attempt to create a module database when none are available
Date: Sat, 04 Apr 2020 19:16:15 +0300

The present code breaks with a non-modular kernel. This can be easily avoided.

--- a/gnu/system.scm
+++ #<buffer system.scm>
@@ -477,13 +477,19 @@
 value of the SYSTEM-SERVICE-TYPE service."
   (let ((locale (operating-system-locale-directory os)))
     (mlet* %store-monad ((kernel -> (operating-system-kernel os))
+                         (kernel-modules (package-file kernel "lib/modules"))
                          (modules ->
                           (operating-system-kernel-loadable-modules os))
+                         (has-modules ->
+                          (or (not (null? modules))
+                              (file-exists? kernel-modules)))
                          (kernel
                           (profile-derivation
                            (packages->manifest
                             (cons kernel modules))
-                           #:hooks (list linux-module-database)))
+                           #:hooks (if has-modules
+                                       (list linux-module-database)
+                                       '())))
                          (initrd -> (operating-system-initrd-file os))
                          (params    (operating-system-boot-parameters-file os)))
       (return `(("kernel" ,kernel)
Reply sent to Danny Milosavljevic <dannym <at> scratchpost.org>:
You have taken responsibility. (Sat, 04 Apr 2020 20:06:02 GMT) Full text and rfc822 format available.
Notification sent to Ivan Kozlov <kanichos <at> yandex.ru>:
bug acknowledged by developer. (Sat, 04 Apr 2020 20:06:02 GMT) Full text and rfc822 format available.

Message #10 received at 40430-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Ivan Kozlov <kanichos <at> yandex.ru>
Cc: 40430-done <at> debbugs.gnu.org
Subject: Re: [bug#40430] Don’t attempt to create a
 module database when none are available
Date: Sat, 4 Apr 2020 22:05:49 +0200

[Message part 1 (text/plain, inline)]
Thanks!

Pushed to guix master as commit b2fff3b5de7d510fe4809e9a97089dddf2a39ffc.


[Message part 2 (application/pgp-signature, inline)]
Did not alter fixed versions and reopened. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 20 Apr 2020 21:31:01 GMT) Full text and rfc822 format available.
Information forwarded to guix-patches <at> gnu.org:
bug#40430; Package guix-patches. (Mon, 20 Apr 2020 22:13:02 GMT) Full text and rfc822 format available.

Message #15 received at 40430 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ivan Kozlov <kanichos <at> yandex.ru>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 40430 <at> debbugs.gnu.org
Subject: Re: [bug#40430] Don’t attempt to create a
 module database when none are available
Date: Tue, 21 Apr 2020 00:12:40 +0200

Hi,

Ivan Kozlov <kanichos <at> yandex.ru> skribis:

> The present code breaks with a non-modular kernel. This can be easily avoided.
>
> --- a/gnu/system.scm
> +++ #<buffer system.scm>
> @@ -477,13 +477,19 @@
>  value of the SYSTEM-SERVICE-TYPE service."
>    (let ((locale (operating-system-locale-directory os)))
>      (mlet* %store-monad ((kernel -> (operating-system-kernel os))
> +                         (kernel-modules (package-file kernel "lib/modules"))
>                           (modules ->
>                            (operating-system-kernel-loadable-modules os))
> +                         (has-modules ->
> +                          (or (not (null? modules))
> +                              (file-exists? kernel-modules)))
>                           (kernel
>                            (profile-derivation
>                             (packages->manifest
>                              (cons kernel modules))
> -                           #:hooks (list linux-module-database)))
> +                           #:hooks (if has-modules
> +                                       (list linux-module-database)
> +                                       '())))
>                           (initrd -> (operating-system-initrd-file os))
>                           (params    (operating-system-boot-parameters-file os)))
>        (return `(("kernel" ,kernel)

There were a couple of mistakes in this patch (which is fine, we all
make mistakes!), so I reverted it along with explanations:

  https://git.savannah.gnu.org/cgit/guix.git/commit/?id=71977a6c59460e029c91741c8b11f3a544a70486

What problem were you trying to solve, Ivan?  What do you mean by
“non-modular kernel”?

Thanks,
Ludo’.
Added tag(s) moreinfo. Request was from Ludovic Courtès <ludo <at> gnu.org> to control <at> debbugs.gnu.org. (Mon, 25 May 2020 20:13:01 GMT) Full text and rfc822 format available.
Information forwarded to guix-patches <at> gnu.org:
bug#40430; Package guix-patches. (Fri, 12 Jun 2020 18:05:02 GMT) Full text and rfc822 format available.

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ivan Kozlov <kanichos <at> yandex.ru>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: guix-patches <guix-patches <at> gnu.org>,
 "40430 <at> debbugs.gnu.org" <40430 <at> debbugs.gnu.org>
Subject: Re: [bug#40430] Don’t attempt to create a module database when none are available
Date: Fri, 12 Jun 2020 21:04:02 +0300

The intent was to allow a Linux package with CONFIG_MODULES=n to work after 5c79f238634c5adb6657f1b4b1bb4ddb8bb73ef1. There are no modules and no ‘lib/modules’.

Will you accept a patch that changes linux-module-database to skip unsuitable inputs instead?

21.04.2020, 01:12, "Ludovic Courtès" <ludo <at> gnu.org>:
> There were a couple of mistakes in this patch (which is fine, we all
> make mistakes!), so I reverted it along with explanations:
>
>   https://git.savannah.gnu.org/cgit/guix.git/commit/?id=71977a6c59460e029c91741c8b11f3a544a70486
>
> What problem were you trying to solve, Ivan? What do you mean by
> “non-modular kernel”?
>
> Thanks,
> Ludo’.
Information forwarded to guix-patches <at> gnu.org:
bug#40430; Package guix-patches. (Fri, 12 Jun 2020 18:05:02 GMT) Full text and rfc822 format available.
Information forwarded to guix-patches <at> gnu.org:
bug#40430; Package guix-patches. (Fri, 21 Feb 2025 22:17:05 GMT) Full text and rfc822 format available.

Message #26 received at 40430 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Ivan Kozlov <kanichos <at> yandex.ru>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 40430 <at> debbugs.gnu.org
Subject: Re: bug#40430: Don’t attempt to create a module
 database when none are available
Date: Fri, 21 Feb 2025 23:06:01 +0100

Hi,

Thanks for the report.  It’s old and sorry if this had fallen into the
crack.

For reference: https://issues.guix.gnu.org/issue/40430

On Fri, 12 Jun 2020 at 21:04, Ivan Kozlov <kanichos <at> yandex.ru> wrote:
> The intent was to allow a Linux package with CONFIG_MODULES=n to work after 5c79f238634c5adb6657f1b4b1bb4ddb8bb73ef1. There are no modules and no ‘lib/modules’.
>
> Will you accept a patch that changes linux-module-database to skip unsuitable inputs instead?
>
> 21.04.2020, 01:12, "Ludovic Courtès" <ludo <at> gnu.org>:
>> There were a couple of mistakes in this patch (which is fine, we all
>> make mistakes!), so I reverted it along with explanations:
>>
>>   https://git.savannah.gnu.org/cgit/guix.git/commit/?id=71977a6c59460e029c91741c8b11f3a544a70486
>>
>> What problem were you trying to solve, Ivan? What do you mean by
>> “non-modular kernel”?

What’s the status of this report?

I’m in favor to close it.  WDYT?

Cheers,
simon
Information forwarded to guix-patches <at> gnu.org:
bug#40430; Package guix-patches. (Thu, 27 Feb 2025 15:37:03 GMT) Full text and rfc822 format available.

Message #29 received at 40430 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: 40430 <at> debbugs.gnu.org, Ivan Kozlov <kanichos <at> yandex.ru>
Subject: Re: bug#40430: Don’t attempt to create a module
 database when none are available
Date: Thu, 27 Feb 2025 16:35:54 +0100

Simon Tournier <zimon.toutoune <at> gmail.com> skribis:

> I’m in favor to close it.  WDYT?

Fine with me, thanks!
This bug report was last modified 104 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.