GNU bug report logs - #40284
[PATCH] gnu: emacs-arduino-mode: Change to a maintained fork.

Previous Next

Full log

Message #8 received at 40284 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Evan Straw <evan.straw99 <at> gmail.com>
Cc: 40284 <at> debbugs.gnu.org
Subject: Re: [bug#40284] [PATCH] gnu: emacs-arduino-mode: Change to a
 maintained fork.
Date: Mon, 30 Mar 2020 01:59:07 +0200

Hello,

Evan Straw <evan.straw99 <at> gmail.com> writes:

> Subject: [PATCH] gnu: emacs-arduino-mode: Change to a maintained fork.
>
> * gnu/packages/emacs-xyz.scm (emacs-arduino-mode): Change to a maintained
>   fork.

Thank you.

> -  (let ((commit "3e2bad4569ad26e929e6db2cbcff0d6d36812698")) ;no release yet
> +  (let ((commit "23ae47c9f28f559e70b790b471f20310e163a39b")) ;no release yet
>      (package
>        (name "emacs-arduino-mode")
>        (version (git-version "0" "0" commit))

We want to increment version, too, so the above should be:

  (git-version "0" "1" commit)

For clarity, you may want to bind `revision' to "1" right after `commit'
and use that in the `git-version' call.

> +           (add-after 'unpack 'fix-obsolete
> +             (lambda _
> +               (substitute* "ede-arduino.el"
> +                 (("defmethod") "cl-defmethod")
> +                 (("defgeneric") "cl-defgeneric")))))))

The phase must end with a #f

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.