GNU bug report logs - #40285
gnu: packages: java: antlr3: Make antlr3-3.3 public

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40285 in the body.
You can then email your comments to 40285 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: gnu: packages: java: antlr3: Make antlr3-3.3 public
Date: Mon, 30 Mar 2020 01:49:09 +0000

[Message part 1 (text/plain, inline)]

Hello Guix!

Please find the attached patch to make the "antlr3-3.3" variable public.

Regards,
RG.

[antlr3-3.3.patch (application/octet-stream, attachment)]

Message #12 received at 40285-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40285-done <at> debbugs.gnu.org
Subject: Re: [bug#40285] gnu: packages: java: antlr3: Make antlr3-3.3 public
Date: Mon, 30 Mar 2020 22:55:44 -0400

"Raghav Gururajan" <raghavgururajan <at> disroot.org> writes:

> Hello Guix!
>
> Please find the attached patch to make the "antlr3-3.3" variable public.
>
> Regards,
> RG.
>
> From be47a8520cddcee72ba9be531bbe922118f027d2 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Sun, 29 Mar 2020 21:45:10 -0400
> Subject: [PATCH 15/15] gnu: packages: java: antlr3: Make antlr3-3.3 public
>
> * gnu/packages/java.scm (antlr3): Make antlr3-3.3 public.
> ---
>  gnu/packages/java.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index 400ef8795e..37108f56c0 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -7162,7 +7162,7 @@ tree walking, and translation.")
>      (inputs
>       `(("junit" ,java-junit)))))
>  
> -(define antlr3-3.3
> +(define-public antlr3-3.3
>    (package
>      (inherit antlr3)
>      (name "antlr3")

I added a bit more context to the commit message, fixed the gnu: antlr3:
prefix and pushed as commit 011f941279.

Thank you!

Maxim

Message #15 received at 40285 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40285 <at> debbugs.gnu.org
Subject: Re: [bug#40285] gnu: packages: java: antlr3: Make antlr3-3.3 public
Date: Mon, 30 Mar 2020 23:04:04 -0400

Hello Raghav!

"Raghav Gururajan" <raghavgururajan <at> disroot.org> writes:

> Hello Guix!
>
> Please find the attached patch to make the "antlr3-3.3" variable public.
>
> Regards,
> RG.

(I thought I had sent this already but it seems not -- sending it just
for the record, even though I've already merged this change to master).

It would have been easier for us reviewers to add the changes related to
the packaging of Linphone in the same patch series (appearing before the
packages that need this), so as to have the context and understand the
rational of making this change.

I've marked those as blocking 40307 (linphone), so OK for this time, but
keep in mind for next time :-).

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.