GNU bug report logs - #40264
Linphone

Previous Next

Full log

Message #81 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 3-add-bcunit
Date: Tue, 31 Mar 2020 22:46:10 -0400

Hello Raghav,

"Raghav Gururajan" <raghavgururajan <at> disroot.org> writes:

> From fe32f106ca646c357c958e1b5ebd375b942f4f3c Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Fri, 27 Mar 2020 17:19:45 -0400
> Subject: [PATCH 3/3] gnu: packages: linphone: Add bcunit
                          ^ You can drop the 'packages: linphone:' part
                          and add a dot.
>
> * gnu/packages/linphone.scm (bcunit): New variable.
> ---
>  gnu/packages/linphone.scm | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>
> diff --git a/gnu/packages/linphone.scm b/gnu/packages/linphone.scm
> index 35c9ec955f..974fc62792 100644
> --- a/gnu/packages/linphone.scm
> +++ b/gnu/packages/linphone.scm
> @@ -20,6 +20,7 @@
>  (define-module (gnu packages linphone)
>    #:use-module (gnu packages)
>    #:use-module (gnu packages base)
> +  #:use-module (gnu packages ncurses)
>    #:use-module ((guix licenses) #:prefix license:)
>    #:use-module (guix packages)
>    #:use-module (guix download)
> @@ -28,3 +29,40 @@
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system python)
>    #:use-module (guix build-system qt))
> +
> +(define-public bcunit
> + (package
> +  (name "bcunit")
> +   (version "3.0.2")
> +   (source
> +    (origin
> +     (method url-fetch)
> +     (uri
> +      (string-append "https://www.linphone.org/releases/sources/" name
> +                     "/" name "-" version ".tar.gz"))
> +     (sha256
> +      (base32 "0ylchj8w98ic2fkqpxc6yk4s6s0h0ql2zsz5n49jd7126m4h8dqk"))))
> + (build-system cmake-build-system)
> + (arguments
> +  '(#:tests? #f ; No test target
> +    #:configure-flags
> +     (list
> +      "-DENABLE_SHARED=YES"
> +      "-DENABLE_STATIC=YES"
> +      "-DENABLE_AUTOMATED=ON"
> +      "-DENABLE_BASIC=ON"
> +      "-DENABLE_CONSOLE=ON"
> +      "-DENABLE_CURSES=ON"
> +      "-DENABLE_DOC=ON"
> +      "-DENABLE_EXAMPLES=ON"
> +      "-DENABLE_TEST=OFF" ; Undefined reference to CU_trace_handler
> +      "-DENABLE_MEMTRACE=ON"
> +      "-DENABLE_DEPRECATED=OFF"))) ; Not required

Please only activate the switches which need to be activated (let's not
repeat the default values to keep the noise level/verbosity as low as
possible).  You can usually see the defaults by inspecting the
CMakeLists.txt file at the root of the project.

> + (inputs
> +  `(("curses" ,ncurses)))
> + (synopsis "Belledonne Communications Unit Testing Framework")
> + (description "BCUnit is a fork of the defunct project CUnit,
> +with several fixes and patches applied.  It is an unit testing
                                                  ^ a
> +framework for writing, administering, and running unit tests in C.")
> + (home-page "https://gitlab.linphone.org/BC/public/bcunit")
> + (license license:lgpl2.0+)))

The first 3 commits of this series should be squashed together.

Also, please run the indent-code.el script for proper indentation.

Thank you!

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.