GNU bug report logs - #40264
Linphone

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40264 in the body.
You can then email your comments to 40264 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: Linphone
Date: Fri, 27 Mar 2020 23:10:49 +0000

Hello Guix!

I am creating this thread for Linphone packaging. I will be sending patches one by one with-in this thread. :-)

Regards,
RG.

Message #8 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 1-create-linphone-module
Date: Fri, 27 Mar 2020 23:13:27 +0000

[Message part 1 (text/plain, inline)]

[1-create-linphone-module.patch (application/octet-stream, attachment)]

Message #11 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 2-update-linphone-module
Date: Fri, 27 Mar 2020 23:14:28 +0000

[Message part 1 (text/plain, inline)]

[2-update-linphone-module.patch (application/octet-stream, attachment)]

Message #14 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 3-add-bcunit
Date: Fri, 27 Mar 2020 23:15:42 +0000

[Message part 1 (text/plain, inline)]

[3-add-bcunit.patch (application/octet-stream, attachment)]

Message #17 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 4-add-bctoolbox
Date: Fri, 27 Mar 2020 23:21:26 +0000

[Message part 1 (text/plain, inline)]

[4-add-bctoolbox.patch (application/octet-stream, attachment)]

Message #20 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 5-add-belr
Date: Sat, 28 Mar 2020 18:40:58 +0000

[Message part 1 (text/plain, inline)]

[5-add-belr.patch (application/octet-stream, attachment)]

Message #23 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 6-add-belcard
Date: Sat, 28 Mar 2020 19:40:41 +0000

[Message part 1 (text/plain, inline)]

[6-add-belcard.patch (application/octet-stream, attachment)]

Message #26 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 7-add-bcmatroska2
Date: Sat, 28 Mar 2020 21:22:49 +0000

[Message part 1 (text/plain, inline)]

[7-add-bcmatroska2.patch (application/octet-stream, attachment)]

Message #29 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 8-add-bcg729
Date: Sat, 28 Mar 2020 21:35:10 +0000

[Message part 1 (text/plain, inline)]

[8-add-bcg729.patch (application/octet-stream, attachment)]

Message #32 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 9-add-ortp
Date: Sat, 28 Mar 2020 22:14:22 +0000

[Message part 1 (text/plain, inline)]

[9-add-ortp.patch (application/octet-stream, attachment)]

Message #35 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 10-add-bzrtp
Date: Sat, 28 Mar 2020 22:36:49 +0000

[Message part 1 (text/plain, inline)]

[10-add-bzrtp.patch (application/octet-stream, attachment)]

Message #38 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 11-add-mediastreamer
Date: Sun, 29 Mar 2020 08:58:56 +0000

[Message part 1 (text/plain, inline)]

[11-add-mediastreamer.patch (application/octet-stream, attachment)]

Message #41 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 12-add-belle-sip
Date: Mon, 30 Mar 2020 02:45:10 +0000

[Message part 1 (text/plain, inline)]

[12-add-belle-sip.patch (application/octet-stream, attachment)]

Message #44 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 13-add-linphone
Date: Mon, 30 Mar 2020 09:47:11 +0000

[Message part 1 (text/plain, inline)]

[13-add-linphone.patch (application/octet-stream, attachment)]

Message #47 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 14-add-linphoneqt
Date: Mon, 30 Mar 2020 16:50:44 +0000

[Message part 1 (text/plain, inline)]

[14-add-linphoneqt.patch (application/octet-stream, attachment)]

Message #50 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 12-add-belle-sip
Date: Mon, 30 Mar 2020 22:45:54 +0200

[Message part 1 (text/plain, inline)]

Missing definition of libantlr3c?

[Message part 2 (application/pgp-signature, inline)]

Message #55 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 15-add-msamr
Date: Tue, 31 Mar 2020 13:44:20 +0000

[Message part 1 (text/plain, inline)]

[15-add-msamr.patch (application/octet-stream, attachment)]

Message #58 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 16-add-openh264
Date: Tue, 31 Mar 2020 14:12:37 +0000

[Message part 1 (text/plain, inline)]

[16-add-msopenh264.patch (application/octet-stream, attachment)]

Message #61 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 17-add-mssilk
Date: Tue, 31 Mar 2020 14:31:02 +0000

[Message part 1 (text/plain, inline)]

[17-add-mssilk.patch (application/octet-stream, attachment)]

Message #64 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 18-add-mswebrtc
Date: Tue, 31 Mar 2020 14:50:37 +0000

[Message part 1 (text/plain, inline)]

[18-add-mswebrtc.patch (application/octet-stream, attachment)]

Message #75 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 12-add-belle-sip
Date: Tue, 31 Mar 2020 16:32:38 +0000

> Missing definition of libantlr3c?

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40291

:-)

Message #78 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 12-add-belle-sip
Date: Tue, 31 Mar 2020 22:38:41 -0400

"Raghav Gururajan" <raghavgururajan <at> disroot.org> writes:

>> Missing definition of libantlr3c?
>
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40291
>
> :-)

This has now been reviewed & merged.

Message #81 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 3-add-bcunit
Date: Tue, 31 Mar 2020 22:46:10 -0400

Hello Raghav,

"Raghav Gururajan" <raghavgururajan <at> disroot.org> writes:

> From fe32f106ca646c357c958e1b5ebd375b942f4f3c Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Fri, 27 Mar 2020 17:19:45 -0400
> Subject: [PATCH 3/3] gnu: packages: linphone: Add bcunit
                          ^ You can drop the 'packages: linphone:' part
                          and add a dot.
>
> * gnu/packages/linphone.scm (bcunit): New variable.
> ---
>  gnu/packages/linphone.scm | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>
> diff --git a/gnu/packages/linphone.scm b/gnu/packages/linphone.scm
> index 35c9ec955f..974fc62792 100644
> --- a/gnu/packages/linphone.scm
> +++ b/gnu/packages/linphone.scm
> @@ -20,6 +20,7 @@
>  (define-module (gnu packages linphone)
>    #:use-module (gnu packages)
>    #:use-module (gnu packages base)
> +  #:use-module (gnu packages ncurses)
>    #:use-module ((guix licenses) #:prefix license:)
>    #:use-module (guix packages)
>    #:use-module (guix download)
> @@ -28,3 +29,40 @@
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system python)
>    #:use-module (guix build-system qt))
> +
> +(define-public bcunit
> + (package
> +  (name "bcunit")
> +   (version "3.0.2")
> +   (source
> +    (origin
> +     (method url-fetch)
> +     (uri
> +      (string-append "https://www.linphone.org/releases/sources/" name
> +                     "/" name "-" version ".tar.gz"))
> +     (sha256
> +      (base32 "0ylchj8w98ic2fkqpxc6yk4s6s0h0ql2zsz5n49jd7126m4h8dqk"))))
> + (build-system cmake-build-system)
> + (arguments
> +  '(#:tests? #f ; No test target
> +    #:configure-flags
> +     (list
> +      "-DENABLE_SHARED=YES"
> +      "-DENABLE_STATIC=YES"
> +      "-DENABLE_AUTOMATED=ON"
> +      "-DENABLE_BASIC=ON"
> +      "-DENABLE_CONSOLE=ON"
> +      "-DENABLE_CURSES=ON"
> +      "-DENABLE_DOC=ON"
> +      "-DENABLE_EXAMPLES=ON"
> +      "-DENABLE_TEST=OFF" ; Undefined reference to CU_trace_handler
> +      "-DENABLE_MEMTRACE=ON"
> +      "-DENABLE_DEPRECATED=OFF"))) ; Not required

Please only activate the switches which need to be activated (let's not
repeat the default values to keep the noise level/verbosity as low as
possible).  You can usually see the defaults by inspecting the
CMakeLists.txt file at the root of the project.

> + (inputs
> +  `(("curses" ,ncurses)))
> + (synopsis "Belledonne Communications Unit Testing Framework")
> + (description "BCUnit is a fork of the defunct project CUnit,
> +with several fixes and patches applied.  It is an unit testing
                                                  ^ a
> +framework for writing, administering, and running unit tests in C.")
> + (home-page "https://gitlab.linphone.org/BC/public/bcunit")
> + (license license:lgpl2.0+)))

The first 3 commits of this series should be squashed together.

Also, please run the indent-code.el script for proper indentation.

Thank you!

Maxim

Message #84 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 3-add-bcunit-v2
Date: Wed, 01 Apr 2020 20:21:52 +0000

[Message part 1 (text/plain, inline)]

[3-add-bcunit-v2.patch (application/octet-stream, attachment)]

Message #87 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 4-add-bctoolbox-v2
Date: Wed, 01 Apr 2020 22:13:12 +0000

[Message part 1 (text/plain, inline)]

[4-add-bctoolbox-v2.patch (application/octet-stream, attachment)]

Message #90 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 5-add-belr-v2
Date: Wed, 01 Apr 2020 22:20:06 +0000

[Message part 1 (text/plain, inline)]

[5-add-belr-v2.patch (application/octet-stream, attachment)]

Message #93 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 6-add-belcard-v2
Date: Wed, 01 Apr 2020 22:32:01 +0000

[Message part 1 (text/plain, inline)]

[6-add-belcard-v2.patch (application/octet-stream, attachment)]

Message #96 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 7-add-bcmatroska2-v2
Date: Wed, 01 Apr 2020 22:40:07 +0000

[Message part 1 (text/plain, inline)]

[7-add-bcmatroska2-v2.patch (application/octet-stream, attachment)]

Message #99 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 8-add-bcg729-v2
Date: Wed, 01 Apr 2020 22:46:43 +0000

[Message part 1 (text/plain, inline)]

[8-add-bcg729-v2.patch (application/octet-stream, attachment)]

Message #102 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 9-add-ortp-v2
Date: Wed, 01 Apr 2020 22:56:46 +0000

[Message part 1 (text/plain, inline)]

[9-add-ortp-v2.patch (application/octet-stream, attachment)]

Message #105 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 10-add-bzrtp-v2
Date: Wed, 01 Apr 2020 23:04:54 +0000

[Message part 1 (text/plain, inline)]

[10-add-bzrtp-v2.patch (application/octet-stream, attachment)]

Message #108 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 11-add-mediastreamer-v2
Date: Thu, 02 Apr 2020 00:20:04 +0000

[Message part 1 (text/plain, inline)]

[11-add-mediastreamer-v2.patch (application/octet-stream, attachment)]

Message #111 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 12-add-belle-sip-v2
Date: Thu, 02 Apr 2020 00:44:29 +0000

[Message part 1 (text/plain, inline)]

[12-add-belle-sip-v2.patch (application/octet-stream, attachment)]

Message #114 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 13-add-linphone-v2
Date: Thu, 02 Apr 2020 01:20:35 +0000

[Message part 1 (text/plain, inline)]

[13-add-linphone-v2.patch (application/octet-stream, attachment)]

Message #117 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 14-add-linphoneqt-v2
Date: Thu, 02 Apr 2020 01:47:38 +0000

[Message part 1 (text/plain, inline)]

[14-add-linphoneqt-v2.patch (application/octet-stream, attachment)]

Message #120 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linohone: 15-add-msamr-v2
Date: Thu, 02 Apr 2020 02:06:21 +0000

[Message part 1 (text/plain, inline)]

[15-add-msamr-v2.patch (application/octet-stream, attachment)]

Message #123 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 16-add-msopenh264-v2
Date: Thu, 02 Apr 2020 02:55:17 +0000

[Message part 1 (text/plain, inline)]

[16-add-msopenh264-v2.patch (application/octet-stream, attachment)]

Message #126 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 17-add-mssilk-v2
Date: Thu, 02 Apr 2020 03:00:20 +0000

[Message part 1 (text/plain, inline)]

[17-add-mssilk-v2.patch (application/octet-stream, attachment)]

Message #129 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 18-add-mswebrtc-v2
Date: Thu, 02 Apr 2020 03:06:16 +0000

[Message part 1 (text/plain, inline)]

[18-add-mswebrtc-v2.patch (application/octet-stream, attachment)]

Message #132 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 14-add-linphoneqt-v3
Date: Thu, 02 Apr 2020 08:56:56 +0000

[Message part 1 (text/plain, inline)]

[14-add-linphoneqt-v3.patch (application/octet-stream, attachment)]

Message #135 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 12-add-belle-sip-v2
Date: Thu, 2 Apr 2020 13:24:47 +0200

[Message part 1 (text/plain, inline)]

Hi Raghav,

belle-sip is not reproducible.

$ guix build --rounds=2 belle-sip
[...]
phase `compress-documentation' succeeded after 0.0 seconds
output ‘/gnu/store/rykd8wp9ibjf3ad4nlg15vmyzgq9izsp-belle-sip-1.6.3’ of ‘/gnu/store/lqdmaxvlhxk25jr7whk5bvi0y1zbzp5a-belle-sip-1.6.3.drv’ differs from ‘/gnu/store/rykd8wp9ibjf3ad4nlg15vmyzgq9izsp-belle-sip-1.6.3-check’ from previous round
build of /gnu/store/lqdmaxvlhxk25jr7whk5bvi0y1zbzp5a-belle-sip-1.6.3.drv failed

$ diffoscope --exclude-directory-metadata /gnu/store/rykd8wp9ibjf3ad4nlg15vmyzgq9izsp-belle-sip-1.6.3 /gnu/store/rykd8wp9ibjf3ad4nlg15vmyzgq9izsp-belle-sip-1.6.3-check
[...]

I'm not saying that this is a blocker for merging, but basically libbellesip.so (and libbellesip.so.0) doesn't always come out the same.  Spooky.

[Message part 2 (application/pgp-signature, inline)]

Message #138 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Cc: dannym <at> scratchpost.org, maxim.cournoyer <at> gmail.com
Subject: Re: Linphone: 14-add-linphoneqt-v3
Date: Thu, 02 Apr 2020 16:27:30 +0000

[Message part 1 (text/plain, inline)]

Hello Maxim and Danny!

At this point for linphoneqt a.k.a linphone-desktop, I am facing following issues.


When I build *without* `-DENABLE_DBUS=YES`and run the program, I get:

QSocketNotifier: Socket notifiers cannot be enabled or disabled from another thread
QMutex: destroying locked mutex


When I build *with* `-DENABLE_DBUS=YES` and run the program, I get:

Segmentation Fault (Core Dumped)


I think the following patch is relevant, but when I use it, doesn't get successfully patched during the build.

https://gitlab.linphone.org/BC/public/linphone-desktop/commit/9cf08623e3092fa19366e5c07fbe06898a59f039.diff


Any ideas on how to fix this situation?

Thank you!

Regards,
RG.

[14-add-linphoneqt-v3.patch (application/octet-stream, attachment)]

Message #141 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 12-add-belle-sip-v2
Date: Thu, 02 Apr 2020 16:33:49 +0000

Hi Danny!

> belle-sip is not reproducible.

Nice catch!

> I'm not saying that this is a blocker for merging, but basically libbellesip.so (and
> libbellesip.so.0) doesn't always come out the same. Spooky.

Yeah, that is really is spooky. I even disabled the tests as it required network access. Is it possible that there are multiple values set for any environment variable, and it uses different values randomly during each build?

Regards,
RG.

Message #144 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 12-add-belle-sip-v2
Date: Thu, 02 Apr 2020 17:19:29 +0000

Hi Danny!

>> belle-sip is not reproducible.
> 
> Nice catch!
> 
>> I'm not saying that this is a blocker for merging, but basically libbellesip.so (and
>> libbellesip.so.0) doesn't always come out the same. Spooky.
> 
> Yeah, that is really is spooky. I even disabled the tests as it required network access. Is it
> possible that there are multiple values set for any environment variable, and it uses different
> values randomly during each build?

I suspect it could be due to having two different definitions for bctoolbox and ortp. Could you try belle-sip after applying the patch http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40326

Regards,
RG.

Message #147 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 14-add-linphoneqt-v4
Date: Thu, 02 Apr 2020 20:53:18 +0000

[Message part 1 (text/plain, inline)]

[14-add-linphoneqt-v4.patch (application/octet-stream, attachment)]

Message #150 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Cc: dannym <at> scratchpost.org, maxim.cournoyer <at> gmail.com
Subject: Re: Linphone: 14-add-linphoneqt-v3
Date: Thu, 02 Apr 2020 20:56:19 +0000

Hello Maxim and Danny!

> At this point for linphoneqt a.k.a linphone-desktop, I am facing following issues.
> 
> When I build *without* `-DENABLE_DBUS=YES`and run the program, I get:
> 
> QSocketNotifier: Socket notifiers cannot be enabled or disabled from another thread
> QMutex: destroying locked mutex
> 
> When I build *with* `-DENABLE_DBUS=YES` and run the program, I get:
> 
> Segmentation Fault (Core Dumped)
> 
> I think the following patch is relevant, but when I use it, doesn't get successfully patched during
> the build.
> 
> https://gitlab.linphone.org/BC/public/linphone-desktop/commit/9cf08623e3092fa19366e5c07fbe06898a59f0
> 9.diff
> 
> Any ideas on how to fix this situation?

So I fixed "QSocketNotifier" error in version 4 patch (14-add-linphoneqt-v4). I still don't know how to fix "QMutex" error.

Regards,
RG.

Message #153 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 13-add-linphone-v3
Date: Thu, 02 Apr 2020 23:19:27 +0000

[Message part 1 (text/plain, inline)]

[13-add-linphone-v3.patch (application/octet-stream, attachment)]

Message #156 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 14-add-linphoneqt-v5
Date: Fri, 03 Apr 2020 00:24:55 +0000

[Message part 1 (text/plain, inline)]

[14-add-linphoneqt-v5.patch (application/octet-stream, attachment)]

Message #159 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 3-add-bcunit-v2
Date: Fri, 3 Apr 2020 12:51:33 +0200

[Message part 1 (text/plain, inline)]

Hi Raghav,

thanks for the patch!

Pushed to guix master as commit d5a8e391ac2546241d0ff60c9a1fd2fb8ff57536.

[Message part 2 (application/pgp-signature, inline)]

Message #162 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 6-add-belcard-v2
Date: Fri, 3 Apr 2020 12:51:49 +0200

[Message part 1 (text/plain, inline)]

Hi Raghav,

thanks for the patch!

Pushed to guix master as commit c8f69ec27b4d492f63edc71f0a83ec413ea85b96.

[Message part 2 (application/pgp-signature, inline)]

Message #165 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 4-add-bctoolbox-v2
Date: Fri, 3 Apr 2020 12:52:02 +0200

[Message part 1 (text/plain, inline)]

Hi Raghav,

thanks for the patch!

Pushed to guix master as commit bfaabfebac0fc6c3fba2ed4358556b393ef535ce.

[Message part 2 (application/pgp-signature, inline)]

Message #168 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 5-add-belr-v2
Date: Fri, 3 Apr 2020 12:52:17 +0200

[Message part 1 (text/plain, inline)]

Hi Raghav,

thanks for the patch!

Pushed to guix master as commit 63c73bcad0ccd44363611162010b24e2b60629f4.

[Message part 2 (application/pgp-signature, inline)]

Message #171 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 7-add-bcmatroska2-v2
Date: Fri, 3 Apr 2020 12:52:30 +0200

[Message part 1 (text/plain, inline)]

Hi Raghav,

thanks for the patch!

Pushed to guix master as commit 28f6f1e0da2481ce854a893d72d6bdfc5ce97952.

[Message part 2 (application/pgp-signature, inline)]

Message #174 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 8-add-bcg729-v2
Date: Fri, 3 Apr 2020 13:01:46 +0200

[Message part 1 (text/plain, inline)]

Hi Raghav,

thanks for the patch!

Pushed to guix master as commit 02d5d72cfc525e1ec53a02f3a201872f261c7c37.

[Message part 2 (application/pgp-signature, inline)]

Message #177 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 9-add-ortp-v2
Date: Fri, 3 Apr 2020 13:02:46 +0200

[Message part 1 (text/plain, inline)]

Hi Raghav,

thanks for the patch!

Pushed to guix master as commit 13f401d3665a246f5e7d3a9076fdedfe744dd3fd.

[Message part 2 (application/pgp-signature, inline)]

Message #180 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 10-add-bzrtp-v2
Date: Fri, 3 Apr 2020 13:09:31 +0200

[Message part 1 (text/plain, inline)]

Hi Raghav,

thanks for the patch!

Pushed to guix master as commit f3697439cd226f769cdc5ce962f08ad3a1a8bfd6.

[Message part 2 (application/pgp-signature, inline)]

Message #183 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 12-add-belle-sip-v2
Date: Fri, 3 Apr 2020 13:34:35 +0200

[Message part 1 (text/plain, inline)]

Hi Raghav,

On Thu, 02 Apr 2020 17:19:29 +0000
"Raghav Gururajan" <raghavgururajan <at> disroot.org> wrote:

> I suspect it could be due to having two different definitions for bctoolbox and ortp. Could you try belle-sip after applying the patch http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40326

I tried and it didn't help.

However, I found and fixed the problem:

From 1f847861de4ab73011d6243fb652f098e16106cb Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan <at> disroot.org>
Date: Wed, 1 Apr 2020 20:42:33 -0400
Subject: [FIXME 2/2] gnu: Add belle-sip.
Tags: patch

* gnu/packages/linphone.scm (belle-sip): New variable.

Signed-off-by: Danny Milosavljevic <dannym <at> scratchpost.org>
---
 gnu/packages/linphone.scm | 42 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/linphone.scm b/gnu/packages/linphone.scm
index 18a11776e8..9cbbd5e7d6 100644
--- a/gnu/packages/linphone.scm
+++ b/gnu/packages/linphone.scm
@@ -22,11 +22,13 @@
   #:use-module (gnu packages admin)
   #:use-module (gnu packages audio)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages compression)
   #:use-module (gnu packages documentation)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages graphviz)
   #:use-module (gnu packages image)
+  #:use-module (gnu packages java)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages python)
@@ -335,3 +337,43 @@ is responsible for receiving and sending all multimedia streams in Linphone,
 including media capture, encoding and decoding, and rendering.")
     (home-page "https://gitlab.linphone.org/BC/public/mediastreamer2")
     (license license:gpl2+)))
+
+(define-public belle-sip
+  (package
+    (name "belle-sip")
+    (version "1.6.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri
+        (string-append "https://www.linphone.org/releases/sources/" name
+                       "/" name "-" version ".tar.gz"))
+       (sha256
+        (base32 "0s55kggmgxap54dkw5856bgk4xg7yvbzialpxnjm0zhpic3hff1z"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f                      ; Requires network access
+       #:configure-flags
+       (list
+        "-DENABLE_STATIC=NO")
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'patch
+           (lambda _
+             (substitute* "src/CMakeLists.txt"
+              ;; ANTLR would use multithreaded DFA generation
+              ;; otherwise--which would not be reproducible.
+              (("-Xmultithreaded ") ""))
+             #t)))))
+    (inputs
+     `(("antlr3" ,antlr3-3.3)
+       ("antlr3c" ,libantlr3c)
+       ("bctoolbox" ,bctoolbox)
+       ("java" ,icedtea)
+       ("zlib" ,zlib)))
+    (synopsis "Belledonne Communications SIP Library")
+    (description "Belle-sip is a modern library implementing SIP transport,
+transaction and dialog layers.  It is written in C, with an object-oriented
+API.  It also comprises a simple HTTP/HTTPS client implementation.")
+    (home-page "https://gitlab.linphone.org/BC/public/belle-sip")
+    (license license:gpl2+)))

[Message part 2 (application/pgp-signature, inline)]

Message #186 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 11-add-mediastreamer-v2
Date: Fri, 3 Apr 2020 13:38:27 +0200

[Message part 1 (text/plain, inline)]

Hello everyone,

On Thu, 02 Apr 2020 00:20:04 +0000
"Raghav Gururajan" <raghavgururajan <at> disroot.org> wrote:
> +        (list

> +         ;; For fixing definitions.

Yes, but why?  What would happen if we didn't do it?

> +         (origin
> +           (method url-fetch)
> +           (uri
> +            (string-append "https://gitlab.linphone.org/BC/public/mediastreamer2/commit/"
> +                           "de3a24b795d7a78e78eab6b974e7ec5abf2259ac.diff"))
> +           (file-name "mediastreamer-msfactory.patch")

I'm not sure what the outcome of the latest discussion on carrying patches was.
Should we carry patches in Guix now or fetch them from external source?

> +        "-DENABLE_GSM=NO"              ; Need recompilation with -fPIC

Uhhhhhhhhh if that's a library, it should have been compiled with "-fPIC", no?

Which library would need recompilation with "-fPIC"?

[Message part 2 (application/pgp-signature, inline)]

Message #189 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 11-add-mediastreamer-v2
Date: Fri, 03 Apr 2020 14:30:09 +0000

Hi Danny!

>> + (list
>> 
>> + ;; For fixing definitions.
> 
> Yes, but why? What would happen if we didn't do it?

Otherwise, we get `-Werror` flag related compilation errors.

>> + (origin
>> + (method url-fetch)
>> + (uri
>> + (string-append "https://gitlab.linphone.org/BC/public/mediastreamer2/commit"
>> + "de3a24b795d7a78e78eab6b974e7ec5abf2259ac.diff"))
>> + (file-name "mediastreamer-msfactory.patch")
> 
> I'm not sure what the outcome of the latest discussion on carrying patches was.
> Should we carry patches in Guix now or fetch them from external source?

I think it's good as long as we use hash to verify. :-)

>> + "-DENABLE_GSM=NO" ; Need recompilation with -fPIC
> 
> Uhhhhhhhhh if that's a library, it should have been compiled with "-fPIC", no?
> 
> Which library would need recompilation with "-fPIC"?

I am not sure about this one. Since it is a feature, I was planning on to deal this later and disable gsm for now. I hope it is okay.

Regards,
RG.

Message #192 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 14-add-linphoneqt-v6
Date: Fri, 03 Apr 2020 23:47:51 +0000

[Message part 1 (text/plain, inline)]

[14-add-linphoneqt-v6.patch (application/octet-stream, attachment)]

Message #195 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Cc: dannym <at> scratchpost.org, maxim.cournoyer <at> gmail.com
Subject: Re: Linphone: 14-add-linphoneqt-v3
Date: Fri, 03 Apr 2020 23:50:17 +0000

Hello Maxim and Danny!

>> At this point for linphoneqt a.k.a linphone-desktop, I am facing following issues.
>> 
>> When I build *without* `-DENABLE_DBUS=YES`and run the program, I get:
>> 
>> QSocketNotifier: Socket notifiers cannot be enabled or disabled from another thread
>> QMutex: destroying locked mutex
>> 
>> When I build *with* `-DENABLE_DBUS=YES` and run the program, I get:
>> 
>> Segmentation Fault (Core Dumped)
>> 
>> I think the following patch is relevant, but when I use it, doesn't get successfully patched during
>> the build.
>> 
>> https://gitlab.linphone.org/BC/public/linphone-desktop/commit/9cf08623e3092fa19366e5c07fbe06898a59f0
>> 9.diff
>> 
>> Any ideas on how to fix this situation?
> 
> So I fixed "QSocketNotifier" error in version 4 patch (14-add-linphoneqt-v4). I still don't know
> how to fix "QMutex" error.

I have now fixed the "Qmutex error" in version 6 patch (14-add-linphoneqt-v6).

Regards,
RG.

Message #198 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: Raghav Gururajan <raghavgururajan <at> disroot.org>, 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 12-add-belle-sip-v2
Date: Sat, 04 Apr 2020 13:36:32 -0400

Hello Danny and Raghav,

Danny Milosavljevic <dannym <at> scratchpost.org> writes:

> Hi Raghav,
>
> On Thu, 02 Apr 2020 17:19:29 +0000
> "Raghav Gururajan" <raghavgururajan <at> disroot.org> wrote:
>
>> I suspect it could be due to having two different definitions for bctoolbox and ortp. Could you try belle-sip after applying the patch http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40326
>
> I tried and it didn't help.
>
> However, I found and fixed the problem:
>
> From 1f847861de4ab73011d6243fb652f098e16106cb Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Wed, 1 Apr 2020 20:42:33 -0400
> Subject: [FIXME 2/2] gnu: Add belle-sip.
> Tags: patch
>
> * gnu/packages/linphone.scm (belle-sip): New variable.
>
> Signed-off-by: Danny Milosavljevic <dannym <at> scratchpost.org>
> ---
>  gnu/packages/linphone.scm | 42 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>
> diff --git a/gnu/packages/linphone.scm b/gnu/packages/linphone.scm
> index 18a11776e8..9cbbd5e7d6 100644
> --- a/gnu/packages/linphone.scm
> +++ b/gnu/packages/linphone.scm
> @@ -22,11 +22,13 @@
>    #:use-module (gnu packages admin)
>    #:use-module (gnu packages audio)
>    #:use-module (gnu packages base)
> +  #:use-module (gnu packages compression)
>    #:use-module (gnu packages documentation)
>    #:use-module (gnu packages gl)
>    #:use-module (gnu packages gnome)
>    #:use-module (gnu packages graphviz)
>    #:use-module (gnu packages image)
> +  #:use-module (gnu packages java)
>    #:use-module (gnu packages linux)
>    #:use-module (gnu packages pulseaudio)
>    #:use-module (gnu packages python)
> @@ -335,3 +337,43 @@ is responsible for receiving and sending all multimedia streams in Linphone,
>  including media capture, encoding and decoding, and rendering.")
>      (home-page "https://gitlab.linphone.org/BC/public/mediastreamer2")
>      (license license:gpl2+)))
> +
> +(define-public belle-sip
> +  (package
> +    (name "belle-sip")
> +    (version "1.6.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri
> +        (string-append "https://www.linphone.org/releases/sources/" name
> +                       "/" name "-" version ".tar.gz"))
> +       (sha256
> +        (base32 "0s55kggmgxap54dkw5856bgk4xg7yvbzialpxnjm0zhpic3hff1z"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f                      ; Requires network access
> +       #:configure-flags
> +       (list
> +        "-DENABLE_STATIC=NO")
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch
> +           (lambda _
> +             (substitute* "src/CMakeLists.txt"
> +              ;; ANTLR would use multithreaded DFA generation
> +              ;; otherwise--which would not be reproducible.
> +              (("-Xmultithreaded ") ""))
> +             #t)))))

Nice find!  Although note that this doesn't exist in the latest code,
and that the latest release is nearly 3 years old (2017-07-21).  Perhaps
we should just try to package the latest master?  Their git history
suggests many bug fixes, including a memory leak.

Maxim

Message #201 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Maxim Cournoyer" <maxim.cournoyer <at> gmail.com>, "Danny Milosavljevic"
 <dannym <at> scratchpost.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 12-add-belle-sip-v2
Date: Sat, 04 Apr 2020 18:18:24 +0000

> Nice find! Although note that this doesn't exist in the latest code,
> and that the latest release is nearly 3 years old (2017-07-21). Perhaps
> we should just try to package the latest master? Their git history
> suggests many bug fixes, including a memory leak.

In their mail list, one of the dev mentioned that there is going to be a release this year. Also, for consistency, I think it is better that we stick to release tarballs and apply critical patches from master. :-)

Regards,
RG.

Message #204 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: maxim.cournoyer <at> gmail.com
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 11-add-mediastreamer-v2
Date: Sun, 05 Apr 2020 00:08:08 -0400

Hello Raghav,

"Raghav Gururajan" <raghavgururajan <at> disroot.org> writes:

> Hi Danny!
>
>>> + (list
>>>
>>> + ;; For fixing definitions.
>>
>> Yes, but why? What would happen if we didn't do it?
>
> Otherwise, we get `-Werror` flag related compilation errors.

Could you please clarify that in a comment above the patch?

>>> + (origin
>>> + (method url-fetch)
>>> + (uri
>>> + (string-append "https://gitlab.linphone.org/BC/public/mediastreamer2/commit"
>>> + "de3a24b795d7a78e78eab6b974e7ec5abf2259ac.diff"))
>>> + (file-name "mediastreamer-msfactory.patch")
>>
>> I'm not sure what the outcome of the latest discussion on carrying patches was.
>> Should we carry patches in Guix now or fetch them from external source?
>
> I think it's good as long as we use hash to verify. :-)

The problem is that metadata or format of auto-generated patches may
change on a whim.  In past discussions it was decided best to not use
them (that is, it's best to embed a copy of it in Guix sources) [0].

[0]  https://lists.gnu.org/archive/html/guix-devel/2018-11/msg00554.html

I'll post more comments in your original message.

Maxim

Message #207 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: maxim.cournoyer <at> gmail.com
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 11-add-mediastreamer-v2
Date: Sun, 05 Apr 2020 00:16:29 -0400

Hi Raghav!

"Raghav Gururajan" <raghavgururajan <at> disroot.org> writes:

> From 3cf73361203f7833c61a24f69b9ab4bb4da358ce Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Wed, 1 Apr 2020 20:18:20 -0400
> Subject: [PATCH 9/9] gnu: Add mediastreamer
>
> * gnu/packages/linphone.scm (mediastreamer): New variable.
> ---
>  gnu/packages/linphone.scm | 83 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 83 insertions(+)
>
> diff --git a/gnu/packages/linphone.scm b/gnu/packages/linphone.scm
> index 3be35bdb74..ce3ffa763b 100644
> --- a/gnu/packages/linphone.scm
> +++ b/gnu/packages/linphone.scm
> @@ -19,12 +19,24 @@
>  
>  (define-module (gnu packages linphone)
>    #:use-module (gnu packages)
> +  #:use-module (gnu packages admin)
> +  #:use-module (gnu packages audio)
>    #:use-module (gnu packages base)
>    #:use-module (gnu packages documentation)
> +  #:use-module (gnu packages gl)
> +  #:use-module (gnu packages gnome)
>    #:use-module (gnu packages graphviz)
> +  #:use-module (gnu packages image)
> +  #:use-module (gnu packages linux)
> +  #:use-module (gnu packages pulseaudio)
> +  #:use-module (gnu packages python)
>    #:use-module (gnu packages sqlite)
> +  #:use-module (gnu packages telephony)
>    #:use-module (gnu packages tls)
> +  #:use-module (gnu packages video)
> +  #:use-module (gnu packages xiph)
>    #:use-module (gnu packages xml)
> +  #:use-module (gnu packages xorg)
>    #:use-module ((guix licenses) #:prefix license:)
>    #:use-module (guix packages)
>    #:use-module (guix download)
> @@ -252,3 +264,74 @@ protocol, written in C.  It is fully portable and can be executed on many
>  platforms including both ARM and x86.")
>      (home-page "https://gitlab.linphone.org/BC/public/bzrtp")
>      (license license:gpl2+)))
> +
> +(define-public mediastreamer
> +  (package
> +    (name "mediastreamer")

The variable name and package name should be "mediastreamer2", as per
upstream.

> +    (version "2.16.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri
> +        (string-append "https://www.linphone.org/releases/sources/" name
> +                       "/" name "-" version ".tar.gz"))
> +       (sha256
> +        (base32 "0whpqr69wz0pnzvragkpfblxhd0rds8k06c3mw5a0ag216a1yd9k"))
> +       (patches
> +        (list
> +         ;; For fixing definitions.
> +         (origin
> +           (method url-fetch)
> +           (uri
> +            (string-append "https://gitlab.linphone.org/BC/public/mediastreamer2/commit/"
> +                           "de3a24b795d7a78e78eab6b974e7ec5abf2259ac.diff"))
> +           (file-name "mediastreamer-msfactory.patch")
> +           (sha256
> +            (base32 "18lsn9fc9di8bzr12ck3h9k9h8xvvhjzgkimbj9p4vmxxwhjaxn2")))))))

You can just use the "ENABLE_STRICT=NO", which will disable -Werror and
make the package more resilient in the face of future compiler upgrades
in Guix.  No more need for that patch :-).

> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f                      ; No test target
> +       #:configure-flags
> +       (list
> +        "-DENABLE_SRTP=NO"             ; Using ZRTP instead

Usually we try to offer the most features possible.  I don't see why we
shouldn't add SRTP support since we should already have the required
dependencies.

Also, I see there's a ENABLE_UNIT_TESTS=YES option for unit tests, which
we should enable and try to run.

> +        "-DENABLE_STATIC=NO"           ; Not required
> +        "-DENABLE_GSM=NO"              ; Need recompilation with -fPIC

Not a merge breaker, but it'd make sense to have GSM for telephony
focused software :-).

> +        "-DENABLE_BV16=NO")))          ; Not available
> +    (native-inputs
> +     `(("dot" ,graphviz)
> +       ("doxygen" ,doxygen)
> +       ("python" ,python)))
> +    (inputs
> +     `(("alsa" ,alsa-lib)
> +       ("bcg729" ,bcg729)
> +       ("bcmatroska2" ,bcmatroska2)
> +       ("bctoolbox" ,bctoolbox)
> +       ("ffmpeg" ,ffmpeg)
> +       ("glew" ,glew)
> +       ("glu" ,glu)
> +       ("glx" ,mesa-utils)
> +       ("gsm" ,gsm)
> +       ("opengl" ,mesa)
> +       ("opus" ,opus)
> +       ("ortp" ,ortp)
> +       ("pcap" ,libpcap)
> +       ("portaudio" ,portaudio)
> +       ("pulseaudio" ,pulseaudio)
> +       ("spandsp" ,spandsp)
> +       ("speex" ,speex)
> +       ("speexdsp" ,speexdsp)
> +       ("srtp" ,libsrtp)
> +       ("theora" ,libtheora)
> +       ("turbojpeg" ,libjpeg-turbo)
> +       ("v4l" ,v4l-utils)
> +       ("vpx" ,libvpx)
> +       ("x11" ,libx11)
> +       ("xv" ,libxv)
> +       ("zrtp", bzrtp)))
> +    (synopsis "Belledonne Communications Streaming Engine")
> +    (description "Mediastreamer is a powerful and
> lightweight streaming

There are some strange characters in there (around 'powerful').  Please
edit them out.

Maxim

Message #210 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: maxim.cournoyer <at> gmail.com
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 12-add-belle-sip-v2
Date: Sun, 05 Apr 2020 00:18:07 -0400

"Raghav Gururajan" <raghavgururajan <at> disroot.org> writes:

>> Nice find! Although note that this doesn't exist in the latest code,
>> and that the latest release is nearly 3 years old (2017-07-21). Perhaps
>> we should just try to package the latest master? Their git history
>> suggests many bug fixes, including a memory leak.
>
> In their mail list, one of the dev mentioned that there is going to be a release this year. Also, for consistency, I think it is better that we stick to release tarballs and apply critical patches from master. :-)
>
> Regards,
> RG.

Sounds reasonable!  Thanks for the information.

Maxim

Message #215 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 11-add-mediastreamer-v3
Date: Sun, 05 Apr 2020 07:28:06 +0000

[Message part 1 (text/plain, inline)]

[11-add-mediastreamer-v3.patch (application/octet-stream, attachment)]

Message #218 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: maxim.cournoyer <at> gmail.com
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 11-add-mediastreamer-v2
Date: Sun, 05 Apr 2020 07:29:05 +0000

Hi Maxim!

>> From 3cf73361203f7833c61a24f69b9ab4bb4da358ce Mon Sep 17 00:00:00 2001
>> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
>> Date: Wed, 1 Apr 2020 20:18:20 -0400
>> Subject: [PATCH 9/9] gnu: Add mediastreamer
>> 
>> * gnu/packages/linphone.scm (mediastreamer): New variable.
>> ---
>> gnu/packages/linphone.scm | 83 +++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 83 insertions(+)
>> 
>> diff --git a/gnu/packages/linphone.scm b/gnu/packages/linphone.scm
>> index 3be35bdb74..ce3ffa763b 100644
>> --- a/gnu/packages/linphone.scm
>> +++ b/gnu/packages/linphone.scm
>> @@ -19,12 +19,24 @@
>> 
>> (define-module (gnu packages linphone)
>> #:use-module (gnu packages)
>> + #:use-module (gnu packages admin)
>> + #:use-module (gnu packages audio)
>> #:use-module (gnu packages base)
>> #:use-module (gnu packages documentation)
>> + #:use-module (gnu packages gl)
>> + #:use-module (gnu packages gnome)
>> #:use-module (gnu packages graphviz)
>> + #:use-module (gnu packages image)
>> + #:use-module (gnu packages linux)
>> + #:use-module (gnu packages pulseaudio)
>> + #:use-module (gnu packages python)
>> #:use-module (gnu packages sqlite)
>> + #:use-module (gnu packages telephony)
>> #:use-module (gnu packages tls)
>> + #:use-module (gnu packages video)
>> + #:use-module (gnu packages xiph)
>> #:use-module (gnu packages xml)
>> + #:use-module (gnu packages xorg)
>> #:use-module ((guix licenses) #:prefix license:)
>> #:use-module (guix packages)
>> #:use-module (guix download)
>> @@ -252,3 +264,74 @@ protocol, written in C. It is fully portable and can be executed on many
>> platforms including both ARM and x86.")
>> (home-page "https://gitlab.linphone.org/BC/public/bzrtp")
>> (license license:gpl2+)))
>> +
>> +(define-public mediastreamer
>> + (package
>> + (name "mediastreamer")
> 
> The variable name and package name should be "mediastreamer2", as per
> upstream.
> 
>> + (version "2.16.1")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri
>> + (string-append "https://www.linphone.org/releases/sources" name
>> + "/" name "-" version ".tar.gz"))
>> + (sha256
>> + (base32 "0whpqr69wz0pnzvragkpfblxhd0rds8k06c3mw5a0ag216a1yd9k"))
>> + (patches
>> + (list
>> + ;; For fixing definitions.
>> + (origin
>> + (method url-fetch)
>> + (uri
>> + (string-append "https://gitlab.linphone.org/BC/public/mediastreamer2/commit"
>> + "de3a24b795d7a78e78eab6b974e7ec5abf2259ac.diff"))
>> + (file-name "mediastreamer-msfactory.patch")
>> + (sha256
>> + (base32 "18lsn9fc9di8bzr12ck3h9k9h8xvvhjzgkimbj9p4vmxxwhjaxn2")))))))
> 
> You can just use the "ENABLE_STRICT=NO", which will disable -Werror and
> make the package more resilient in the face of future compiler upgrades
> in Guix. No more need for that patch :-).
> 
>> + (build-system cmake-build-system)
>> + (arguments
>> + `(#:tests? #f ; No test target
>> + #:configure-flags
>> + (list
>> + "-DENABLE_SRTP=NO" ; Using ZRTP instead
> 
> Usually we try to offer the most features possible. I don't see why we
> shouldn't add SRTP support since we should already have the required
> dependencies.
> 
> Also, I see there's a ENABLE_UNIT_TESTS=YES option for unit tests, which
> we should enable and try to run.
> 
>> + "-DENABLE_STATIC=NO" ; Not required
>> + "-DENABLE_GSM=NO" ; Need recompilation with -fPIC
> 
> Not a merge breaker, but it'd make sense to have GSM for telephony
> focused software :-).
> 
>> + "-DENABLE_BV16=NO"))) ; Not available
>> + (native-inputs
>> + `(("dot" ,graphviz)
>> + ("doxygen" ,doxygen)
>> + ("python" ,python)))
>> + (inputs
>> + `(("alsa" ,alsa-lib)
>> + ("bcg729" ,bcg729)
>> + ("bcmatroska2" ,bcmatroska2)
>> + ("bctoolbox" ,bctoolbox)
>> + ("ffmpeg" ,ffmpeg)
>> + ("glew" ,glew)
>> + ("glu" ,glu)
>> + ("glx" ,mesa-utils)
>> + ("gsm" ,gsm)
>> + ("opengl" ,mesa)
>> + ("opus" ,opus)
>> + ("ortp" ,ortp)
>> + ("pcap" ,libpcap)
>> + ("portaudio" ,portaudio)
>> + ("pulseaudio" ,pulseaudio)
>> + ("spandsp" ,spandsp)
>> + ("speex" ,speex)
>> + ("speexdsp" ,speexdsp)
>> + ("srtp" ,libsrtp)
>> + ("theora" ,libtheora)
>> + ("turbojpeg" ,libjpeg-turbo)
>> + ("v4l" ,v4l-utils)
>> + ("vpx" ,libvpx)
>> + ("x11" ,libx11)
>> + ("xv" ,libxv)
>> + ("zrtp", bzrtp)))
>> + (synopsis "Belledonne Communications Streaming Engine")
>> + (description "Mediastreamer is apowerfuland
>> lightweight streaming
> 
> There are some strange characters in there (around 'powerful'). Please
> edit them out.

I fixed everything in 11-add-mediastreamer-v3. :-)

Regards,
RG.

Message #221 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: maxim.cournoyer <at> gmail.com
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 11-add-mediastreamer-v3
Date: Sun, 05 Apr 2020 11:02:47 -0400

"Raghav Gururajan" <raghavgururajan <at> disroot.org> writes:

> From c9f9ecc04aaff5c48490e3fc88b0b2b4ef79eafb Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Sun, 5 Apr 2020 03:25:10 -0400
> Subject: [PATCH 3/3] gnu: Add mediastreamer2
>
> * gnu/packages/linphone.scm (mediastreamer2): New variable.
> ---
>  gnu/packages/linphone.scm                     |  78 +++++++++
>  .../patches/mediastreamer-msfactory.patch     |  31 ++++
>  .../patches/mediastreamer-srtp2.patch         | 155 ++++++++++++++++++
>  3 files changed, 264 insertions(+)
>  create mode 100644 gnu/packages/patches/mediastreamer-msfactory.patch
>  create mode 100644 gnu/packages/patches/mediastreamer-srtp2.patch

Is the mediastreamer-srtp2 patch really required?  I could build the
package successfully (with libsrtp) without it.  Please rename the
patches mediastream2 to reflect the updated package name (the '2'
suffix).

Also, patches must be registered in gnu/local.mk (in the dist_patch_DATA
variable), otherwise they won't be included in the sources of Guix.

> diff --git a/gnu/packages/linphone.scm b/gnu/packages/linphone.scm
> index 0e32500b07..a3ec664a40 100644
> --- a/gnu/packages/linphone.scm
> +++ b/gnu/packages/linphone.scm
> @@ -19,12 +19,24 @@
>  
>  (define-module (gnu packages linphone)
>    #:use-module (gnu packages)
> +  #:use-module (gnu packages admin)
> +  #:use-module (gnu packages audio)
>    #:use-module (gnu packages base)
>    #:use-module (gnu packages documentation)
> +  #:use-module (gnu packages gl)
> +  #:use-module (gnu packages gnome)
>    #:use-module (gnu packages graphviz)
> +  #:use-module (gnu packages image)
> +  #:use-module (gnu packages linux)
> +  #:use-module (gnu packages pulseaudio)
> +  #:use-module (gnu packages python)
>    #:use-module (gnu packages sqlite)
> +  #:use-module (gnu packages telephony)
>    #:use-module (gnu packages tls)
> +  #:use-module (gnu packages video)
> +  #:use-module (gnu packages xiph)
>    #:use-module (gnu packages xml)
> +  #:use-module (gnu packages xorg)
>    #:use-module ((guix licenses) #:prefix license:)
>    #:use-module (guix packages)
>    #:use-module (guix download)
> @@ -252,3 +264,69 @@ protocol, written in C.  It is fully portable and can be executed on many
>  platforms including both ARM and x86.")
>      (home-page "https://gitlab.linphone.org/BC/public/bzrtp")
>      (license license:gpl2+)))
> +
> +(define-public mediastreamer2
> +  (package
> +    (name "mediastreamer")
> +    (version "2.16.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri
> +        (string-append "https://www.linphone.org/releases/sources/" name
> +                       "/" name "-" version ".tar.gz"))
> +       (sha256
> +        (base32 "0whpqr69wz0pnzvragkpfblxhd0rds8k06c3mw5a0ag216a1yd9k"))
> +       (patches
> +        (list
> +         ;; For updating definitions.
> +         ;; Fixes "-Werror" flag related errors and MS2_GIT_VERSION error.
> +         (search-patch "mediastreamer-msfactory.patch")
> +         ;; For srtp2 compatibility.
> +         ;; Fixes locating srtp2 files.
> +         (search-patch "mediastreamer-srtp2.patch")))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f                      ; No test target
> +       #:configure-flags
> +       (list
> +        "-DENABLE_STATIC=NO"            ; Not required
> +        "-DENABLE_BV16=NO")))           ; Not available

Could you investigate the ENABLE_UNIT_TESTS=yes option?

> +    (native-inputs
> +     `(("dot" ,graphviz)
> +       ("doxygen" ,doxygen)
> +       ("python" ,python)))
> +    (inputs
> +     `(("alsa" ,alsa-lib)
> +       ("bcg729" ,bcg729)
> +       ("bcmatroska2" ,bcmatroska2)
> +       ("bctoolbox" ,bctoolbox)
> +       ("ffmpeg" ,ffmpeg)
> +       ("glew" ,glew)
> +       ("glu" ,glu)
> +       ("glx" ,mesa-utils)
> +       ("gsm" ,gsm)
> +       ("opengl" ,mesa)
> +       ("opus" ,opus)
> +       ("ortp" ,ortp)
> +       ("pcap" ,libpcap)
> +       ("portaudio" ,portaudio)
> +       ("pulseaudio" ,pulseaudio)
> +       ("spandsp" ,spandsp)
> +       ("speex" ,speex)
> +       ("speexdsp" ,speexdsp)
> +       ("srtp" ,libsrtp)
> +       ("theora" ,libtheora)
> +       ("turbojpeg" ,libjpeg-turbo)
> +       ("v4l" ,v4l-utils)
> +       ("vpx" ,libvpx)
> +       ("x11" ,libx11)
> +       ("xv" ,libxv)
> +       ("zrtp", bzrtp)))
> +    (synopsis "Belledonne Communications Streaming Engine")
> +    (description "Mediastreamer is a powerful and lightweight streaming

I still see strange characters here:   ^               ^

Otherwise, LGTM.

Maxim

Message #224 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 11-add-mediastreamer-v3
Date: Sun, 5 Apr 2020 20:29:40 +0200

[Message part 1 (text/plain, inline)]

Does 

  ENABLE_STRICT=NO

instead of mediastreamer-msfactory.patch work or not?

[Message part 2 (application/pgp-signature, inline)]

Message #227 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 12-add-belle-sip-v2
Date: Sun, 5 Apr 2020 21:06:14 +0200

[Message part 1 (text/plain, inline)]

Pushed this patch to guix master as commit e7859da11371e9bd0fffc5235b9e980cccf4b239.

[Message part 2 (application/pgp-signature, inline)]

Message #230 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 11-add-mediastreamer-v3
Date: Sun, 5 Apr 2020 21:41:34 +0200

[Message part 1 (text/plain, inline)]

Hi,

On Sun, 5 Apr 2020 20:29:40 +0200
Danny Milosavljevic <dannym <at> scratchpost.org> wrote:

> Does 
> 
>   ENABLE_STRICT=NO
> 
> instead of mediastreamer-msfactory.patch work or not?

Yes.

So added mediastreamer2 without any patches to guix master as
commit b6b3a6a6c4f00815da576912907c7bdbf02ca11a.

If the patches are required after all (for example the srtp2 one--is it
correct that this one updates the dependency from srtp1 to srtp2?), we
can still add them.

I've also renamed the package to mediastreamer2 like upstream does
(I don't like the name so much--but upstream chose it, so be it).

[Message part 2 (application/pgp-signature, inline)]

Message #233 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 13-add-linphone-v2
Date: Sun, 5 Apr 2020 21:49:54 +0200

[Message part 1 (text/plain, inline)]

How come that https://github.com/BelledonneCommunications/liblinphone/releases has 4.3.1 and we have 3.12.0 ?

[Message part 2 (application/pgp-signature, inline)]

Message #236 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 13-add-linphone-v2
Date: Sun, 5 Apr 2020 21:57:01 +0200

[Message part 1 (text/plain, inline)]

Renamed package to liblinphone and pushed this patch to guix master as
commit 9732910dd336e9bca56991a0630619bc1578d2af.

[Message part 2 (application/pgp-signature, inline)]

Message #239 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 13-add-linphone-v3
Date: Sun, 5 Apr 2020 22:05:43 +0200

[Message part 1 (text/plain, inline)]

Pushed to guix master as commit 02b32cdda68495344d8e5521db5aeaf5add03797.

[Message part 2 (application/pgp-signature, inline)]

Message #242 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 14-add-linphoneqt-v6
Date: Sun, 5 Apr 2020 22:19:32 +0200

[Message part 1 (text/plain, inline)]

This package is not reproducible.  Probably something simple amiss.

diffoscope --exclude-directory-metadata /gnu/store/p9186fvq27dawzmij3q2ibllhdd07c6a-linphoneqt-4.1.1 /gnu/store/p9186fvq27dawzmij3q2ibllhdd07c6a-linphoneqt-4.1.1-check
--- /gnu/store/p9186fvq27dawzmij3q2ibllhdd07c6a-linphoneqt-4.1.1
+++ /gnu/store/p9186fvq27dawzmij3q2ibllhdd07c6a-linphoneqt-4.1.1-check
├── bin
│ ├── linphone
│ │ ├── /gnu/store/mx2bgrpxkbdjsmhlxp9a30hbzcilk4cn-binutils-2.32/bin/readelf --wide --decompress --hex-dump=.rodata {}
│ │ │ @@ -190213,17 +190213,17 @@
│ │ │    0x00801020 02000a00 12000309 3b093c09 3d000109 ........;.<.=...
│ │ │    0x00801030 3e000100 02010c05 56000200 0c000300 >.......V.......
│ │ │    0x00801040 f3023706 03000100 03004c00 4d045700 ..7.......L.M.W.
│ │ │    0x00801050 00000000 00000000 00000000 00000000 ................
│ │ │    0x00801060 00000000 00020000 00010000 00010000 ................
│ │ │    0x00801070 00000000 00000000 00000002 00000002 ................
│ │ │    0x00801080 00000002 00000000 00000000 00000018 ................
│ │ │ -  0x00801090 00010000 00010000 00000000 01714bf9 .............qK.
│ │ │ -  0x008010a0 65980000 00220001 00000001 0000280f e...."........(.
│ │ │ -  0x008010b0 00000171 4bf96598 00000000 00000000 ...qK.e.........
│ │ │ +  0x00801090 00010000 00010000 00000000 01714bf7 .............qK.
│ │ │ +  0x008010a0 f3330000 00220001 00000001 0000280f .3..."........(.
│ │ │ +  0x008010b0 00000171 4bf7f333 00000000 00000000 ...qK..3........
│ │ │    0x008010c0 000904eb 98c3006c 0061006e 00670075 .......l.a.n.g.u
│ │ │    0x008010d0 00610067 00650073 00020000 06be0065 .a.g.e.s.......e
│ │ │    0x008010e0 006e0002 000006d2 00660072 00000000 .n.......f.r....
│ │ │    0x008010f0 00000000 00000000 00000000 00000000 ................
│ │ │    0x00801100 0000280b 00008688 789ce57d 0b741cc5 ..(.....x..}.t..
│ │ │    0x00801110 9568c992 a5d16834 92654996 8531c236 .h....h4.eI..1.6
│ │ │    0x00801120 c626c618 639b9f31 8cf58905 922ceb63 .&..c..1.....,.c
│ ├── linphone-tester
│ │ ├── /gnu/store/mx2bgrpxkbdjsmhlxp9a30hbzcilk4cn-binutils-2.32/bin/readelf --wide --decompress --hex-dump=.rodata {}
│ │ │ @@ -190443,17 +190443,17 @@
│ │ │    0x0080be80 02000a00 12000309 3b093c09 3d000109 ........;.<.=...
│ │ │    0x0080be90 3e000100 02010c05 56000200 0c000300 >.......V.......
│ │ │    0x0080bea0 f3023706 03000100 03004c00 4d045700 ..7.......L.M.W.
│ │ │    0x0080beb0 00000000 00000000 00000000 00000000 ................
│ │ │    0x0080bec0 00000000 00020000 00010000 00010000 ................
│ │ │    0x0080bed0 00000000 00000000 00000002 00000002 ................
│ │ │    0x0080bee0 00000002 00000000 00000000 00000018 ................
│ │ │ -  0x0080bef0 00010000 00010000 00000000 01714bf9 .............qK.
│ │ │ -  0x0080bf00 65980000 00220001 00000001 0000280f e...."........(.
│ │ │ -  0x0080bf10 00000171 4bf96598 00000000 00000000 ...qK.e.........
│ │ │ +  0x0080bef0 00010000 00010000 00000000 01714bf7 .............qK.
│ │ │ +  0x0080bf00 f3330000 00220001 00000001 0000280f .3..."........(.
│ │ │ +  0x0080bf10 00000171 4bf7f333 00000000 00000000 ...qK..3........
│ │ │    0x0080bf20 000904eb 98c3006c 0061006e 00670075 .......l.a.n.g.u
│ │ │    0x0080bf30 00610067 00650073 00020000 06be0065 .a.g.e.s.......e
│ │ │    0x0080bf40 006e0002 000006d2 00660072 00000000 .n.......f.r....
│ │ │    0x0080bf50 00000000 00000000 00000000 00000000 ................
│ │ │    0x0080bf60 0000280b 00008688 789ce57d 0b741cc5 ..(.....x..}.t..
│ │ │    0x0080bf70 9568c992 a5d16834 92654996 8531c236 .h....h4.eI..1.6
│ │ │    0x0080bf80 c626c618 639b9f31 8cf58905 922ceb63 .&..c..1.....,.c

[Message part 2 (application/pgp-signature, inline)]

Message #245 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 11-add-mediastreamer-v3
Date: Sun, 05 Apr 2020 22:52:25 +0000

Hi Danny!

> So added mediastreamer2 without any patches to guix master as
> commit b6b3a6a6c4f00815da576912907c7bdbf02ca11a.

Thanks for the push.

> If the patches are required after all (for example the srtp2 one--is it
> correct that this one updates the dependency from srtp1 to srtp2?), we
> can still add them.

Oh no, that patch is required. MS won't build with srtp enabled, without it. You can see "MediaStreamer will be built without SRTP support". That patch fixes search and locate of srtp2 version of include and lib files.

> I've also renamed the package to mediastreamer2 like upstream does
> (I don't like the name so much--but upstream chose it, so be it).

Shall we please keep the name "mediastreamer" for package and "mediastreamer2" for variable? The release tarballs have not been renamed. We'll change the package name when it is changed in releases by upstream. This will consistent with other packages in linphone.scm.

Regards,
RG.

Message #248 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 13-add-linphone-v2
Date: Sun, 05 Apr 2020 22:54:15 +0000

Hi Danny!

> How come that https://github.com/BelledonneCommunications/liblinphone/releases has 4.3.1 and we
> have 3.12.0 ?

Releases tag in gitlab.linphone.org are for internal purposes. Official releases are done at linphone.org/releases/sources.

Message #251 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 13-add-linphone-v2
Date: Sun, 05 Apr 2020 22:55:37 +0000

Hi Danny!

> Renamed package to liblinphone and pushed this patch to guix master as
> commit 9732910dd336e9bca56991a0630619bc1578d2af.

Thanks for the push :-)

Shall we please keep the name "linphone" for package and "liblinphone" for variable? The release tarballs have not been renamed (linphone.org/releases/sources). We'll change the package name when it is changed in releases by upstream. This will consistent with other packages in linphone.scm.

Regards,
RG.

Message #254 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 16-add-msopenh264-v2
Date: Mon, 6 Apr 2020 01:05:23 +0200

[Message part 1 (text/plain, inline)]

Thanks for the patch!

Pushed to guix master as commit 376fc95e29b24609f3cb7fca024e93a37c0adbfe.

[Message part 2 (application/pgp-signature, inline)]

Message #257 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 17-add-mssilk-v2
Date: Mon, 6 Apr 2020 01:06:00 +0200

[Message part 1 (text/plain, inline)]

Thanks for the patch!

Pushed to guix master as commit f689d3d7d9ba3fa25b4839bdd1e4b98905f4869c.

[Message part 2 (application/pgp-signature, inline)]

Message #260 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 18-add-mswebrtc-v2
Date: Mon, 6 Apr 2020 01:06:36 +0200

[Message part 1 (text/plain, inline)]

Thanks for the patch!

Pushed to guix master as commit fe8f1c0b194de2fa7aa5265a4a0424e82bd11af1.

[Message part 2 (application/pgp-signature, inline)]

Message #263 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linohone: 15-add-msamr-v2
Date: Mon, 6 Apr 2020 02:03:37 +0200

[Message part 1 (text/plain, inline)]

Hi Raghav,

thanks for the patch!

Pushed to guix master as commit b89201695582351fa5fa183c7a1aa26162ca271e.

[Message part 2 (application/pgp-signature, inline)]

Message #266 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 11-add-mediastreamer-v3
Date: Mon, 6 Apr 2020 02:14:48 +0200

[Message part 1 (text/plain, inline)]

Hi Raghav,

On Sun, 05 Apr 2020 22:52:25 +0000
"Raghav Gururajan" <raghavgururajan <at> disroot.org> wrote:

> Oh no, that patch is required. MS won't build with srtp enabled, without it.

Okay--added in commit 2c56aeaea94d3914acf79f9bbabeef1b3ec8aa07.

> Shall we please keep the name "mediastreamer" for package and "mediastreamer2" for variable? The release tarballs have not been renamed. We'll change the package name when it is changed in releases by upstream. This will consistent with other packages in linphone.scm.

I'll see what the others say--but I'm not opposed to use the other name.

[Message part 2 (application/pgp-signature, inline)]

Message #269 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 11-add-mediastreamer-v3
Date: Mon, 06 Apr 2020 00:28:01 +0000

Hi Danny!

>> Oh no, that patch is required. MS won't build with srtp enabled, without it.
> 
> Okay--added in commit 2c56aeaea94d3914acf79f9bbabeef1b3ec8aa07.

Thanks so much :-)

>> Shall we please keep the name "mediastreamer" for package and "mediastreamer2" for variable? The
>> release tarballs have not been renamed. We'll change the package name when it is changed in
>> releases by upstream. This will consistent with other packages in linphone.scm.
> 
> I'll see what the others say--but I'm not opposed to use the other name.

Cool!

Regards,
RG.

Message #272 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: maxim.cournoyer <at> gmail.com
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 11-add-mediastreamer-v3
Date: Sun, 05 Apr 2020 22:40:26 -0400

Hello,

"Raghav Gururajan" <raghavgururajan <at> disroot.org> writes:

> Hi Danny!
>
>>> Oh no, that patch is required. MS won't build with srtp enabled, without it.
>>
>> Okay--added in commit 2c56aeaea94d3914acf79f9bbabeef1b3ec8aa07.
>
> Thanks so much :-)
>
>>> Shall we please keep the name "mediastreamer" for package and "mediastreamer2" for variable? The
>>> release tarballs have not been renamed. We'll change the package name when it is changed in
>>> releases by upstream. This will consistent with other packages in linphone.scm.
>>
>> I'll see what the others say--but I'm not opposed to use the other name.

mediastreamer2 is better.  Otherwise we get a confused mix of
mediastreamer-2.16.1 / mediastreamer2-2.16.1 under share/, for example.
The name really is mediastreamer2 in the code/doc, everywhere except in
for the tarball file name.

I'll push some refinements I made today in a moment, mostly adding the
tester binary and data to a 'tester' output (it comes with about 20 MiB
of data files).

Great work!

Maxim

Message #275 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 14-add-linphoneqt-v6
Date: Mon, 06 Apr 2020 03:01:32 +0000

Hi Danny!

> This package is not reproducible. Probably something simple amiss.

Nice catch! Let me try to see what causes it.

Btw, is there everything else good with the package?

Regards,
RG.

Message #278 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Linphone: 14-add-linphoneqt-v7
Date: Mon, 06 Apr 2020 04:04:47 +0000

[Message part 1 (text/plain, inline)]

[14-add-linphoneqt-v7.patch (application/octet-stream, attachment)]

Message #281 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 14-add-linphoneqt-v6
Date: Mon, 06 Apr 2020 05:56:12 +0000

Hi Danny!

>> This package is not reproducible. Probably something simple amiss.
> 
> Nice catch! Let me try to see what causes it.
> 
> Btw, is there everything else good with the package?

Hmm, I think it is something to with computing QML files.

Message #284 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Replace source URI with mirror.
Date: Wed, 08 Apr 2020 07:01:13 +0000

[Message part 1 (text/plain, inline)]

[0001-download-Add-linphone.patch (application/octet-stream, attachment)]

[0002-gnu-linphone-Replace-source-URI-with-mirror.patch (application/octet-stream, attachment)]

Message #287 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 40264 <at> debbugs.gnu.org
Subject: Mirror and Formatting
Date: Wed, 08 Apr 2020 07:29:48 +0000

[Message part 1 (text/plain, inline)]

[0001-download-Add-linphone.patch (application/octet-stream, attachment)]

[0002-gnu-linphone-Replace-source-URI-with-mirror.patch (application/octet-stream, attachment)]

[0003-gnu-linphone-Fix-formatting.patch (application/octet-stream, attachment)]

Message #290 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 14-add-linphoneqt-v7
Date: Fri, 10 Apr 2020 23:47:55 +0200

[Message part 1 (text/plain, inline)]

Hi Raghav,

if we add gcc 5 here, do we need to do something similar to
https://lists.gnu.org/archive/html/guix-commits/2020-04/msg00774.html too or
not?

Why is only gcc 5 working and not gcc 7?

[Message part 2 (application/pgp-signature, inline)]

Message #293 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 14-add-linphoneqt-v7
Date: Sat, 11 Apr 2020 01:50:09 +0200

[Message part 1 (text/plain, inline)]

Hi Raghav,

pushed to guix core-updates (with changes below) because, there, it works
without weird special gcc versions.

Commit is c0cce2055757c18619ef1826c54ed3d5b9ec7eb0.

Moved all propagated-inputs to regular inputs--except qttools which I moved to
native-inputs.

Added qtgraphicaleffects to inputs.

Switched to qt build system so the programs actually start up successfully.

There is still the same reproducibility problems in bin/linphone and
bin/linphone-tester:

--- /gnu/store/7g8kdcwzvybx7a8w87pnbypy7x0rf9wg-linphoneqt-4.1.1
+++ /gnu/store/7g8kdcwzvybx7a8w87pnbypy7x0rf9wg-linphoneqt-4.1.1-check
├── bin
│ ├── linphone
│ │ ├── /gnu/store/mx2bgrpxkbdjsmhlxp9a30hbzcilk4cn-binutils-2.32/bin/readelf --wide --decompress --hex-dump=.rodata {}
│ │ │ @@ -190223,17 +190223,17 @@
│ │ │    0x008080c0 02000a00 12000309 3b093c09 3d000109 ........;.<.=...
│ │ │    0x008080d0 3e000100 02010c05 56000200 0c000300 >.......V.......
│ │ │    0x008080e0 f3023706 03000100 03004c00 4d045700 ..7.......L.M.W.
│ │ │    0x008080f0 00000000 00000000 00000000 00000000 ................
│ │ │    0x00808100 00000000 00020000 00010000 00010000 ................
│ │ │    0x00808110 00000000 00000000 00000002 00000002 ................
│ │ │    0x00808120 00000002 00000000 00000000 00000018 ................
│ │ │ -  0x00808130 00010000 00010000 00000000 0171666d .............qfm
│ │ │ -  0x00808140 dfb80000 00220001 00000001 0000280f ....."........(.
│ │ │ -  0x00808150 00000171 666ddfb8 00000000 00000000 ...qfm..........
│ │ │ +  0x00808130 00010000 00010000 00000000 0171666c .............qfl
│ │ │ +  0x00808140 71bb0000 00220001 00000001 0000280f q...."........(.
│ │ │ +  0x00808150 00000171 666c71bb 00000000 00000000 ...qflq.........
│ │ │    0x00808160 000904eb 98c3006c 0061006e 00670075 .......l.a.n.g.u
│ │ │    0x00808170 00610067 00650073 00020000 06be0065 .a.g.e.s.......e
│ │ │    0x00808180 006e0002 000006d2 00660072 00000000 .n.......f.r....
│ │ │    0x00808190 00000000 00000000 00000000 00000000 ................
│ │ │    0x008081a0 0000280b 00008688 789ce57d 0b741cc5 ..(.....x..}.t..
│ │ │    0x008081b0 9568c992 a5d16834 92654996 8531c236 .h....h4.eI..1.6
│ │ │    0x008081c0 c626c618 639b9f31 8cf58905 922ceb63 .&..c..1.....,.c
│ ├── linphone-tester
│ │ ├── /gnu/store/mx2bgrpxkbdjsmhlxp9a30hbzcilk4cn-binutils-2.32/bin/readelf --wide --decompress --hex-dump=.rodata {}
│ │ │ @@ -190455,17 +190455,17 @@
│ │ │    0x00811f40 02000a00 12000309 3b093c09 3d000109 ........;.<.=...
│ │ │    0x00811f50 3e000100 02010c05 56000200 0c000300 >.......V.......
│ │ │    0x00811f60 f3023706 03000100 03004c00 4d045700 ..7.......L.M.W.
│ │ │    0x00811f70 00000000 00000000 00000000 00000000 ................
│ │ │    0x00811f80 00000000 00020000 00010000 00010000 ................
│ │ │    0x00811f90 00000000 00000000 00000002 00000002 ................
│ │ │    0x00811fa0 00000002 00000000 00000000 00000018 ................
│ │ │ -  0x00811fb0 00010000 00010000 00000000 0171666d .............qfm
│ │ │ -  0x00811fc0 dfb80000 00220001 00000001 0000280f ....."........(.
│ │ │ -  0x00811fd0 00000171 666ddfb8 00000000 00000000 ...qfm..........
│ │ │ +  0x00811fb0 00010000 00010000 00000000 0171666c .............qfl
│ │ │ +  0x00811fc0 71bb0000 00220001 00000001 0000280f q...."........(.
│ │ │ +  0x00811fd0 00000171 666c71bb 00000000 00000000 ...qflq.........
│ │ │ +  0x00811fb0 00010000 00010000 00000000 0171666c .............qfl
│ │ │ +  0x00811fc0 71bb0000 00220001 00000001 0000280f q...."........(.
│ │ │ +  0x00811fd0 00000171 666c71bb 00000000 00000000 ...qflq.........
│ │ │    0x00811fe0 000904eb 98c3006c 0061006e 00670075 .......l.a.n.g.u
│ │ │    0x00811ff0 00610067 00650073 00020000 06be0065 .a.g.e.s.......e
│ │ │    0x00812000 006e0002 000006d2 00660072 00000000 .n.......f.r....
│ │ │    0x00812010 00000000 00000000 00000000 00000000 ................
│ │ │    0x00812020 0000280b 00008688 789ce57d 0b741cc5 ..(.....x..}.t..
│ │ │    0x00812030 9568c992 a5d16834 92654996 8531c236 .h....h4.eI..1.6
│ │ │    0x00812040 c626c618 639b9f31 8cf58905 922ceb63 .&..c..1.....,.c

[Message part 2 (application/pgp-signature, inline)]

Message #296 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 14-add-linphoneqt-v7
Date: Sun, 12 Apr 2020 03:55:23 +0000

Hi Danny!

> if we add gcc 5 here, do we need to do something similar to
> https://lists.gnu.org/archive/html/guix-commits/2020-04/msg00774.html too or
> not?
> 
> Why is only gcc 5 working and not gcc 7?

The requirement for gcc 5 is related to Qt. It has something to do with C++ standard. The Qt package in qt.scm uses gcc 5 instead of gcc 7.

The reason for gcc 7 working for linphoneqt on core-updates, could also be due to updates in qt.

Regards,
RG.

Message #299 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Replace source URI with mirror.
Date: Tue, 14 Apr 2020 22:07:04 -0400

Hello Raghav!

"Raghav Gururajan" <raghavgururajan <at> disroot.org> writes:

> From a2a4099994e21087cca9149a70d18186bfba7411 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Wed, 8 Apr 2020 02:53:06 -0400
> Subject: [PATCH 2/2] gnu: linphone: Replace source URI with mirror.
>
> * gnu/packages/linphone.scm: Replace source URI with mirror.

To have a mirror makes sense when many locations provide the same
content.  Here there's only https://www.linphone.org/ so I don't think
adding a mirror for it is necessary.

Thank you,

Maxim

Message #302 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: Raghav Gururajan <raghavgururajan <at> disroot.org>, 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 14-add-linphoneqt-v7
Date: Tue, 14 Apr 2020 22:50:07 -0400

Hello Danny,

Danny Milosavljevic <dannym <at> scratchpost.org> writes:

> Hi Raghav,
>
> pushed to guix core-updates (with changes below) because, there, it works
> without weird special gcc versions.
>
> Commit is c0cce2055757c18619ef1826c54ed3d5b9ec7eb0.
>
> Moved all propagated-inputs to regular inputs--except qttools which I moved to
> native-inputs.
>
> Added qtgraphicaleffects to inputs.
>
> Switched to qt build system so the programs actually start up successfully.
>
> There is still the same reproducibility problems in bin/linphone and
> bin/linphone-tester:
>
> --- /gnu/store/7g8kdcwzvybx7a8w87pnbypy7x0rf9wg-linphoneqt-4.1.1
> +++ /gnu/store/7g8kdcwzvybx7a8w87pnbypy7x0rf9wg-linphoneqt-4.1.1-check
> ├── bin
> │ ├── linphone
> │ │ ├── /gnu/store/mx2bgrpxkbdjsmhlxp9a30hbzcilk4cn-binutils-2.32/bin/readelf --wide --decompress --hex-dump=.rodata {}
> │ │ │ @@ -190223,17 +190223,17 @@
> │ │ │    0x008080c0 02000a00 12000309 3b093c09 3d000109 ........;.<.=...
> │ │ │    0x008080d0 3e000100 02010c05 56000200 0c000300 >.......V.......
> │ │ │    0x008080e0 f3023706 03000100 03004c00 4d045700 ..7.......L.M.W.
> │ │ │    0x008080f0 00000000 00000000 00000000 00000000 ................
> │ │ │    0x00808100 00000000 00020000 00010000 00010000 ................
> │ │ │    0x00808110 00000000 00000000 00000002 00000002 ................
> │ │ │    0x00808120 00000002 00000000 00000000 00000018 ................
> │ │ │ -  0x00808130 00010000 00010000 00000000 0171666d .............qfm
> │ │ │ -  0x00808140 dfb80000 00220001 00000001 0000280f ....."........(.
> │ │ │ -  0x00808150 00000171 666ddfb8 00000000 00000000 ...qfm..........
> │ │ │ +  0x00808130 00010000 00010000 00000000 0171666c .............qfl
> │ │ │ +  0x00808140 71bb0000 00220001 00000001 0000280f q...."........(.
> │ │ │ +  0x00808150 00000171 666c71bb 00000000 00000000 ...qflq.........
> │ │ │    0x00808160 000904eb 98c3006c 0061006e 00670075 .......l.a.n.g.u
> │ │ │    0x00808170 00610067 00650073 00020000 06be0065 .a.g.e.s.......e
> │ │ │    0x00808180 006e0002 000006d2 00660072 00000000 .n.......f.r....
> │ │ │    0x00808190 00000000 00000000 00000000 00000000 ................
> │ │ │    0x008081a0 0000280b 00008688 789ce57d 0b741cc5 ..(.....x..}.t..
> │ │ │    0x008081b0 9568c992 a5d16834 92654996 8531c236 .h....h4.eI..1.6
> │ │ │    0x008081c0 c626c618 639b9f31 8cf58905 922ceb63 .&..c..1.....,.c
> │ ├── linphone-tester
> │ │ ├── /gnu/store/mx2bgrpxkbdjsmhlxp9a30hbzcilk4cn-binutils-2.32/bin/readelf --wide --decompress --hex-dump=.rodata {}
> │ │ │ @@ -190455,17 +190455,17 @@
> │ │ │    0x00811f40 02000a00 12000309 3b093c09 3d000109 ........;.<.=...
> │ │ │    0x00811f50 3e000100 02010c05 56000200 0c000300 >.......V.......
> │ │ │    0x00811f60 f3023706 03000100 03004c00 4d045700 ..7.......L.M.W.
> │ │ │    0x00811f70 00000000 00000000 00000000 00000000 ................
> │ │ │    0x00811f80 00000000 00020000 00010000 00010000 ................
> │ │ │    0x00811f90 00000000 00000000 00000002 00000002 ................
> │ │ │    0x00811fa0 00000002 00000000 00000000 00000018 ................
> │ │ │ -  0x00811fb0 00010000 00010000 00000000 0171666d .............qfm
> │ │ │ -  0x00811fc0 dfb80000 00220001 00000001 0000280f ....."........(.
> │ │ │ -  0x00811fd0 00000171 666ddfb8 00000000 00000000 ...qfm..........
> │ │ │ +  0x00811fb0 00010000 00010000 00000000 0171666c .............qfl
> │ │ │ +  0x00811fc0 71bb0000 00220001 00000001 0000280f q...."........(.
> │ │ │ +  0x00811fd0 00000171 666c71bb 00000000 00000000 ...qflq.........
> │ │ │ +  0x00811fb0 00010000 00010000 00000000 0171666c .............qfl
> │ │ │ +  0x00811fc0 71bb0000 00220001 00000001 0000280f q...."........(.
> │ │ │ +  0x00811fd0 00000171 666c71bb 00000000 00000000 ...qflq.........
> │ │ │    0x00811fe0 000904eb 98c3006c 0061006e 00670075 .......l.a.n.g.u
> │ │ │    0x00811ff0 00610067 00650073 00020000 06be0065 .a.g.e.s.......e
> │ │ │    0x00812000 006e0002 000006d2 00660072 00000000 .n.......f.r....
> │ │ │    0x00812010 00000000 00000000 00000000 00000000 ................
> │ │ │    0x00812020 0000280b 00008688 789ce57d 0b741cc5 ..(.....x..}.t..
> │ │ │    0x00812030 9568c992 a5d16834 92654996 8531c236 .h....h4.eI..1.6
> │ │ │    0x00812040 c626c618 639b9f31 8cf58905 922ceb63 .&..c..1.....,.c

In my case I'm seeing slightly different outputs:

diffoscope --exclude-command stat /gnu/store/i3pqi987rdm3x023ya4zd2k3jxhaiqqy-linphoneqt-4.1.1{,-check}
--- /gnu/store/i3pqi987rdm3x023ya4zd2k3jxhaiqqy-linphoneqt-4.1.1
+++ /gnu/store/i3pqi987rdm3x023ya4zd2k3jxhaiqqy-linphoneqt-4.1.1-check
├── bin
│ ├── .linphone-real
│ │ ├── /gnu/store/mx2bgrpxkbdjsmhlxp9a30hbzcilk4cn-binutils-2.32/bin/readelf --wide --decompress --hex-dump=.rodata {}
│ │ │ @@ -190223,17 +190223,17 @@
│ │ │    0x008080c0 02000a00 12000309 3b093c09 3d000109 ........;.<.=...
│ │ │    0x008080d0 3e000100 02010c05 56000200 0c000300 >.......V.......
│ │ │    0x008080e0 f3023706 03000100 03004c00 4d045700 ..7.......L.M.W.
│ │ │    0x008080f0 00000000 00000000 00000000 00000000 ................
│ │ │    0x00808100 00000000 00020000 00010000 00010000 ................
│ │ │    0x00808110 00000000 00000000 00000002 00000002 ................
│ │ │    0x00808120 00000002 00000000 00000000 00000018 ................
│ │ │ -  0x00808130 00010000 00010000 00000000 01717ba8 .............q{.
│ │ │ -  0x00808140 1fbe0000 00220001 00000001 0000280f ....."........(.
│ │ │ -  0x00808150 00000171 7ba81fba 00000000 00000000 ...q{...........
│ │ │ +  0x00808130 00010000 00010000 00000000 01717ba6 .............q{.
│ │ │ +  0x00808140 59760000 00220001 00000001 0000280f Yv..."........(.
│ │ │ +  0x00808150 00000171 7ba65972 00000000 00000000 ...q{.Yr........
│ │ │    0x00808160 000904eb 98c3006c 0061006e 00670075 .......l.a.n.g.u
│ │ │    0x00808170 00610067 00650073 00020000 06be0065 .a.g.e.s.......e
│ │ │    0x00808180 006e0002 000006d2 00660072 00000000 .n.......f.r....
│ │ │    0x00808190 00000000 00000000 00000000 00000000 ................
│ │ │    0x008081a0 0000280b 00008688 789ce57d 0b741cc5 ..(.....x..}.t..
│ │ │    0x008081b0 9568c992 a5d16834 92654996 8531c236 .h....h4.eI..1.6
│ │ │    0x008081c0 c626c618 639b9f31 8cf58905 922ceb63 .&..c..1.....,.c
│ ├── .linphone-tester-real
│ │ ├── /gnu/store/mx2bgrpxkbdjsmhlxp9a30hbzcilk4cn-binutils-2.32/bin/readelf --wide --decompress --hex-dump=.rodata {}
│ │ │ @@ -190455,17 +190455,17 @@
│ │ │    0x00811f40 02000a00 12000309 3b093c09 3d000109 ........;.<.=...
│ │ │    0x00811f50 3e000100 02010c05 56000200 0c000300 >.......V.......
│ │ │    0x00811f60 f3023706 03000100 03004c00 4d045700 ..7.......L.M.W.
│ │ │    0x00811f70 00000000 00000000 00000000 00000000 ................
│ │ │    0x00811f80 00000000 00020000 00010000 00010000 ................
│ │ │    0x00811f90 00000000 00000000 00000002 00000002 ................
│ │ │    0x00811fa0 00000002 00000000 00000000 00000018 ................
│ │ │ -  0x00811fb0 00010000 00010000 00000000 01717ba8 .............q{.
│ │ │ -  0x00811fc0 1fbe0000 00220001 00000001 0000280f ....."........(.
│ │ │ -  0x00811fd0 00000171 7ba81fba 00000000 00000000 ...q{...........
│ │ │ +  0x00811fb0 00010000 00010000 00000000 01717ba6 .............q{.
│ │ │ +  0x00811fc0 59760000 00220001 00000001 0000280f Yv..."........(.
│ │ │ +  0x00811fd0 00000171 7ba65972 00000000 00000000 ...q{.Yr........
│ │ │    0x00811fe0 000904eb 98c3006c 0061006e 00670075 .......l.a.n.g.u
│ │ │    0x00811ff0 00610067 00650073 00020000 06be0065 .a.g.e.s.......e
│ │ │    0x00812000 006e0002 000006d2 00660072 00000000 .n.......f.r....
│ │ │    0x00812010 00000000 00000000 00000000 00000000 ................
│ │ │    0x00812020 0000280b 00008688 789ce57d 0b741cc5 ..(.....x..}.t..
│ │ │    0x00812030 9568c992 a5d16834 92654996 8531c236 .h....h4.eI..1.6
│ │ │    0x00812040 c626c618 639b9f31 8cf58905 922ceb63 .&..c..1.....,.c

Adding more data points so that hopefully we can find out the cause of
the non-reproducibility issue.

Maxim

Message #305 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: Raghav Gururajan <raghavgururajan <at> disroot.org>, 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 14-add-linphoneqt-v7
Date: Wed, 15 Apr 2020 00:36:09 -0400

Hello again,

I've isolated the culprit: it's the translation auto-generated files
qrc_i18n.cpp.  I've run a couple builds locally, then diffed the build
files, and found this suspicious:

diff -I build2 -I build3 -r build2/qrc_i18n.cpp build3/qrc_i18n.cpp
1352c1352
< 0x0,0x0,0x1,0x71,0x7b,0xea,0x68,0x8a,
---
> 0x0,0x0,0x1,0x71,0x7b,0xec,0x98,0x61,
1355c1355
< 0x0,0x0,0x1,0x71,0x7b,0xea,0x68,0x86,
---
> 0x0,0x0,0x1,0x71,0x7b,0xec,0x98,0x61,

I then compared the object files for this source, e.g.: diffoscope
--exclude-command stat
build{2,3}/CMakeFiles/app-library.dir/qrc_i18n.cpp.o

  Hex dump of section '.rodata':
│    0x00000000 00000000 00020000 00010000 00010000 ................
│    0x00000010 00000000 00000000 00000002 00000002 ................
│    0x00000020 00000002 00000000 00000000 00000018 ................
│ -  0x00000030 00010000 00010000 00000000 01717bea .............q{.
│ -  0x00000040 688a0000 00220001 00000001 0000280f h...."........(.
│ -  0x00000050 00000171 7bea6886 00000000 00000000 ...q{.h.........
│ +  0x00000030 00010000 00010000 00000000 01717bec .............q{.
│ +  0x00000040 98610000 00220001 00000001 0000280f .a..."........(.
│ +  0x00000050 00000171 7bec9861 00000000 00000000 ...q{..a........
│    0x00000060 000904eb 98c3006c 0061006e 00670075 .......l.a.n.g.u
│    0x00000070 00610067 00650073 00020000 06be0065 .a.g.e.s.......e
│    0x00000080 006e0002 000006d2 00660072 00000000 .n.......f.r....
│    0x00000090 00000000 00000000 00000000 00000000 ................
│    0x000000a0 0000280b 00008688 789ce57d 0b741cc5 ..(.....x..}.t..
│    0x000000b0 9568c992 a5d16834 92654996 8531c236 .h....h4.eI..1.6
│    0x000000c0 c626c618 639b9f31 8cf58905 922ceb63 .&..c..1.....,.c

This matches the .rodata diff found in the main binary :-).

Maxim

Message #308 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: Raghav Gururajan <raghavgururajan <at> disroot.org>, 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 14-add-linphoneqt-v7
Date: Wed, 15 Apr 2020 02:13:29 -0400

Hi!

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Hello again,
>
> I've isolated the culprit: it's the translation auto-generated files
> qrc_i18n.cpp.  I've run a couple builds locally, then diffed the build
> files, and found this suspicious:
>
> diff -I build2 -I build3 -r build2/qrc_i18n.cpp build3/qrc_i18n.cpp
> 1352c1352
> < 0x0,0x0,0x1,0x71,0x7b,0xea,0x68,0x8a,
> ---
>> 0x0,0x0,0x1,0x71,0x7b,0xec,0x98,0x61,
> 1355c1355
> < 0x0,0x0,0x1,0x71,0x7b,0xea,0x68,0x86,
> ---
>> 0x0,0x0,0x1,0x71,0x7b,0xec,0x98,0x61,
>
> I then compared the object files for this source, e.g.: diffoscope
> --exclude-command stat
> build{2,3}/CMakeFiles/app-library.dir/qrc_i18n.cpp.o
>
>   Hex dump of section '.rodata':
> │    0x00000000 00000000 00020000 00010000 00010000 ................
> │    0x00000010 00000000 00000000 00000002 00000002 ................
> │    0x00000020 00000002 00000000 00000000 00000018 ................
> │ -  0x00000030 00010000 00010000 00000000 01717bea .............q{.
> │ -  0x00000040 688a0000 00220001 00000001 0000280f h...."........(.
> │ -  0x00000050 00000171 7bea6886 00000000 00000000 ...q{.h.........
> │ +  0x00000030 00010000 00010000 00000000 01717bec .............q{.
> │ +  0x00000040 98610000 00220001 00000001 0000280f .a..."........(.
> │ +  0x00000050 00000171 7bec9861 00000000 00000000 ...q{..a........
> │    0x00000060 000904eb 98c3006c 0061006e 00670075 .......l.a.n.g.u
> │    0x00000070 00610067 00650073 00020000 06be0065 .a.g.e.s.......e
> │    0x00000080 006e0002 000006d2 00660072 00000000 .n.......f.r....
> │    0x00000090 00000000 00000000 00000000 00000000 ................
> │    0x000000a0 0000280b 00008688 789ce57d 0b741cc5 ..(.....x..}.t..
> │    0x000000b0 9568c992 a5d16834 92654996 8531c236 .h....h4.eI..1.6
> │    0x000000c0 c626c618 639b9f31 8cf58905 922ceb63 .&..c..1.....,.c
>
> This matches the .rodata diff found in the main binary :-).
>
> Maxim

Fixed in commit a4f1a7e2db, on core-updates :-)

Maxim

Message #313 received at 40264-done <at> debbugs.gnu.org (full text, mbox):

From: maxim.cournoyer <at> gmail.com
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40264-done <at> debbugs.gnu.org
Subject: Re: [bug#40264] Mirror and Formatting
Date: Thu, 16 Apr 2020 00:49:08 -0400

Hello Raghav,

"Raghav Gururajan" <raghavgururajan <at> disroot.org> writes:

> From 5b3dc89e93749fb4ff1e2d246db20e61a54e6232 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Wed, 8 Apr 2020 03:28:07 -0400
> Subject: [PATCH 3/3] gnu: linphone: Fix formatting.
>
> * gnu/packages/linphone.scm: Fix formatting.
> ---
>  gnu/packages/linphone.scm | 84 ++++++++++++++++++++-------------------
>  1 file changed, 44 insertions(+), 40 deletions(-)
>
> diff --git a/gnu/packages/linphone.scm b/gnu/packages/linphone.scm
> index 39109ff877..0e3281de4b 100644
> --- a/gnu/packages/linphone.scm
> +++ b/gnu/packages/linphone.scm
> @@ -70,9 +70,9 @@
>         (list
>          "-DENABLE_STATIC=NO")))         ; Not required
>      (synopsis "Belledonne Communications Unit Testing Framework")
> -    (description "BCUnit is a fork of the defunct project CUnit,
> -with several fixes and patches applied.  It is an unit testing
> -framework for writing, administering, and running unit tests in C.")
> +    (description "BCUnit is a fork of the defunct project CUnit, with several
> +fixes and patches applied.  It is an unit testing framework for writing,
> +administering, and running unit tests in C.")
>      (home-page "https://gitlab.linphone.org/BC/public/bcunit")
>      (license license:lgpl2.0+)))
>  
> @@ -124,9 +124,10 @@ Communications softwares like belle-sip, mediastreamer2 and linphone.")
>      (inputs
>       `(("bctoolbox" ,bctoolbox)))
>      (synopsis "Belledonne Communications Language Recognition Library")
> -    (description "Belr is Belledonne Communications' language recognition library,
> -written in C++11.  It parses text inputs formatted according to a language
> -defined by an ABNF grammar, such as the protocols standardized at IETF.")
> +    (description "Belr is Belledonne Communications' language recognition
> +library, written in C++11.  It parses text inputs formatted according to a
> +language defined by an ABNF grammar, such as the protocols standardized at
> +IETF.")
>      (home-page "https://gitlab.linphone.org/BC/public/belr")
>      (license license:gpl3+)))
>  
> @@ -152,7 +153,8 @@ defined by an ABNF grammar, such as the protocols standardized at IETF.")
>       `(("bctoolbox" ,bctoolbox)
>         ("belr" ,belr)))
>      (synopsis "Belledonne Communications VCard Library")
> -    (description "Belcard is a C++ library to manipulate VCard standard format.")
> +    (description "Belcard is a C++ library to manipulate VCard standard
> +format.")
>      (home-page "https://gitlab.linphone.org/BC/public/belcard")
>      (license license:gpl3+)))
>  
> @@ -175,16 +177,16 @@ defined by an ABNF grammar, such as the protocols standardized at IETF.")
>         (list
>          "-DENABLE_STATIC=NO")))         ; Not required
>      (synopsis "Belledonne Communications Media Container")
> -    (description "BcMatroska is a free and open standard multi-media
> -container format.  It can hold an unlimited number of video, audio,
> -picture, or subtitle tracks in one file. ")
> +    (description "BcMatroska is a free and open standard multi-media container
> +format.  It can hold an unlimited number of video, audio, picture, or subtitle
> +tracks in one file. ")
>      (home-page "https://gitlab.linphone.org/BC/public/bcmatroska2")
>      (license
>       (list
> -      ;; That license applies for Core C and LibEBML2.
> +      ;; For Core C and LibEBML2.
>        ;; https://www.matroska.org/node/47
>        license:bsd-4
> -      ;; That license applies for LibMatroska2.
> +      ;; For LibMatroska2.
>        ;; https://www.matroska.org/node/47
>        license:lgpl2.1+))))
>  
> @@ -261,15 +263,15 @@ implements the RFC 3550 standard.")
>       `(#:tests? #f                      ; No test target
>         #:configure-flags
>         (list
> -        "-DENABLE_STATIC=NO")))
> +        "-DENABLE_STATIC=NO")))         ; Not required
>      (inputs
>       `(("bctoolbox" ,bctoolbox)
>         ("sqlite3" ,sqlite)
>         ("xml2" ,libxml2)))
>      (synopsis "Belledonne Communications ZRTP Library")
> -    (description "BZRTP is an implementation of ZRTP keys exchange
> -protocol, written in C.  It is fully portable and can be executed on many
> -platforms including both ARM and x86.")
> +    (description "BZRTP is an implementation of ZRTP keys exchange protocol,
> +written in C.  It is fully portable and can be executed on many platforms
> +including both ARM and x86.")
>      (home-page "https://gitlab.linphone.org/BC/public/bzrtp")
>      (license license:gpl2+)))
>  
> @@ -290,15 +292,15 @@ platforms including both ARM and x86.")
>       `(#:tests? #f                      ; Requires network access
>         #:configure-flags
>         (list
> -        "-DENABLE_STATIC=NO")
> +        "-DENABLE_STATIC=NO")           ; Not required
>         #:phases
>         (modify-phases %standard-phases
>           (add-after 'unpack 'patch
>             (lambda _
>               (substitute* "src/CMakeLists.txt"
> -              ;; ANTLR would use multithreaded DFA generation
> -              ;; otherwise--which would not be reproducible.
> -              (("-Xmultithreaded ") ""))
> +               ;; ANTLR would use multithreaded DFA generation otherwise,
> +               ;; which would not be reproducible.
> +               (("-Xmultithreaded ") ""))
>               #t)))))
>      (inputs
>       `(("antlr3" ,antlr3-3.3)
> @@ -325,7 +327,8 @@ API.  It also comprises a simple HTTP/HTTPS client implementation.")
>                         "/" name "-" version ".tar.gz"))
>         (sha256
>          (base32 "0whpqr69wz0pnzvragkpfblxhd0rds8k06c3mw5a0ag216a1yd9k"))
> -       (patches (search-patches "mediastreamer2-srtp2.patch"))))
> +       (patches
> +        (search-patches "mediastreamer2-srtp2.patch"))))
>      (outputs '("out" "doc" "tester"))
>      (build-system cmake-build-system)
>      (arguments
> @@ -393,13 +396,12 @@ API.  It also comprises a simple HTTP/HTTPS client implementation.")
>         ("vpx" ,libvpx)
>         ("x11" ,libx11)
>         ("xv" ,libxv)
> -       ("zrtp", bzrtp)))
> +       ("zrtp" ,bzrtp)))
>      (synopsis "Belledonne Communications Streaming Engine")
> -    (description "Mediastreamer2 is a powerful and lightweight
> -streaming engine for telephony applications.  This media processing
> -and streaming toolkit is responsible for receiving and sending all
> -multimedia streams in Linphone, including media capture, encoding and
> -decoding, and rendering.")
> +    (description "Mediastreamer2 is a powerful and lightweight streaming engine
> +for telephony applications.  This media processing and streaming toolkit is
> +responsible for receiving and sending all multimedia streams in Linphone,
> +including media capture, encoding and decoding, and rendering.")
>      (home-page "https://gitlab.linphone.org/BC/public/mediastreamer2")
>      (license license:gpl2+)))
>  
> @@ -461,11 +463,11 @@ decoding, and rendering.")
>      (propagated-inputs
>       `(("murrine" ,murrine)))           ; Required for GTK UI
>      (synopsis "Belledonne Communications Softphone Library")
> -    (description "Liblinphone is a high-level SIP library integrating
> -all calling and instant messaging features into an unified
> -easy-to-use API.  It is the cross-platform VoIP library on which the
> -Linphone application is based on, and that anyone can use to add audio
> -and video calls or instant messaging capabilities to an application.")
> +    (description "Liblinphone is a high-level SIP library integrating all
> +calling and instant messaging features into an unified easy-to-use API.  It is
> +the cross-platform VoIP library on which the Linphone application is based on,
> +and that anyone can use to add audio and video calls or instant messaging
> +capabilities to an application.")
>      (home-page "https://gitlab.linphone.org/BC/public/liblinphone")
>      (license license:gpl2+)))
>  
> @@ -487,11 +489,13 @@ and video calls or instant messaging capabilities to an application.")
>           (origin
>             (method url-fetch)
>             (uri
> -            (string-append "https://gitlab.linphone.org/BC/public/msopenh264/commit/"
> -                           "493d147d28c9a0f788ba4e50b47a1ce7b18bf326.diff"))
> +            (string-append "https://gitlab.linphone.org/BC/public/msopenh264/"
> +                           "commit/493d147d28c9a0f788ba4e50b47a1ce7b18bf326"
> +                           ".diff"))
>             (file-name "msopenh264-openh264.patch")
>             (sha256
> -            (base32 "0mmd7nz5n9ian4rcwn200nldmy5j0dpdrna7r32rqnaw82bx3kdb")))))))
> +            (base32
> +             "0mmd7nz5n9ian4rcwn200nldmy5j0dpdrna7r32rqnaw82bx3kdb")))))))
>      (build-system cmake-build-system)
>      (arguments
>       `(#:tests? #f                      ; No test target
> @@ -530,8 +534,8 @@ mediastreamer2 based on the openh264 library.")
>       `(("mediastreamer2" ,mediastreamer2)
>         ("ortp" ,ortp)))
>      (synopsis "Media Streamer SILK Codec")
> -    (description "MSSILK is a plugin of MediaStreamer, adding support for
> -AMR codec.  It is based on the Skype's SILK implementation.")
> +    (description "MSSILK is a plugin of MediaStreamer, adding support for AMR
> +codec.  It is based on the Skype's SILK implementation.")
>      (home-page "https://gitlab.linphone.org/BC/public/mssilk")
>      (license license:gpl2+)))
>  
> @@ -552,7 +556,7 @@ AMR codec.  It is based on the Skype's SILK implementation.")
>       `(#:tests? #f                      ; No test target
>         #:configure-flags
>         (list
> -        "-DENABLE_STATIC=NO")))
> +        "-DENABLE_STATIC=NO")))         ; Not required
>      (inputs
>       `(("bctoolbox" ,bctoolbox)
>         ("mediastreamer2" ,mediastreamer2)
> @@ -588,7 +592,7 @@ WebRTC codec.  It includes features from WebRTC, such as, iSAC and AECM.")
>         ("ortp" ,ortp)
>         ("voamrwbenc" ,vo-amrwbenc)))
>      (synopsis "Media Streamer AMR Codec")
> -    (description "MSAMR is a plugin of MediaStreamer, adding support for
> -AMR codec.  It is based on the opencore-amr implementation.")
> +    (description "MSAMR is a plugin of MediaStreamer, adding support for AMR
> +codec.  It is based on the opencore-amr implementation.")
>      (home-page "https://gitlab.linphone.org/BC/public/msamr")
>      (license license:gpl3+)))

Please not that we usually submit changes *per-package*, that is, one
commit per package.  It's a convention we use.  I'm making an exception
here because the changes are cosmetic only, but keep this in mind for
your next changes.

I've pushed a slightly modified version of the above changes in commit
1988ef21f82430d4b380dd4887160a902d8796fd (on the core-updates branch).

Thank you for your contributions and your patience in the lengthy review
process.

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.