GNU bug report logs - #40264
Linphone

Previous Next

Full log

Message #204 received at 40264 <at> debbugs.gnu.org (full text, mbox):

From: maxim.cournoyer <at> gmail.com
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 40264 <at> debbugs.gnu.org
Subject: Re: [bug#40264] Linphone: 11-add-mediastreamer-v2
Date: Sun, 05 Apr 2020 00:08:08 -0400

Hello Raghav,

"Raghav Gururajan" <raghavgururajan <at> disroot.org> writes:

> Hi Danny!
>
>>> + (list
>>>
>>> + ;; For fixing definitions.
>>
>> Yes, but why? What would happen if we didn't do it?
>
> Otherwise, we get `-Werror` flag related compilation errors.

Could you please clarify that in a comment above the patch?

>>> + (origin
>>> + (method url-fetch)
>>> + (uri
>>> + (string-append "https://gitlab.linphone.org/BC/public/mediastreamer2/commit"
>>> + "de3a24b795d7a78e78eab6b974e7ec5abf2259ac.diff"))
>>> + (file-name "mediastreamer-msfactory.patch")
>>
>> I'm not sure what the outcome of the latest discussion on carrying patches was.
>> Should we carry patches in Guix now or fetch them from external source?
>
> I think it's good as long as we use hash to verify. :-)

The problem is that metadata or format of auto-generated patches may
change on a whim.  In past discussions it was decided best to not use
them (that is, it's best to embed a copy of it in Guix sources) [0].

[0]  https://lists.gnu.org/archive/html/guix-devel/2018-11/msg00554.html

I'll post more comments in your original message.

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.