GNU bug report logs - #40259
[PATCH] gnu: Add emacs-evil-tmux-navigator.

Previous Next

Full log

Message #13 received at 40259-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 40259-done <at> debbugs.gnu.org
Subject: Re: [bug#40259] [PATCH] gnu: Add emacs-evil-tmux-navigator
Date: Wed, 01 Apr 2020 09:11:48 +0100

[Message part 1 (text/plain, inline)]

John Soo <jsoo1 <at> asu.edu> writes:

> Hi Guix,
>
> I realized my last patch was based on previous work.
>
> I cherry-picked this one onto master.

Hi John,

Thanks for the patch. I've now pushed this as
1d5c93d9f8a13588695490db6516b40f54e91fa2.

I made a few changes, I move the package up from the bottom of the
file. I'd always recommend not adding new packages at the bottom of the
module files, as if everyone does this, it becomes harder to apply
patches because there are more conflicts. In this case, I think this
patch ended up conflicting with your addition of emacs-haskell-snippets,
also to the bottom of the emacs-xyz.scm file.

I also tweaked emacs-evil to be a propagated input, just because that
looked to be what the existing emacs-evil-... packages do, and I tweaked
the description to start with "This package lets you " so it reads as a
complete sentance.

Thanks again,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.