GNU bug report logs - #40258
[PATCH] gnu: Add emacs-flycheck-elm.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40258 in the body.
You can then email your comments to 40258 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-flycheck-elm.
Date: Fri, 27 Mar 2020 14:42:46 -0700

[Message part 1 (text/plain, inline)]

Hi Guix,

flycheck-elm provides flycheck support for Elm.

Thanks,

John

[0001-gnu-Add-emacs-flycheck-elm.patch (text/x-patch, attachment)]

Message #8 received at 40258 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: 40258 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add emacs-flycheck-elm.
Date: Sat, 28 Mar 2020 13:35:03 -0700

[Message part 1 (text/plain, inline)]

Hi Guix,

I forgot my patch was applied on some other work.

This cherry-picks it on to master.

Thanks,

John

[0001-gnu-Add-emacs-flycheck-elm.patch (text/x-patch, attachment)]

Message #11 received at 40258 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 40258 <at> debbugs.gnu.org
Subject: Re: [bug#40258] [PATCH] gnu: Add emacs-flycheck-elm.
Date: Mon, 30 Mar 2020 15:10:06 +0200

Hello,

John Soo <jsoo1 <at> asu.edu> writes:

> Subject: [PATCH] gnu: Add emacs-flycheck-elm.
>
> * gnu/packages/emacs-xyz.scm (emacs-flycheck-elm): New variable.

Thank you.

> +;;; Copyright © 2020 John Soo <jsoo1 <at> asu.edu>

You can remove this line, already applied in a previous patch.


> +(define-public emacs-flycheck-elm
> +  (package
> +    (name "emacs-flycheck-elm")
> +    (version "debd0af")

This is not a proper version string (not monotonic). You should bind
`commit' to "debd0af563cb6c2944367a691c7fa3021d9378c1" and `revision' to
"O" at the top of your package definition, and use

  (version (git-version "0" revision commit))

> +         (commit version)))

In the case above, this should be:

  (commit commit)

> +    (inputs
> +     `(("emacs-flycheck" ,emacs-flycheck)
> +       ("emacs-let-alist" ,emacs-let-alist)
> +       ("emacs-seq" ,emacs-seq)))

I don't think you need "emacs-seq" since we build packages with Emacs
26.3, which includes "seq.el" already.

> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/bsermons/flycheck-elm")
> +    (synopsis "Flycheck support for the elm language")
> +    (description "Flycheck support for the elm language.")

Nitpick: I would use Elm.

The description needs to be a full sentence.

> +    (license license:gpl2+)))

All source code files are GPL3+, so this probably makes the project
GPL3+ licensed. LICENSE file is GPL2 (not 2+), but I would trust source
code in this case.

You may want to tell upstream about this discrepancy.

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou

Message #14 received at 40258 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 40258 <at> debbugs.gnu.org
Subject: Re: [bug#40258] [PATCH] gnu: Add emacs-flycheck-elm.
Date: Mon, 30 Mar 2020 11:28:05 -0700

[Message part 1 (text/plain, inline)]

Hi Nicolas,

Thanks again!

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

>> +;;; Copyright © 2020 John Soo <jsoo1 <at> asu.edu>
>
> You can remove this line, already applied in a previous patch.

I rebased on master so that should not be in this patch.


>> +(define-public emacs-flycheck-elm
>> +  (package
>> +    (name "emacs-flycheck-elm")
>> +    (version "debd0af")
>
> This is not a proper version string (not monotonic). You should bind
> `commit' to "debd0af563cb6c2944367a691c7fa3021d9378c1" and `revision' to
> "O" at the top of your package definition, and use
>
>   (version (git-version "0" revision commit))
>
>> +         (commit version)))
>
> In the case above, this should be:
>
>   (commit commit)

Done, thank you! I was confused what version to use there.

>> +    (inputs
>> +     `(("emacs-flycheck" ,emacs-flycheck)
>> +       ("emacs-let-alist" ,emacs-let-alist)
>> +       ("emacs-seq" ,emacs-seq)))
>
> I don't think you need "emacs-seq" since we build packages with Emacs
> 26.3, which includes "seq.el" already.

It builds just fine without seq, so I removed it.

>> +    (build-system emacs-build-system)
>> +    (home-page "https://github.com/bsermons/flycheck-elm")
>> +    (synopsis "Flycheck support for the elm language")
>> +    (description "Flycheck support for the elm language.")
>
> Nitpick: I would use Elm.

Done.

> The description needs to be a full sentence.

Done. Though there really is not much there. It might need revision.

>> +    (license license:gpl2+)))
>
> All source code files are GPL3+, so this probably makes the project
> GPL3+ licensed. LICENSE file is GPL2 (not 2+), but I would trust source
> code in this case.
>
> You may want to tell upstream about this discrepancy.

I reported the issue and put a comment over the license field.

> Could you send an updated patch?

Updated patch attached.

Thanks so much,

John

[0001-gnu-Add-emacs-flycheck-elm.patch (text/x-patch, attachment)]

Message #17 received at 40258 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 40258 <at> debbugs.gnu.org
Subject: Re: [bug#40258] [PATCH] gnu: Add emacs-flycheck-elm.
Date: Mon, 30 Mar 2020 14:41:04 -0700

[Message part 1 (text/plain, inline)]

Hi Nicolas,

They fixed the license upstream already. Here I rebased on master and
changed inputs -> propagated inputs. Also I updated the commit to the
one with the correct license.

Thanks again,

John

[0001-gnu-Add-emacs-flycheck-elm.patch (text/x-patch, attachment)]

Message #22 received at 40258-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 40258-done <at> debbugs.gnu.org
Subject: Re: [bug#40258] [PATCH] gnu: Add emacs-flycheck-elm.
Date: Tue, 31 Mar 2020 00:31:07 +0200

John Soo <jsoo1 <at> asu.edu> writes:

> They fixed the license upstream already. Here I rebased on master and
> changed inputs -> propagated inputs. Also I updated the commit to the
> one with the correct license.

Applied as 2330ef9427599315644bd316bb8169bd9f3d1664. I also moved
`build-system' part up in the package definition.

Thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.