GNU bug report logs - #40259
[PATCH] gnu: Add emacs-evil-tmux-navigator.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#40259: closed ([PATCH] gnu: Add emacs-evil-tmux-navigator.)
Date: Wed, 01 Apr 2020 08:12:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 01 Apr 2020 09:11:48 +0100
with message-id <87blobaam3.fsf <at> cbaines.net>
and subject line Re: [bug#40259] [PATCH] gnu: Add emacs-evil-tmux-navigator
has caused the debbugs.gnu.org bug report #40259,
regarding [PATCH] gnu: Add emacs-evil-tmux-navigator.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
40259: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40259
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: John Soo <jsoo1 <at> asu.edu>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-evil-tmux-navigator.
Date: Fri, 27 Mar 2020 14:46:13 -0700

[Message part 3 (text/plain, inline)]

Hi Guix,

evil-tmux-navigator provides seeemless switching between tmux and emacs
panes with nice evil keybindings. It hasn't seen a commit in a long time
but I think that is because it seems to be very stable.

Thanks,

John

[0001-gnu-Add-emacs-evil-tmux-navigator.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 40259-done <at> debbugs.gnu.org
Subject: Re: [bug#40259] [PATCH] gnu: Add emacs-evil-tmux-navigator
Date: Wed, 01 Apr 2020 09:11:48 +0100

[Message part 6 (text/plain, inline)]

John Soo <jsoo1 <at> asu.edu> writes:

> Hi Guix,
>
> I realized my last patch was based on previous work.
>
> I cherry-picked this one onto master.

Hi John,

Thanks for the patch. I've now pushed this as
1d5c93d9f8a13588695490db6516b40f54e91fa2.

I made a few changes, I move the package up from the bottom of the
file. I'd always recommend not adding new packages at the bottom of the
module files, as if everyone does this, it becomes harder to apply
patches because there are more conflicts. In this case, I think this
patch ended up conflicting with your addition of emacs-haskell-snippets,
also to the bottom of the emacs-xyz.scm file.

I also tweaked emacs-evil to be a propagated input, just because that
looked to be what the existing emacs-evil-... packages do, and I tweaked
the description to start with "This package lets you " so it reads as a
complete sentance.

Thanks again,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.