GNU bug report logs - #40258
[PATCH] gnu: Add emacs-flycheck-elm.

Previous Next

Full log

View this message in rfc822 format

From: John Soo <jsoo1 <at> asu.edu>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 40258 <at> debbugs.gnu.org
Subject: [bug#40258] [PATCH] gnu: Add emacs-flycheck-elm.
Date: Mon, 30 Mar 2020 11:28:05 -0700

[Message part 1 (text/plain, inline)]

Hi Nicolas,

Thanks again!

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

>> +;;; Copyright © 2020 John Soo <jsoo1 <at> asu.edu>
>
> You can remove this line, already applied in a previous patch.

I rebased on master so that should not be in this patch.


>> +(define-public emacs-flycheck-elm
>> +  (package
>> +    (name "emacs-flycheck-elm")
>> +    (version "debd0af")
>
> This is not a proper version string (not monotonic). You should bind
> `commit' to "debd0af563cb6c2944367a691c7fa3021d9378c1" and `revision' to
> "O" at the top of your package definition, and use
>
>   (version (git-version "0" revision commit))
>
>> +         (commit version)))
>
> In the case above, this should be:
>
>   (commit commit)

Done, thank you! I was confused what version to use there.

>> +    (inputs
>> +     `(("emacs-flycheck" ,emacs-flycheck)
>> +       ("emacs-let-alist" ,emacs-let-alist)
>> +       ("emacs-seq" ,emacs-seq)))
>
> I don't think you need "emacs-seq" since we build packages with Emacs
> 26.3, which includes "seq.el" already.

It builds just fine without seq, so I removed it.

>> +    (build-system emacs-build-system)
>> +    (home-page "https://github.com/bsermons/flycheck-elm")
>> +    (synopsis "Flycheck support for the elm language")
>> +    (description "Flycheck support for the elm language.")
>
> Nitpick: I would use Elm.

Done.

> The description needs to be a full sentence.

Done. Though there really is not much there. It might need revision.

>> +    (license license:gpl2+)))
>
> All source code files are GPL3+, so this probably makes the project
> GPL3+ licensed. LICENSE file is GPL2 (not 2+), but I would trust source
> code in this case.
>
> You may want to tell upstream about this discrepancy.

I reported the issue and put a comment over the license field.

> Could you send an updated patch?

Updated patch attached.

Thanks so much,

John

[0001-gnu-Add-emacs-flycheck-elm.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.