GNU bug report logs - #3971
23.1.50; linum-mode kills right margin

Previous Next

Full log

Message #10 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: emacs-pretest-bug <at> gnu.org
Subject: Re: bug#3971: 23.1.50; linum-mode kills right margin
Date: Thu, 30 Jul 2009 07:24:27 +0200

Or, maybe it is better to redefine set-window-margins so that a nil
argument for a margin means "don't touch"...?


On Thu, Jul 30, 2009 at 6:38 AM, Lennart
Borgman<lennart.borgman <at> gmail.com> wrote:
> linum-mode kills the right margin. It should not touch it since it
> does not use it. The following patch fixes this:
>
> Index: linum.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/linum.el,v
> retrieving revision 1.11
> diff -c -b -r1.11 linum.el
> *** linum.el    18 Jan 2009 01:45:38 -0000      1.11
> --- linum.el    30 Jul 2009 04:35:10 -0000
> ***************
> *** 108,114 ****
>    (mapc #'delete-overlay linum-overlays)
>    (setq linum-overlays nil)
>    (dolist (w (get-buffer-window-list (current-buffer) nil t))
> !     (set-window-margins w 0)))
>
>  (defun linum-update-current ()
>    "Update line numbers for the current buffer."
> --- 108,114 ----
>    (mapc #'delete-overlay linum-overlays)
>    (setq linum-overlays nil)
>    (dolist (w (get-buffer-window-list (current-buffer) nil t))
> !     (set-window-margins w 0 (cdr (window-margins w)))))
>
>  (defun linum-update-current ()
>    "Update line numbers for the current buffer."
> ***************
> *** 163,169 ****
>              (overlay-put ov 'linum-str str))))
>        (forward-line)
>        (setq line (1+ line)))
> !     (set-window-margins win width)))
>
>  (defun linum-after-change (beg end len)
>    ;; update overlays on deletions, and after newlines are inserted
> --- 163,169 ----
>              (overlay-put ov 'linum-str str))))
>        (forward-line)
>        (setq line (1+ line)))
> !     (set-window-margins win width (cdr (window-margins win)))))
>
>  (defun linum-after-change (beg end len)
>    ;; update overlays on deletions, and after newlines are inserted
>
>
>
> In GNU Emacs 23.1.50.1 (i386-mingw-nt5.1.2600)
>  of 2009-06-30
> Windowing system distributor `Microsoft Corp.', version 5.1.2600
> configured using `configure --with-gcc (3.4) --no-opt --cflags
> -Ic:/g/include -fno-crossjumping'
>
>
>
>

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.