GNU bug report logs - #3971
23.1.50; linum-mode kills right margin

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 3971 in the body.
You can then email your comments to 3971 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.1.50; linum-mode kills right margin
Date: Thu, 30 Jul 2009 06:38:26 +0200

linum-mode kills the right margin. It should not touch it since it
does not use it. The following patch fixes this:

Index: linum.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/linum.el,v
retrieving revision 1.11
diff -c -b -r1.11 linum.el
*** linum.el	18 Jan 2009 01:45:38 -0000	1.11
--- linum.el	30 Jul 2009 04:35:10 -0000
***************
*** 108,114 ****
    (mapc #'delete-overlay linum-overlays)
    (setq linum-overlays nil)
    (dolist (w (get-buffer-window-list (current-buffer) nil t))
!     (set-window-margins w 0)))

  (defun linum-update-current ()
    "Update line numbers for the current buffer."
--- 108,114 ----
    (mapc #'delete-overlay linum-overlays)
    (setq linum-overlays nil)
    (dolist (w (get-buffer-window-list (current-buffer) nil t))
!     (set-window-margins w 0 (cdr (window-margins w)))))

  (defun linum-update-current ()
    "Update line numbers for the current buffer."
***************
*** 163,169 ****
              (overlay-put ov 'linum-str str))))
        (forward-line)
        (setq line (1+ line)))
!     (set-window-margins win width)))

  (defun linum-after-change (beg end len)
    ;; update overlays on deletions, and after newlines are inserted
--- 163,169 ----
              (overlay-put ov 'linum-str str))))
        (forward-line)
        (setq line (1+ line)))
!     (set-window-margins win width (cdr (window-margins win)))))

  (defun linum-after-change (beg end len)
    ;; update overlays on deletions, and after newlines are inserted



In GNU Emacs 23.1.50.1 (i386-mingw-nt5.1.2600)
 of 2009-06-30
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags
-Ic:/g/include -fno-crossjumping'

Message #10 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: emacs-pretest-bug <at> gnu.org
Subject: Re: bug#3971: 23.1.50; linum-mode kills right margin
Date: Thu, 30 Jul 2009 07:24:27 +0200

Or, maybe it is better to redefine set-window-margins so that a nil
argument for a margin means "don't touch"...?


On Thu, Jul 30, 2009 at 6:38 AM, Lennart
Borgman<lennart.borgman <at> gmail.com> wrote:
> linum-mode kills the right margin. It should not touch it since it
> does not use it. The following patch fixes this:
>
> Index: linum.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/linum.el,v
> retrieving revision 1.11
> diff -c -b -r1.11 linum.el
> *** linum.el    18 Jan 2009 01:45:38 -0000      1.11
> --- linum.el    30 Jul 2009 04:35:10 -0000
> ***************
> *** 108,114 ****
>    (mapc #'delete-overlay linum-overlays)
>    (setq linum-overlays nil)
>    (dolist (w (get-buffer-window-list (current-buffer) nil t))
> !     (set-window-margins w 0)))
>
>  (defun linum-update-current ()
>    "Update line numbers for the current buffer."
> --- 108,114 ----
>    (mapc #'delete-overlay linum-overlays)
>    (setq linum-overlays nil)
>    (dolist (w (get-buffer-window-list (current-buffer) nil t))
> !     (set-window-margins w 0 (cdr (window-margins w)))))
>
>  (defun linum-update-current ()
>    "Update line numbers for the current buffer."
> ***************
> *** 163,169 ****
>              (overlay-put ov 'linum-str str))))
>        (forward-line)
>        (setq line (1+ line)))
> !     (set-window-margins win width)))
>
>  (defun linum-after-change (beg end len)
>    ;; update overlays on deletions, and after newlines are inserted
> --- 163,169 ----
>              (overlay-put ov 'linum-str str))))
>        (forward-line)
>        (setq line (1+ line)))
> !     (set-window-margins win width (cdr (window-margins win)))))
>
>  (defun linum-after-change (beg end len)
>    ;; update overlays on deletions, and after newlines are inserted
>
>
>
> In GNU Emacs 23.1.50.1 (i386-mingw-nt5.1.2600)
>  of 2009-06-30
> Windowing system distributor `Microsoft Corp.', version 5.1.2600
> configured using `configure --with-gcc (3.4) --no-opt --cflags
> -Ic:/g/include -fno-crossjumping'
>
>
>
>

Message #15 received at 3971-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 3971-done <at> debbugs.gnu.org
Subject: Re: bug#3971: 23.1.50; linum-mode kills right margin
Date: Tue, 22 Sep 2009 02:09:43 +0200

On Thu, Jul 30, 2009 at 07:24, Lennart Borgman
<lennart.borgman <at> gmail.com> wrote:

> Or, maybe it is better to redefine set-window-margins so that a nil
> argument for a margin means "don't touch"...?

I think that would be cleaner, because 0 is already available to set a
margin to "no margin".

But that's an interface change, so for now I've installed your change,
which fixes the bug.

    Juanma

Message #16 received at 3971-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 3971-done <at> debbugs.gnu.org
Subject: Re: bug#3971: 23.1.50; linum-mode kills right margin
Date: Tue, 22 Sep 2009 09:57:57 +0200

On Tue, Sep 22, 2009 at 2:09 AM, Juanma Barranquero <lekktu <at> gmail.com> wrote:
> On Thu, Jul 30, 2009 at 07:24, Lennart Borgman
> <lennart.borgman <at> gmail.com> wrote:
>
>> Or, maybe it is better to redefine set-window-margins so that a nil
>> argument for a margin means "don't touch"...?
>
> I think that would be cleaner, because 0 is already available to set a
> margin to "no margin".
>
> But that's an interface change, so for now I've installed your change,
> which fixes the bug.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.