GNU bug report logs - #39555
[PATCH] Allow tempo-define-template to reassign tags to new templates

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Federico Tedin <federicotedin <at> gmail.com>
Subject: bug#39555: closed (Re: bug#39555: [PATCH] Allow tempo-define-template
 to reassign tags to new templates)
Date: Fri, 21 Feb 2020 09:21:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#39555: [PATCH] Allow tempo-define-template to reassign tags to new templates

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 39555 <at> debbugs.gnu.org.

-- 
39555: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39555
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Federico Tedin <federicotedin <at> gmail.com>
Cc: 39555-done <at> debbugs.gnu.org
Subject: Re: bug#39555: [PATCH] Allow tempo-define-template to reassign tags
 to new templates
Date: Fri, 21 Feb 2020 11:20:40 +0200

> From: Federico Tedin <federicotedin <at> gmail.com>
> Cc: 39555 <at> debbugs.gnu.org
> Date: Mon, 17 Feb 2020 22:27:51 +0100
> 
> No problem, I'm attaching a new patch with those corrections applied.

Thanks, pushed to the master branch.

Please see my follow-up commit with minor punctuation fixes.  Also,
please try to always mention in the log message the bug number when
it's known (this is impossible if your original message that opens a
bug report already includes the patch, but it _is_ possible when you
post additional versions to the same bug report).

[Message part 3 (message/rfc822, inline)]

From: Federico Tedin <federicotedin <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Allow tempo-define-template to reassign tags to new templates
Date: Mon, 10 Feb 2020 23:34:04 +0100

[Message part 4 (text/plain, inline)]

(This may apply as a bug and as a wishlist item at the same time - not sure)

Two problems I've found using tempo.el are:

1) If I'm using templates + tags (with `tempo-complete-tag') in a buffer, and I
define new templates + tags from another buffer, I can't immediately use
them in the original buffer (I have to do M-: (setq
tempo-dirty-collection t) ).

2) If I want to assign a different template to an already existing tag,
I have to remove the tag manually from the tags collection.

These two problems can become a bit annoying specially when
writing/trying out new templates with tags. For someone learning about
tempo.el for the first time, I can imagine they could be a problem as
well. To fix these, I'm attaching a patch with some changes.

In `tempo-invalidate-collection', I decided to loop over every buffer to
check if `tempo-dirty-collection' has a local value, and only set it to
t if it does. I am not sure if this is the ideal way of setting a
buffer-local variable to a certain value for all buffers that have bound
a local value to it. Feedback is welcome.

- Fede

[tempo.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.