GNU bug report logs - #39528
[PATCH 0/1] add tunctl

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#39528: closed ([PATCH 0/1] add tunctl)
Date: Mon, 10 Feb 2020 00:04:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 10 Feb 2020 01:03:47 +0100
with message-id <87a75rz4t8.fsf <at> nicolasgoaziou.fr>
and subject line Re: [PATCH v4] Add tunctl
has caused the debbugs.gnu.org bug report #39528,
regarding [PATCH 0/1] add tunctl
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
39528: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39528
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/1] add tunctl
Date: Sun, 9 Feb 2020 16:44:43 +0100

Hello,

the following message is a patch to add the tunctl package.

I took it straight from NixOS and converted to guix.

The NixOS package's license field was set to GPLv2, but
the single C source code file has only "GPL" mentionned,
I kept the NixOS choice, is that right ?

Te description is the same as the synopsis, as I didn't know
what I could add. Looks straightforward enough for me...

I passed the C code through clang-7 scan-build, it reported
nothing worth changing IMHO.

Please advise if any change needs to be done

Thanks

-- 
Vincent Legoll

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Vincent Legoll <vincent.legoll <at> gmail.com>
Cc: 39528-done <at> debbugs.gnu.org
Subject: Re: [PATCH v4] Add tunctl
Date: Mon, 10 Feb 2020 01:03:47 +0100

Vincent Legoll <vincent.legoll <at> gmail.com> writes:

> thanks for your input, this version incorporates your feedback,
> with a s/is/are/ and a capitalized first word of description.
>
> WDYT?

Almost good! :)

I removed the (mkdir-p bin), not necessary with `install-file', changed
the commit message so it follows Guix conventions, and fixed the URI of
the package.

Applied. Thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.