GNU bug report logs - #39528
[PATCH 0/1] add tunctl

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39528 in the body.
You can then email your comments to 39528 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/1] add tunctl
Date: Sun, 9 Feb 2020 16:44:43 +0100

Hello,

the following message is a patch to add the tunctl package.

I took it straight from NixOS and converted to guix.

The NixOS package's license field was set to GPLv2, but
the single C source code file has only "GPL" mentionned,
I kept the NixOS choice, is that right ?

Te description is the same as the synopsis, as I didn't know
what I could add. Looks straightforward enough for me...

I passed the C code through clang-7 scan-build, it reported
nothing worth changing IMHO.

Please advise if any change needs to be done

Thanks

-- 
Vincent Legoll

Message #8 received at 39528 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: 39528 <at> debbugs.gnu.org
Subject: [PATCH 1/1] add tunctl
Date: Sun, 9 Feb 2020 16:49:18 +0100

[Message part 1 (text/plain, inline)]

here it is

-- 
Vincent Legoll

[0001-gnu-Add-tunctl.patch (text/x-patch, attachment)]

Message #11 received at 39528 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: 39528 <at> debbugs.gnu.org
Subject: [PATCH v2] add tunctl
Date: Sun, 9 Feb 2020 23:45:39 +0100

[Message part 1 (text/plain, inline)]

removed the S-O-B

-- 
Vincent Legoll

[0001-gnu-Add-tunctl.patch (text/x-patch, attachment)]

Message #14 received at 39528 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: 39528 <at> debbugs.gnu.org
Subject: [PATCH v3] Add tunctl
Date: Sun, 9 Feb 2020 23:50:19 +0100

[Message part 1 (text/plain, inline)]

with a better commit msg this time

-- 
Vincent Legoll

[0001-gnu-networking-Add-tunctl.patch (text/x-patch, attachment)]

Message #17 received at 39528 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Vincent Legoll <vincent.legoll <at> gmail.com>
Cc: 39528 <at> debbugs.gnu.org
Subject: Re: [bug#39528] [PATCH v3] Add tunctl
Date: Mon, 10 Feb 2020 00:06:08 +0100

Hello,

Vincent Legoll <vincent.legoll <at> gmail.com> writes:

> with a better commit msg this time

> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (bin (string-append out "/bin")))
> +               (mkdir-p bin)
> +               (copy-file "tunctl"
> +                          (string-append bin "/tunctl")))

You can replace the two last lines with

  (install-file "tunctl" bin)

> +    (description "Utility to set up and maintain TUN/TAP network interfaces")

This is a bit short. What about:

  tunctl is used to set up and maintain persistent TUN/TAP network
  interfaces, enabling user applications to simulate network traffic.
  Such interfaces is useful for VPN software, virtualization, emulation,
  simulation, and a number of other applications.

Thank you!
  
Regards,

-- 
Nicolas Goaziou

Message #20 received at 39528 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: 39528 <at> debbugs.gnu.org, mail <at> nicolasgoaziou.fr
Subject: [PATCH v4] Add tunctl
Date: Mon, 10 Feb 2020 00:40:12 +0100

[Message part 1 (text/plain, inline)]

Hello Nicolas,

thanks for your input, this version incorporates your feedback,
with a s/is/are/ and a capitalized first word of description.

WDYT?

-- 
Vincent Legoll

[0001-gnu-networking-Add-tunctl.patch (text/x-patch, attachment)]

Message #25 received at 39528-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Vincent Legoll <vincent.legoll <at> gmail.com>
Cc: 39528-done <at> debbugs.gnu.org
Subject: Re: [PATCH v4] Add tunctl
Date: Mon, 10 Feb 2020 01:03:47 +0100

Vincent Legoll <vincent.legoll <at> gmail.com> writes:

> thanks for your input, this version incorporates your feedback,
> with a s/is/are/ and a capitalized first word of description.
>
> WDYT?

Almost good! :)

I removed the (mkdir-p bin), not necessary with `install-file', changed
the commit message so it follows Guix conventions, and fixed the URI of
the package.

Applied. Thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.