GNU bug report logs - #39457
Fix baud-rate option in inputattach-service

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
Subject: bug#39457: closed (Re: [bug#39457] Fix baud-rate option in
 inputattach-service)
Date: Fri, 07 Feb 2020 03:55:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#39457: Fix baud-rate option in inputattach-service

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 39457 <at> debbugs.gnu.org.

-- 
39457: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39457
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: iyzsong <at> member.fsf.org (宋文武)
To: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
Cc: Raghav Gururajan <raghavgururajan <at> disroot.org>, 39457-done <at> debbugs.gnu.org
Subject: Re: [bug#39457] Fix baud-rate option in inputattach-service
Date: Fri, 07 Feb 2020 11:54:15 +0800

Tim Gesthuizen <tim.gesthuizen <at> yahoo.de> writes:

> Hi,
>
> the "baud-rate" option for inputattach-service is broken, the
> inputattach program expects the option to be named just "--baud".
> The attached patch fixes the issue.

Pushed, thank you!

>
> Just out of interest: Should we stick in Guix to the option used by the
> program or stick with the old name?
> I would like to keep the "baud-rate" name as it is the thing the
> parameter configures: The baud-rate for the connection.
>

I think both are fine, as we document it in our info manual.

:)

[Message part 3 (message/rfc822, inline)]

From: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
To: guix-patches <at> gnu.org
Cc: Raghav Gururajan <raghavgururajan <at> disroot.org>
Subject: Fix baud-rate option in inputattach-service
Date: Thu, 06 Feb 2020 19:37:32 +0100

[Message part 4 (text/plain, inline)]

Hi,

the "baud-rate" option for inputattach-service is broken, the
inputattach program expects the option to be named just "--baud".
The attached patch fixes the issue.

Just out of interest: Should we stick in Guix to the option used by the
program or stick with the old name?
I would like to keep the "baud-rate" name as it is the thing the
parameter configures: The baud-rate for the connection.

Tim.

[0001-services-inputattach-Fix-broken-baud-rate-option.patch (text/x-patch, inline)]

From 223608191ba3587b1e9f1e1257d482dc89c59709 Mon Sep 17 00:00:00 2001
From: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
Date: Thu, 6 Feb 2020 19:26:03 +0100
Subject: [PATCH] services: inputattach: Fix broken baud rate option

* gnu/services/desktop.scm (inputattach-shepherd-service): Use "--baud" for
  setting the baud-rate.
---
 gnu/services/desktop.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index 9dcdf38be1..1294d748ac 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -1070,7 +1070,7 @@ as expected.")))
   (match-lambda
     (($ <inputattach-configuration> type device baud-rate log-file)
      (let ((args (append (if baud-rate
-                             (list "--baud-rate" (number->string baud-rate))
+                             (list "--baud" (number->string baud-rate))
                              '())
                          (list (string-append "--" type)
                                device))))
-- 
2.25.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.