GNU bug report logs - #3928
23.1.50; compilation-mode not matching perl and more [regression]

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 3928 in the body.
You can then email your comments to 3928 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Kevin Ryde <user42 <at> zip.com.au>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.1.50; compilation-mode not matching perl and more [regression]
Date: Sat, 25 Jul 2009 22:42:44 +1000

[Message part 1 (text/plain, inline)]

Running "emacs -Q etc/compilation.txt" and scrolling down to the perl
section shows none of the sample perl errors matched at all, where I
hoped they would be.

I think the "^" anchor added by compilation-mode-font-lock-keywords
means perl and some other more obscure patterns need a ".*", like they
had back in Emacs 21, to work in the middle of a line.

I noticed this on the perl one.  I thought it was working fine not so
long ago, so I don't know what/when/how it went bad.  (The looseness of
Emacs 22 not anchoring reverted, but the patterns not put back at the
same time too??)


2009-07-25  Kevin Ryde  <user42 <at> zip.com.au>

	* progmodes/compile.el (compilation-error-regexp-alist-alist):
	In aix, ftnchek, mips-1, mips-2, perl, sun, 4bsd entries add ".*" so
	as to match in the middle of a line, now that there's a "^" anchor is
	again enforced by compilation-mode-font-lock-keywords.  These patterns
	were otherwise failing to match anything at all.
	In the 4bsd entry remove the "^" from inside the \\(\\) grouping since
	it's now unnecessary and since inside a group it isn't recognised by
	the omake indentation hack in compilation-mode-font-lock-keywords
	(meaning it wouldn't work with indentation).

[compile.el.cope-with-anchoring.diff (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

In GNU Emacs 23.1.50.4 (i586-pc-linux-gnu, GTK+ Version 2.16.4)
 of 2009-07-24 on blah.blah
configured using `configure  'CFLAGS=-O -g' '--prefix=/down/emacs/b/inst' '--with-x-toolkit=gtk''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-1-unix
  default-enable-multibyte-characters: t

Message #10 received at 3928 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Kevin Ryde <user42 <at> zip.com.au>
To: 3928 <at> debbugs.gnu.org
Subject: Re: bug#3928: compilation-mode not matching perl and more [regression]
Date: Mon, 27 Jul 2009 11:13:07 +1000

[Message part 1 (text/plain, inline)]

The ada entry is afflicted too (it's supposed to match the second part
of its compilation.txt, its first part is matched by the gnu pattern).
So,

2009-07-27  Kevin Ryde  <user42 <at> zip.com.au>

	* progmodes/compile.el (compilation-error-regexp-alist-alist):
	In ada, aix, ftnchek, mips-1, mips-2, perl, sun, 4bsd entries add ".*"
	so as to match in the middle of a line, now that there's a "^" anchor
	is again enforced by compilation-mode-font-lock-keywords.  These
	patterns were otherwise failing to match anything at all.
	In the 4bsd entry remove the "^" from inside the \\(\\) grouping since
	it's now unnecessary and since inside a group it isn't recognised by
	the omake indentation hack in compilation-mode-font-lock-keywords
	(meaning it wouldn't work with indentation).

[compile.el.cope-with-anchoring-2.diff (text/x-diff, attachment)]

Message #15 received at 3928 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Sam Steingold <sds <at> gnu.org>
Cc: 3928 <at> debbugs.gnu.org
Subject: changes to compilation-mode
Date: Mon, 12 Oct 2009 15:34:51 -0400

Hi. This change:

2009-07-10  Sam Steingold  <sds at gnu.org>

   * progmodes/compile.el (compilation-mode-font-lock-keywords): Omake
   sometimes indents the errors it prints, so allow all regexps to
   start with spaces.

seems to cause issues with several of the existing compilation error
regexps.

See

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3928

Please could you comment on / fix this?

I think it would be better not to have to change a bunch of the
existing regexps.

Message #20 received at 3928 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Sam Steingold <sds <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 3928 <at> debbugs.gnu.org
Subject: Re: changes to compilation-mode
Date: Mon, 12 Oct 2009 17:06:06 -0400

Hi, I fixed this in the CVS.
Sorry about the problem.

-- 
Sam Steingold <http://sds.podval.org>

Message #23 received at 3928 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Sam Steingold <sds <at> gnu.org>
Cc: 3928 <at> debbugs.gnu.org
Subject: Re: changes to compilation-mode
Date: Mon, 12 Oct 2009 21:02:41 -0400

Sam Steingold wrote:

> Hi, I fixed this in the CVS.

Thanks. In:

(= ?* (aref pat 1))

I guess it is supposed to be `(aref pat 2)'?

Message #28 received at 3928 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Sam Steingold <sds <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 3928 <at> debbugs.gnu.org
Subject: Re: changes to compilation-mode
Date: Mon, 12 Oct 2009 22:59:46 -0400

On Mon, Oct 12, 2009 at 9:02 PM, Glenn Morris <rgm <at> gnu.org> wrote:
>
> (= ?* (aref pat 1))
>
> I guess it is supposed to be `(aref pat 2)'?

oops. fixed. sorry.


-- 
Sam Steingold <http://sds.podval.org>

Message #33 received at 3928-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 3928-done <at> debbugs.gnu.org
Subject: Re: Bug#3928
Date: Mon, 12 Oct 2009 23:39:58 -0400

Fixed by this change:

2009-10-12  Sam Steingold  <sds at gnu.org>

* progmodes/compile.el (compilation-mode-font-lock-keywords): Do not
  prepend "^ *" to non-anchored patterns, like the perl one (bug#3928).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.