GNU bug report logs - #3911
get-free-disk-space race condition on default-directory test

Previous Next

Full log

View this message in rfc822 format

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Kevin Ryde <user42 <at> zip.com.au>
Cc: 3911 <at> debbugs.gnu.org
Subject: bug#3911: get-free-disk-space when default-directory doesn't exist
Date: Mon, 17 Aug 2009 21:02:27 -0400

Kevin Ryde <user42 <at> zip.com.au> writes:

> I think the test for file-remote-p is covered by the first line of the
> func so it's not needed in the dir condition bit, per below.

But that applies to DIR, not default-directory.

> I still think "/" might as well be used unconditionally though.

Principle of least surprise.  If we don't have to change the default
directory, let's not, even if it seems harmless (because we can never be
sure of every eventuality).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.