GNU bug report logs - #2631
get-free-disk-space when home dir also doesn't exist

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 2631 in the body.
You can then email your comments to 2631 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Kevin Ryde <user42 <at> zip.com.au>
To: bug-gnu-emacs <at> gnu.org
Subject: get-free-disk-space when default-directory doesn't exist
Date: Wed, 11 Mar 2009 09:24:04 +1100

[Message part 1 (text/plain, inline)]

Evaluating

    (with-temp-buffer
      (setq default-directory "/no/such/dir")
      (get-free-disk-space "/tmp"))

gets an error

    (file-error "Setting current directory" "no such file or directory" "/no/such/dir")

where I hoped it wouldn't care about default-directory, only the given
directory argument.  Perhaps a let-bind per below.



In GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11)
 of 2008-11-10 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs22:/etc/emacs:/usr/local/share/emacs/22.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/22.2/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/22.2/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU
  locale-coding-system: iso-8859-1
  default-enable-multibyte-characters: t

[files.el.free-space.diff (text/x-diff, inline)]

*** files.el	11 Mar 2009 08:46:04 +1100	1.1038
--- files.el	11 Mar 2009 09:14:14 +1100	
***************
*** 5336,5345 ****
        (save-match-data
  	(with-temp-buffer
  	  (when (and directory-free-space-program
! 		     (eq 0 (call-process directory-free-space-program
! 					 nil t nil
! 					 directory-free-space-args
! 					 dir)))
  	    ;; Usual format is a header line followed by a line of
  	    ;; numbers.
  	    (goto-char (point-min))
--- 5336,5346 ----
        (save-match-data
  	(with-temp-buffer
  	  (when (and directory-free-space-program
!                      (let ((default-directory "/"))
!                        (eq 0 (call-process directory-free-space-program
!                                            nil t nil
!                                            directory-free-space-args
!                                            dir))))
  	    ;; Usual format is a header line followed by a line of
  	    ;; numbers.
  	    (goto-char (point-min))

Message #10 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Kevin Ryde <user42 <at> zip.com.au>
Cc: 2631 <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org
Subject: Re: bug#2631: get-free-disk-space when default-directory doesn't exist
Date: Tue, 10 Mar 2009 22:10:13 -0400

> *** files.el	11 Mar 2009 08:46:04 +1100	1.1038
> --- files.el	11 Mar 2009 09:14:14 +1100	
> ***************
> *** 5336,5345 ****
>         (save-match-data
>   	(with-temp-buffer
>   	  (when (and directory-free-space-program
> ! 		     (eq 0 (call-process directory-free-space-program
> ! 					 nil t nil
> ! 					 directory-free-space-args
> ! 					 dir)))
>   	    ;; Usual format is a header line followed by a line of
>   	    ;; numbers.
>   	    (goto-char (point-min))
> --- 5336,5346 ----
>         (save-match-data
>   	(with-temp-buffer
>   	  (when (and directory-free-space-program
> !                      (let ((default-directory "/"))
> !                        (eq 0 (call-process directory-free-space-program
> !                                            nil t nil
> !                                            directory-free-space-args
> !                                            dir))))
>   	    ;; Usual format is a header line followed by a line of
>   	    ;; numbers.
>   	    (goto-char (point-min))

That would probably work OK, but why not bind default-directory to dir?
And even use process-file, while we're at it, so it has a chance to work
on Tramp.


        Stefan

Message #20 received at 2631 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>, 2631 <at> debbugs.gnu.org
Cc: user42 <at> zip.com.au
Subject: Re: bug#2631: get-free-disk-space when default-directory doesn't exist
Date: Wed, 11 Mar 2009 06:23:49 +0200

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Date: Tue, 10 Mar 2009 22:10:13 -0400
> Cc: bug-gnu-emacs <at> gnu.org, 2631 <at> emacsbugs.donarmstrong.com
> 
> > *** files.el	11 Mar 2009 08:46:04 +1100	1.1038
> > --- files.el	11 Mar 2009 09:14:14 +1100	
> > ***************
> > *** 5336,5345 ****
> >         (save-match-data
> >   	(with-temp-buffer
> >   	  (when (and directory-free-space-program
> > ! 		     (eq 0 (call-process directory-free-space-program
> > ! 					 nil t nil
> > ! 					 directory-free-space-args
> > ! 					 dir)))
> >   	    ;; Usual format is a header line followed by a line of
> >   	    ;; numbers.
> >   	    (goto-char (point-min))
> > --- 5336,5346 ----
> >         (save-match-data
> >   	(with-temp-buffer
> >   	  (when (and directory-free-space-program
> > !                      (let ((default-directory "/"))
> > !                        (eq 0 (call-process directory-free-space-program
> > !                                            nil t nil
> > !                                            directory-free-space-args
> > !                                            dir))))
> >   	    ;; Usual format is a header line followed by a line of
> >   	    ;; numbers.
> >   	    (goto-char (point-min))
> 
> That would probably work OK, but why not bind default-directory to dir?

Yes, this is much better, since "/" is not guaranteed to work
(accessibility and stuff).

> And even use process-file, while we're at it, so it has a chance to work
> on Tramp.

Even better.

Message #25 received at 2631 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Kevin Ryde <user42 <at> zip.com.au>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 2631 <at> debbugs.gnu.org
Subject: Re: bug#2631: get-free-disk-space when default-directory doesn't exist
Date: Thu, 12 Mar 2009 08:00:10 +1100

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>
> why not bind default-directory to dir?

I think that'd make it error out on a non-existant dir argument, where
currently it returns nil (from the df parsing code, and it looks like
from file-system-info in dosfns.c).

There's a few other places binding to "/", like man.el and message.el,
if it ought to be something else ...

Message #30 received at 2631-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Kevin Ryde <user42 <at> zip.com.au>, Eli Zaretskii <eliz <at> gnu.org>,
        2631-done <at> debbugs.gnu.org
Subject: Re: bug#2631: get-free-disk-space when default-directory doesn't exist
Date: Sat, 14 Mar 2009 22:34:14 -0400

Stefan Monnier <monnier <at> iro.umontreal.ca> wrote:

> That would probably work OK, but why not bind default-directory to
> dir?  And even use process-file, while we're at it, so it has a chance
> to work on Tramp.

I don't think there's any chance to make get-free-disk-space to work on
remote files without major surgery (it currently returns nil immediately
if the file is remote).

I've checked in a modified version of Kevin's patch, which sets
default-directory to "~/" rather than "/", but only if the existing
default-directory is not usable.

Message #35 received at 2631 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Kevin Ryde <user42 <at> zip.com.au>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 2631 <at> debbugs.gnu.org
Subject: Re: bug#2631: get-free-disk-space when default-directory doesn't exist
Date: Tue, 17 Mar 2009 11:02:26 +1100

[Message part 1 (text/plain, inline)]

Chong Yidong <cyd <at> stupidchicken.com> writes:
>
> default-directory to "~/" rather than "/"

What is it that's not good about "/"?  It doesn't have to be readable or
anything I don't think, just somewhere capable of a chdir().  Wouldn't
it be the only thing certain to work with chdir()?  As I mentioned
before there's other places using "/" for the same purpose if there's
something wrong with it.


Either way what I missed from my first post was that a change to
default-directory ought to absolutize the given dir argument, so that
say

    (get-free-disk-space ".")

gives info about the original default-directory, not the mangled one.

[files.el.disk-space-expand.diff (text/x-diff, inline)]

*** files.el	17 Mar 2009 10:35:50 +1100	1.1040
--- files.el	17 Mar 2009 10:53:40 +1100	
***************
*** 5341,5346 ****
--- 5341,5347 ----
  				      (file-directory-p default-directory)
  				      (file-readable-p default-directory))
  				 default-directory
+ 			       (setq dir (expand-file-name dir))
  			       (expand-file-name "~/"))))
  		       (eq (call-process directory-free-space-program
  					 nil t nil

Message #40 received at 2631 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Kevin Ryde <user42 <at> zip.com.au>, 2631 <at> debbugs.gnu.org
Cc: cyd <at> stupidchicken.com
Subject: Re: bug#2631: get-free-disk-space when default-directory doesn't exist
Date: Tue, 17 Mar 2009 06:05:02 +0200

> From: Kevin Ryde <user42 <at> zip.com.au>
> Date: Tue, 17 Mar 2009 11:02:26 +1100
> Cc: 2631 <at> emacsbugs.donarmstrong.com
> 
> > default-directory to "~/" rather than "/"
> 
> What is it that's not good about "/"?  It doesn't have to be readable or
> anything I don't think, just somewhere capable of a chdir().

Doesn't chdir need certain rights? what if the user doesn't have them?

> Either way what I missed from my first post was that a change to
> default-directory ought to absolutize the given dir argument, so that
> say
> 
>     (get-free-disk-space ".")
> 
> gives info about the original default-directory, not the mangled one.

What "mangled one"?

Message #45 received at 2631 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Kevin Ryde <user42 <at> zip.com.au>
To: control <at> debbugs.gnu.org, 2631 <at> debbugs.gnu.org
Subject: Re: bug#2631: get-free-disk-space when default-directory doesn't exist
Date: Sat, 28 Mar 2009 10:17:47 +1100

[Message part 1 (text/plain, inline)]

reopen 2631
retitle 2631 get-free-disk-space when home dir also doesn't exist
tags 2631 +patch
thanks

If both default-directory and home directory both don't exist
get-free-disk-space still gets an error

    (progn
      (setq default-directory "/no/such/dir")
      (setenv "HOME" "/another/no/such/dir")
      (get-free-disk-space "/"))
    => (file-error "Setting current directory" "no such file or directory" "/another/no/such/dir/")

Although plenty of things probably depend on a home dir I don't think
get-free-disk-space needs to be one of them.

Change below is like what's also in the following funcs, I believe for
the same purpose, ie. just to make sure call-process will be happy, when
the program run doesn't care about the current directory.

    Man-init-defvars,
    mail-source-movemail
    message-send-mail-with-sendmail
    sendmail-send-it
    gamegrid-add-score-with-update-game-score-1

[files.el.disk-space-root.diff (text/x-diff, inline)]

*** files.el	28 Mar 2009 09:50:47 +1100	1.1041
--- files.el	28 Mar 2009 09:56:48 +1100	
***************
*** 5336,5352 ****
        (save-match-data
  	(with-temp-buffer
  	  (when (and directory-free-space-program
! 		     (let ((default-directory
! 			     (if (and (not (file-remote-p default-directory))
! 				      (file-directory-p default-directory)
! 				      (file-readable-p default-directory))
! 				 default-directory
! 			       (expand-file-name "~/"))))
! 		       (eq (call-process directory-free-space-program
! 					 nil t nil
! 					 directory-free-space-args
! 					 dir)
! 			   0)))
  	    ;; Usual format is a header line followed by a line of
  	    ;; numbers.
  	    (goto-char (point-min))
--- 5336,5349 ----
        (save-match-data
  	(with-temp-buffer
  	  (when (and directory-free-space-program
! 		     (progn
! 		       (setq dir (expand-file-name dir)) ;; in case relative
! 		       (let ((default-directory "/"))
! 			 (eq (call-process directory-free-space-program
! 					   nil t nil
! 					   directory-free-space-args
! 					   dir)
! 			     0))))
  	    ;; Usual format is a header line followed by a line of
  	    ;; numbers.
  	    (goto-char (point-min))

Message #56 received at 2631 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Kevin Ryde <user42 <at> zip.com.au>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 2631 <at> debbugs.gnu.org
Subject: Re: bug#2631: get-free-disk-space when default-directory doesn't exist
Date: Sat, 28 Mar 2009 10:32:45 +1100

Eli Zaretskii <eliz <at> gnu.org> writes:
>
> Doesn't chdir need certain rights?

Only search perms in the parent directories leading to a given dir, I
believe.

I suppose the root dir could be unreadable/unsearchable too.  Dunno what
chdir would do in that case (I'm not brave enough to try it either!) but
certainly if the root dir is unsearchable then no subdir can work.

Message #61 received at 2631-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Kevin Ryde <user42 <at> zip.com.au>
Cc: 2631-done <at> debbugs.gnu.org, 3911-done <at> debbugs.gnu.org
Subject: Re: get-free-disk-space when default-directory doesn't exist
Date: Sat, 15 Aug 2009 20:34:52 -0400

> What is it that's not good about "/"?  It doesn't have to be readable
> or anything I don't think, just somewhere capable of a chdir()...  If
> both default-directory and home directory both don't exist
> get-free-disk-space still gets an error

You're right; it's probably better to fall back on / instead of ~.  I've
just checked in your suggested change.

> (let ((default-directory "/no/such/dir"))
>   (get-free-disk-space "."))
> => 3705637

I checked in your suggestion to do expand-file-name before changing the
default-directory, as well.  Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.