GNU bug report logs - #39094
27.0.50; ; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: <lin.sun <at> zoom.us>
Subject: bug#38014: closed (regexp-quote the param in makefile-move-to-macro
 to avoid error message)
Date: Fri, 17 Jan 2020 00:13:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#39094: 26.3.50; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 38014 <at> debbugs.gnu.org.

-- 
39094: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39094
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Lin Sun <lin.sun <at> zoom.us>
Cc: 39094-done <at> debbugs.gnu.org
Subject: regexp-quote the param in makefile-move-to-macro to avoid error
 message
Date: Thu, 16 Jan 2020 16:12:01 -0800

Thanks for reporting that bug. I installed your patch into the master 
branch.

[Message part 3 (message/rfc822, inline)]

From: <lin.sun <at> zoom.us>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 26.3.50; [PATCH] * makefile-edit.el: regexp-quote the param in
 makefile-move-to-macro to avoid error message
Date: Fri, 1 Nov 2019 10:59:44 +0800

[PATCH] * makefile-edit.el: regexp-quote the param in
makefile-move-to-macro.

Fix the error message from `makefile-move-to-macro' when there is '$'
or '\\' in param for re-search-forward, with `(global-ede-mode t)' and
`(semantic-mode t)'. Enable ede and semantic mode, then open a
Makefile.am in which has line 'AM_LIBTMP_LIBS:=$(shell X \--libs)'
will trigger this issue.
---
 lisp/cedet/ede/makefile-edit.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/cedet/ede/makefile-edit.el
b/lisp/cedet/ede/makefile-edit.el
index 7d8a44b..add1675 100644
--- a/lisp/cedet/ede/makefile-edit.el
+++ b/lisp/cedet/ede/makefile-edit.el
@@ -78,7 +78,7 @@ makefile-move-to-macro
 If NEXT is non-nil, move to the next occurrence of MACRO."
   (let ((oldpt (point)))
     (when (not next) (goto-char (point-min)))
-    (if (re-search-forward (concat "^\\s-*" macro "\\s-*[+:?]?=") nil t)
+    (if (re-search-forward (concat "^\\s-*" (regexp-quote macro)
"\\s-*[+:?]?=") nil t)
        t
       (goto-char oldpt)
       nil)))
--
2.2.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.