GNU bug report logs - #39093
[PATCH] gnu: Add emacs-vterm.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39093 in the body.
You can then email your comments to 39093 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "LaFreniere\, Joseph" <joseph <at> lafreniere.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-vterm.
Date: Sat, 11 Jan 2020 21:50:26 -0600

[Message part 1 (text/plain, inline)]

Patch files is attached.  There have not yet been any tagged 
releases in the source repo, so I have left the version as 0.

I initially tried using a patch file instead of manually using the 
substitute snippet, but that was failing with an error that 
vterm.el was read-only.  If there is a workaround, I would gladly 
return to using a patch file.

--
Joseph LaFreniere

[0001-gnu-Add-emacs-vterm.patch (text/x-patch, attachment)]

Message #8 received at 39093 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "LaFreniere\, Joseph" <joseph <at> lafreniere.xyz>
Cc: 39093 <at> debbugs.gnu.org
Subject: Re: [bug#39093] [PATCH] gnu: Add emacs-vterm.
Date: Tue, 21 Jan 2020 15:07:10 +0100

Hello Joseph,

"LaFreniere, Joseph" <joseph <at> lafreniere.xyz> skribis:

>>From 06223ab2ed07b3fbfb2dfd95aa0a5fce1c44baf9 Mon Sep 17 00:00:00 2001
> From: Joseph LaFreniere <joseph <at> lafreniere.xyz>
> Date: Mon, 6 Jan 2020 20:56:35 -0600
> Subject: [PATCH] gnu: Add emacs-vterm.
>
> * gnu/packages/emacs-xyz.scm (emacs-vterm): New variable.

Neat!

> +                (modules '((guix build utils)))
> +                (snippet
> +                 '(begin
> +                    (delete-file "vterm-module-make.el")
> +                    (substitute* "vterm.el"
> +                      (((string-append "\\(or \\(require 'vterm-module nil t\\)\n"
> +                                       "^.*\\(and \\(require 'vterm-module-make\\)\n"
> +                                       "^.*\\(require 'vterm-module\\)\\)\\)"))
> +                       "(module-load \"vterm-module.so)"))
> +                    (make-file-writable "vterm.el")

Apparently this substitution doesn’t have the desired effect.  Also,
I strongly recommend using literal strings as patterns.

Actually, what about performing this substitution as a phase instead of
here?  We could probably use ‘emacs-substitute-sexps’ to do that, which
should be nicer, and we could also hard-code the absolute file name of
‘vterm-module.so’.

How does that sound?

The rest LGTM!

Thanks,
Ludo’.

Message #11 received at 39093 <at> debbugs.gnu.org (full text, mbox):

From: "LaFreniere\, Joseph" <joseph <at> lafreniere.xyz>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 39093 <at> debbugs.gnu.org
Subject: Re: [bug#39093] [PATCH] gnu: Add emacs-vterm.
Date: Sun, 26 Jan 2020 09:06:42 -0600

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:
> Actually, what about performing this substitution as a phase 
> instead of
> here?  We could probably use ‘emacs-substitute-sexps’ to do 
> that, which
> should be nicer, and we could also hard-code the absolute file 
> name of
> ‘vterm-module.so’.

Thank you for the feedback, Ludo.

A new patch is attached.  Both of the suggested changes (using 
emacs-substitute-sexps and hardcoding the absolute path of the 
shared object) have been implemented.  Additionally, the shared 
object has been moved into /lib.

--
Joseph LaFreniere

[0001-gnu-Add-emacs-vterm.patch (text/x-patch, attachment)]

Message #16 received at 39093-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "LaFreniere\, Joseph" <joseph <at> lafreniere.xyz>
Cc: 39093-done <at> debbugs.gnu.org
Subject: Re: [bug#39093] [PATCH] gnu: Add emacs-vterm.
Date: Sun, 26 Jan 2020 23:10:58 +0100

Hi,

"LaFreniere, Joseph" <joseph <at> lafreniere.xyz> skribis:

> A new patch is attached.  Both of the suggested changes (using
> emacs-substitute-sexps and hardcoding the absolute path of the shared
> object) have been implemented.  Additionally, the shared object has
> been moved into /lib.

Awesome.

> From 74e99bf345ef14b08a052c923418a068c9a24de0 Mon Sep 17 00:00:00 2001
> From: Joseph LaFreniere <joseph <at> lafreniere.xyz>
> Date: Mon, 6 Jan 2020 20:56:35 -0600
> Subject: [PATCH] gnu: Add emacs-vterm.
>
> * gnu/packages/emacs-xyz.scm (emacs-vterm): New variable.

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.