GNU bug report logs - #38992
27.0.60; when enabled, fido-mode seems to break vc-git-grep

Previous Next

Package: emacs;

Reported by: waah <at> yellowfrog.io

Date: Mon, 6 Jan 2020 17:47:02 UTC

Severity: normal

Merged with 39407

Found in versions 27.0.60, 28.0.50

Done: João Távora <joaotavora <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #97 received at 38992 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 38992 <at> debbugs.gnu.org,
 João Távora <joaotavora <at> gmail.com>, waah <at> yellowfrog.io
Subject: Re: bug#38992: 27.0.60; when enabled, fido-mode seems to break
 vc-git-grep
Date: Fri, 24 Jan 2020 01:07:15 +0300

[Message part 1 (text/plain, inline)]
On 23.01.2020 19:28, Stefan Monnier wrote:
> We could introduce a new `minibuffer-require-match` variable (and mark
> `minibuffer-completion-confirm` obsolete).

Why don't we just co-opt the older variable. A rename can come later. 
See patch 1.

Here's another issue related to the previous proposed fix: why *would* 
M-j exit minibuffer in all cases? It currently doesn't honor 
REQUIRE-MATCH=t (or the confirm- values, but I don't care about that). 
The default completing-read, as well as icomplete-mode, both honor it. 
The patch 2 fixes that.

Please take a look, y'all.

[0001-Honor-require-match-nil-in-icomplete-fido-ret.patch (text/x-patch, attachment)]
[0002-Make-M-j-in-fido-mode-honor-REQUIRE-MATCH-t.patch (text/x-patch, attachment)]
This bug report was last modified 5 years and 77 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.