GNU bug report logs - #38992
27.0.60; when enabled, fido-mode seems to break vc-git-grep

Previous Next

Package: emacs;

Reported by: waah <at> yellowfrog.io

Date: Mon, 6 Jan 2020 17:47:02 UTC

Severity: normal

Merged with 39407

Found in versions 27.0.60, 28.0.50

Done: João Távora <joaotavora <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #231 received at 38992 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 38992 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>,
 waah <at> yellowfrog.io, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#38992: 27.0.60;
 when enabled, fido-mode seems to break vc-git-grep
Date: Sat, 7 Mar 2020 19:28:21 +0000
[Message part 1 (text/plain, inline)]
Ok, sounds good.

In the future, I will refrain from doing this.
Again, I just did it cause I have very little time on my hands right now,
and wanted to solve this simple matter in a rare window of opportunity.

In hindsight, I should have placed these commits in a branch ready to
merge, but I feared they might be forgotten.

João

On Sat, Mar 7, 2020, 17:42 Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: João Távora <joaotavora <at> gmail.com>
> > Date: Sat, 7 Mar 2020 16:42:00 +0000
> > Cc: 38992-done <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>,
> monnier <at> iro.umontreal.ca,
> >       38992 <at> debbugs.gnu.org, waah <at> yellowfrog.io
> >
> >  Disregarding the fact that I wasn't sure this is OK for emacs-27, and
> >  asked Stefan for his opinion?  Why??
> >
> > Because:
> >
> > - I was and am 99% positive that Stefan will agree with me
> > - both the thread and Dmitry's patch evolved in a way that took the
> safety of such a push in consideration.
> > - I had no other good window to do so in the near future.
>
> Please don't do that in the future, we discuss things here because
> they matter.
>
> > Anyway, if you believe these reasons to be insufficient, you can revert
> the commits. I don't think there will be
> > any conflicts to that.
>
> Let's wait and see what Stefan thinks about this.
>
[Message part 2 (text/html, inline)]

This bug report was last modified 5 years and 77 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.