GNU bug report logs - #38992
27.0.60; when enabled, fido-mode seems to break vc-git-grep

Previous Next

Package: emacs;

Reported by: waah <at> yellowfrog.io

Date: Mon, 6 Jan 2020 17:47:02 UTC

Severity: normal

Merged with 39407

Found in versions 27.0.60, 28.0.50

Done: João Távora <joaotavora <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: João Távora <joaotavora <at> gmail.com>
To: waah <at> yellowfrog.io, 38992-done <at> debbugs.gnu.org
Cc: 38992 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep
Date: Thu, 9 Jan 2020 10:10:54 +0000
On Thu, Jan 9, 2020 at 9:54 AM João Távora <joaotavora <at> gmail.com> wrote:
>
> On Thu, Jan 9, 2020 at 7:49 AM <waah <at> yellowfrog.io> wrote:
> >
> > Hi,
> >
> > icomplete on its own seems fine.
>
> ... or so with would seem :-)  But if the user customizes
> `icomplete-show-matches-on-no-input` to t, the problem is
> there again.
>
> fido-mode's ido-opinionated semantics automatically turn
> on that variable during fido-completion and that's why you
> get the error unconditionally in fido-mode.
>
> The error was introduced by me, anyway, in both modes,
> and the fix is simple.  It'll be in emacs-27 in a moment.

I've pushed the fix.  The problem was the non-string minibuffer-default
used by M-x rgrep.  Please retest.

João




This bug report was last modified 5 years and 126 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.