GNU bug report logs - #38992
27.0.60; when enabled, fido-mode seems to break vc-git-grep

Previous Next

Full log

View this message in rfc822 format

From: João Távora <joaotavora <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 38992 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>, waah <at> yellowfrog.io
Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep
Date: Wed, 4 Mar 2020 22:44:08 +0000

[Message part 1 (text/plain, inline)]

On Wed, Mar 4, 2020 at 10:07 PM Dmitry Gutov <dgutov <at> yandex.ru> wrote:
> It's a bug because it changes icomplete-mode in a way that makes
> completing-read fail its contract (which is to demand matching input
> when require-match is non-nil) in certain situations.

fido-mode doesn't change icomplete-mode. It shouldn't, at least.
It just uses it as a library.  And surely if it's a bug in fido-mode,
surely it needs fixing _there_  and not elsewhere.  But it seems
not be the case (at least with your latest proposal), so you have
me confused.

> > Great!   Disregard the previous discussion if you want, just do this,
> > and move on.
>
> Yup.

So much time has passed that I don't remember what the fix was anymore.
Have you pushed it?  I don't see it in emacs-27

João

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.