GNU bug report logs - #38992
27.0.60; when enabled, fido-mode seems to break vc-git-grep

Previous Next

Package: emacs;

Reported by: waah <at> yellowfrog.io

Date: Mon, 6 Jan 2020 17:47:02 UTC

Severity: normal

Merged with 39407

Found in versions 27.0.60, 28.0.50

Done: João Távora <joaotavora <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #115 received at 38992 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 38992 <at> debbugs.gnu.org,
 João Távora <joaotavora <at> gmail.com>, waah <at> yellowfrog.io
Subject: Re: bug#38992: 27.0.60; when enabled, fido-mode seems to break
 vc-git-grep
Date: Fri, 31 Jan 2020 04:48:16 +0300

On 30.01.2020 0:23, Stefan Monnier wrote:
> Maybe it used to be that `minibuffer-completion-confirm` used to be set
> to something like (not (memq require-match '(nil t)))?

Not exactly. It was set to (not require-match), basically.

The last place that changed was commit 695deb1857d, almost 18 years ago 
by your hand.

> In any case, I do know it used to be that
> `minibuffer-completion-confirm` was only boolean.

Speaking of, there's this condition in icomplete-exhibit that computes 
the require-match argument of icomplete-completions as

  (if (window-minibuffer-p)
    (not minibuffer-completion-confirm))

but it only affects cosmetics. It seems wrong (to me) now, but it makes 
sense looking at the code before the aforementioned commit.
This bug report was last modified 5 years and 77 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.