GNU bug report logs - #38767
[PATCH] Add Xournal++

Previous Next

Full log

Message #11 received at 38767 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: mail <at> nicolasgoaziou.fr
Cc: 38767 <at> debbugs.gnu.org
Subject: Re: [bug#38767] [PATCH] Add Xournal++
Date: Sun, 09 Feb 2020 09:52:28 +0000

[Message part 1 (text/plain, inline)]

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:
>
>> The following patch add Xournal++. There are a few caveats:
>>
>> - it requires applying my patch at bug#38765;
>>
>> - it cannot find Lua even though "lua" is included in the inputs.
>>   I left a "fixme" about it;
>>
>> - it crashes when trying to insert an image.
>
> I fixed the crash and updated xournalpp to 1.0.17. The Lua part is still
> open.
>
> I attach the new patch for further feedback.

Maybe start the synopsis with a capital letter (so "Handwriting
notetaking ..."), but apart from that this looks good to me :)

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.