GNU bug report logs - #38767
[PATCH] Add Xournal++

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38767 in the body.
You can then email your comments to 38767 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add Xournal++
Date: Sat, 28 Dec 2019 00:27:43 +0100

[Message part 1 (text/plain, inline)]

Hello,

The following patch add Xournal++. There are a few caveats:

- it requires applying my patch at bug#38765;

- it cannot find Lua even though "lua" is included in the inputs.
  I left a "fixme" about it;

- it crashes when trying to insert an image.

Feedback welcome.

Regards,

-- 
Nicolas Goaziou

[0001-gnu-Add-xournalpp.patch (text/x-diff, inline)]

From 83ff0917427a13739ec2c65add1f1361c8406ff4 Mon Sep 17 00:00:00 2001
From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Date: Fri, 27 Dec 2019 22:43:25 +0100
Subject: [PATCH] gnu: Add xournalpp.

* gnu/packages/pdf.scm (xournalpp): New variable.
---
 gnu/packages/pdf.scm | 83 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 83 insertions(+)

diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index ebe0168ff2..799e977a36 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -17,6 +17,7 @@
 ;;; Copyright © 2019 Alex Griffin <a <at> ajgrf.com>
 ;;; Copyright © 2019 Ben Sturmfels <ben <at> sturm.com.au>
 ;;; Copyright © 2019 Hartmut Goebel <h.goebel <at> crazy-compilers.com>
+;;; Copyright © 2019 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -45,6 +46,7 @@
   #:use-module (guix build-system python)
   #:use-module (guix build-system trivial)
   #:use-module (gnu packages)
+  #:use-module (gnu packages audio)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages backup)
   #:use-module (gnu packages base)
@@ -55,6 +57,7 @@
   #:use-module (gnu packages djvu)
   #:use-module (gnu packages fontutils)
   #:use-module (gnu packages game-development)
+  #:use-module (gnu packages gcc)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages ghostscript)
   #:use-module (gnu packages gl)
@@ -74,6 +77,7 @@
   #:use-module (gnu packages perl)
   #:use-module (gnu packages photo)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages python)
   #:use-module (gnu packages python-check)
   #:use-module (gnu packages python-web)
@@ -82,8 +86,10 @@
   #:use-module (gnu packages sdl)
   #:use-module (gnu packages sphinx)
   #:use-module (gnu packages sqlite)
+  #:use-module (gnu packages tex)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages xdisorg)
+  #:use-module (gnu packages xml)
   #:use-module (gnu packages xorg)
   #:use-module (srfi srfi-1))
 
@@ -752,6 +758,83 @@ program capable of converting PDF into other formats.")
 using a stylus.")
     (license license:gpl2+)))
 
+(define-public xournalpp
+  (package
+    (name "xournalpp")
+    (version "1.0.16")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/xournalpp/xournalpp.git")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1bdmxxkcqpjvkckizmrz2839b4yspw4xv69bqkrrgkcyvxsr804w"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:configure-flags (list "-DENABLE_CPPUNIT=ON") ;enable tests
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'fix-permissions-on-po-files
+           ;; Make sure 'msgmerge' can modify the PO files.
+           (lambda _
+             (for-each (lambda (po) (chmod po #o666))
+                       (find-files "." "\\.po$"))
+             #t)))))
+    (native-inputs
+     `(("cppunit" ,cppunit)
+       ("gcc" ,gcc-8)                   ;requires gcc 8+
+       ("gettext" ,gettext-minimal)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("alsa-lib" ,alsa-lib)
+       ("glib" ,glib)
+       ("gtk+" ,gtk+)
+       ("libsndfile" ,libsndfile)
+       ("libxml2" ,libxml2)
+       ("libzip" ,libzip)
+       ;; FIXME: It cannot find the Lua library.
+       ("lua" ,lua)
+       ("poppler" ,poppler)
+       ("portaudio" ,portaudio)
+       ("texlive-bin" ,texlive-bin)))
+    (home-page "https://github.com/xournalpp/xournalpp")
+    (synopsis "handwriting notetaking software with PDF annotation support")
+    (description "Xournal++ is a hand note taking software written in
+C++ with the target of flexibility, functionality and speed.  Stroke
+recognizer and other parts are based on Xournal code.
+
+Xournal++ features:
+
+@itemize
+@item Support for Pen pressure, e.g., Wacom Tablet
+@item Support for annotating PDFs
+@item Fill shape functionality
+@item PDF Export (with and without paper style)
+@item PNG Export (with and without transparent background)
+@item Allow to map different tools / colors etc. to stylus buttons /
+mouse buttons
+@item Sidebar with Page Previews with advanced page sorting, PDF
+Bookmarks and Layers (can be individually hidden, editing layer can be
+selected)
+@item enhanced support for image insertion
+@item Eraser with multiple configurations
+@item LaTeX support
+@item bug reporting, autosave, and auto backup tools
+@item Customizeable toolbar, with multiple configurations, e.g., to
+optimize toolbar for portrait / landscape
+@item Page Template definitions
+@item Shape drawing (line, arrow, circle, rectangle)
+@item Shape resizing and rotation
+@item Rotation snapping every 45 degrees
+@item Rect snapping to grid
+@item Audio recording and playback alongside with handwritten notes
+@item Multi Language Support, Like English, German, Italian...
+@item Plugins using LUA Scripting
+@end itemize")
+    (license license:gpl2+)))
+
 (define-public python-reportlab
   (package
     (name "python-reportlab")
-- 
2.24.1

Message #8 received at 38767 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 38767 <at> debbugs.gnu.org
Subject: Re: [bug#38767] [PATCH] Add Xournal++
Date: Sat, 08 Feb 2020 20:59:33 +0100

[Message part 1 (text/plain, inline)]

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> The following patch add Xournal++. There are a few caveats:
>
> - it requires applying my patch at bug#38765;
>
> - it cannot find Lua even though "lua" is included in the inputs.
>   I left a "fixme" about it;
>
> - it crashes when trying to insert an image.

I fixed the crash and updated xournalpp to 1.0.17. The Lua part is still
open.

I attach the new patch for further feedback.

Thank you.

[0001-gnu-Add-xournalpp.patch (text/x-diff, attachment)]

Message #11 received at 38767 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: mail <at> nicolasgoaziou.fr
Cc: 38767 <at> debbugs.gnu.org
Subject: Re: [bug#38767] [PATCH] Add Xournal++
Date: Sun, 09 Feb 2020 09:52:28 +0000

[Message part 1 (text/plain, inline)]

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:
>
>> The following patch add Xournal++. There are a few caveats:
>>
>> - it requires applying my patch at bug#38765;
>>
>> - it cannot find Lua even though "lua" is included in the inputs.
>>   I left a "fixme" about it;
>>
>> - it crashes when trying to insert an image.
>
> I fixed the crash and updated xournalpp to 1.0.17. The Lua part is still
> open.
>
> I attach the new patch for further feedback.

Maybe start the synopsis with a capital letter (so "Handwriting
notetaking ..."), but apart from that this looks good to me :)

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 38767-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 38767-done <at> debbugs.gnu.org
Subject: Re: [bug#38767] [PATCH] Add Xournal++
Date: Sun, 09 Feb 2020 17:37:41 +0100

Hello,

Christopher Baines <mail <at> cbaines.net> writes:

> Maybe start the synopsis with a capital letter (so "Handwriting
> notetaking ..."), but apart from that this looks good to me :)

Indeed, fixed.

Applied as ebbd30ff399e1194dafbf7f1c58dd07272f18624.

Thank you for the feedback.

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.