GNU bug report logs - #38677
26.3; `display-buffer-reuse-mode-window' doesn't check for derived modes

Previous Next

Package: emacs;

Reported by: Trevor Murphy <trevormurphy <at> google.com>

Date: Thu, 19 Dec 2019 20:42:02 UTC

Severity: normal

Tags: fixed, patch

Found in version 26.3

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Trevor Murphy <trevormurphy <at> google.com>
To: 38677 <at> debbugs.gnu.org
Subject: bug#38677: [PATCH] Fix bug in `display-buffer-reuse-mode-window'. (bug#38677)
Date: Thu, 19 Dec 2019 18:28:12 -0800

Sorry about the delay getting this out, I can never remember how to
use git send-email.

---
 lisp/window.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/window.el b/lisp/window.el
index a0280eba9b..96a22db885 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -7619,7 +7619,7 @@ indirectly called by the latter."
                (with-current-buffer (window-buffer window)
                  (cond ((memq major-mode allowed-modes)
                         'same)
-                       ((derived-mode-p allowed-modes)
+                       ((apply #'derived-mode-p allowed-modes)
                         'derived)))))
           (when (and mode?
                      (not (and inhibit-same-window-p
-- 
2.24.1.735.g03f4e72817-goog
This bug report was last modified 4 years and 290 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.