GNU bug report logs - #38677
26.3; `display-buffer-reuse-mode-window' doesn't check for derived modes

Previous Next

Package: emacs;

Reported by: Trevor Murphy <trevormurphy <at> google.com>

Date: Thu, 19 Dec 2019 20:42:02 UTC

Severity: normal

Tags: fixed, patch

Found in version 26.3

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Trevor Murphy <trevormurphy <at> google.com>
To: 38677 <at> debbugs.gnu.org
Subject: bug#38677: 26.3; `display-buffer-reuse-mode-window' doesn't check for derived modes
Date: Thu, 19 Dec 2019 12:37:40 -0800

The problem is in the middle of the function:

        (let ((mode?
               (with-current-buffer (window-buffer window)
                 (cond ((memq major-mode allowed-modes)
                        'same)
                       ((derived-mode-p allowed-modes) ; <= this line
                        'derived)))))
                        ...)

`allowed-modes' is always a list at this point, but `derived-mode-p'
expects each mode as a separated argument (it takes them with an &rest
parameter).  So this call always fails.
This bug report was last modified 4 years and 289 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.