GNU bug report logs - #38630
Software Heritage (swh): Fix API change, causing repeatedly submitting archives

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Björn Höfling
 <bjoern.hoefling <at> bjoernhoefling.de>
Subject: bug#38630: closed (Re: [bug#38630] Software Heritage (swh): Fix
 API change, causing repeatedly submitting archives)
Date: Tue, 17 Dec 2019 22:33:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#38630: Software Heritage (swh): Fix API change, causing repeatedly submitting archives

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 38630 <at> debbugs.gnu.org.

-- 
38630: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38630
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 38630-done <at> debbugs.gnu.org
Subject: Re: [bug#38630] Software Heritage (swh): Fix API change, causing
 repeatedly submitting archives
Date: Tue, 17 Dec 2019 23:32:40 +0100

[Message part 3 (text/plain, inline)]

On Tue, 17 Dec 2019 17:41:04 +0100
Ludovic Courtès <ludo <at> gnu.org> wrote:

> > I have not communicated with SWH about that, especially I have not
> > asked SWH why they broke the API without updating the version
> > number.  
> 
> Yeah, that’s weird, I’ve pinged them on IRC.
> 
> It seems that the removal was intentional as part of
> <https://forge.softwareheritage.org/D2167>, but it wasn’t clear
> whether the API breakage should have happened.  This led them to open
> a new task: <https://forge.softwareheritage.org/T2158>.  We should
> keep an eye on it.

I will be frequently linting and see what's happening :-)

[..]

> In the meantime, your patch looks like the right move, so you can
> push it.

Thanks for your review and further information, pushed as

356a79becc4061d158c68718ad169abac1ab672f

Closing this ticket.

Björn

[Message part 4 (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: <guix-patches <at> gnu.org>
Subject: Software Heritage (swh): Fix API change, causing repeatedly
 submitting archives
Date: Sun, 15 Dec 2019 22:34:33 +0100

[Message part 6 (text/plain, inline)]

Hi Guix,

when linting, I recognized that the archival linter was repeatedly
sending packages to the SWH, despite that the package was already
archived.

With some investigations, I noticed they changed the API. Here's a
patch that fixes it.

I have not communicated with SWH about that, especially I have not asked
SWH why they broke the API without updating the version number.

Björn

[0001-swh-Fix-API-call-for-getting-origin.patch (text/x-patch, attachment)]

[Message part 8 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.