GNU bug report logs - #38630
Software Heritage (swh): Fix API change, causing repeatedly submitting archives

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38630 in the body.
You can then email your comments to 38630 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: <guix-patches <at> gnu.org>
Subject: Software Heritage (swh): Fix API change, causing repeatedly
 submitting archives
Date: Sun, 15 Dec 2019 22:34:33 +0100

[Message part 1 (text/plain, inline)]

Hi Guix,

when linting, I recognized that the archival linter was repeatedly
sending packages to the SWH, despite that the package was already
archived.

With some investigations, I noticed they changed the API. Here's a
patch that fixes it.

I have not communicated with SWH about that, especially I have not asked
SWH why they broke the API without updating the version number.

Björn

[0001-swh-Fix-API-call-for-getting-origin.patch (text/x-patch, attachment)]

[Message part 3 (application/pgp-signature, inline)]

Message #8 received at 38630 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
Cc: 38630 <at> debbugs.gnu.org
Subject: Re: [bug#38630] Software Heritage (swh): Fix API change,
 causing repeatedly submitting archives
Date: Tue, 17 Dec 2019 17:41:04 +0100

Hello!

Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de> skribis:

> when linting, I recognized that the archival linter was repeatedly
> sending packages to the SWH, despite that the package was already
> archived.
>
> With some investigations, I noticed they changed the API. Here's a
> patch that fixes it.

Good catch!

> I have not communicated with SWH about that, especially I have not asked
> SWH why they broke the API without updating the version number.

Yeah, that’s weird, I’ve pinged them on IRC.

It seems that the removal was intentional as part of
<https://forge.softwareheritage.org/D2167>, but it wasn’t clear whether
the API breakage should have happened.  This led them to open a new
task: <https://forge.softwareheritage.org/T2158>.  We should keep an eye
on it.

> From a5ada85d168b45d517d8faf0d79ad5beccc26911 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Bj=C3=B6rn=20H=C3=B6fling?=
>  <bjoern.hoefling <at> bjoernhoefling.de>
> Date: Sun, 15 Dec 2019 22:00:56 +0100
> Subject: [PATCH] swh: Fix API call for getting origin.
>
> When using the archival linter, git origins already in the archive where
> not recognized due to an API change and where repeatedly asked for archival.
> This is fixed here.
>
> * guix/swh.scm (lookup-origin): Fix API URI for getting origin.
> (<origin>): Fix comment with API URI example.

In the meantime, your patch looks like the right move, so you can push it.

Thank you!

Ludo’.

Message #13 received at 38630-done <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 38630-done <at> debbugs.gnu.org
Subject: Re: [bug#38630] Software Heritage (swh): Fix API change, causing
 repeatedly submitting archives
Date: Tue, 17 Dec 2019 23:32:40 +0100

[Message part 1 (text/plain, inline)]

On Tue, 17 Dec 2019 17:41:04 +0100
Ludovic Courtès <ludo <at> gnu.org> wrote:

> > I have not communicated with SWH about that, especially I have not
> > asked SWH why they broke the API without updating the version
> > number.  
> 
> Yeah, that’s weird, I’ve pinged them on IRC.
> 
> It seems that the removal was intentional as part of
> <https://forge.softwareheritage.org/D2167>, but it wasn’t clear
> whether the API breakage should have happened.  This led them to open
> a new task: <https://forge.softwareheritage.org/T2158>.  We should
> keep an eye on it.

I will be frequently linting and see what's happening :-)

[..]

> In the meantime, your patch looks like the right move, so you can
> push it.

Thanks for your review and further information, pushed as

356a79becc4061d158c68718ad169abac1ab672f

Closing this ticket.

Björn

[Message part 2 (application/pgp-signature, inline)]

Message #16 received at 38630 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: 38630 <at> debbugs.gnu.org, bjoern.hoefling <at> bjoernhoefling.de
Subject: Re: bug#38630: Software Heritage (swh): Fix API change, causing
 repeatedly submitting archives
Date: Wed, 18 Dec 2019 10:22:27 +0100

On 17.12.19 23:32, Björn Höfling wrote:
> Thanks for your review and further information, pushed as
>
> 356a79becc4061d158c68718ad169abac1ab672f
>
> Closing this ticket.

I guess the "origin//" in the comment should be "origin/" :)

Message #19 received at 38630-done <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Cc: 38630-done <at> debbugs.gnu.org
Subject: Re: bug#38630: Software Heritage (swh): Fix API change, causing
 repeatedly submitting archives
Date: Wed, 18 Dec 2019 22:44:59 +0100

[Message part 1 (text/plain, inline)]

On Wed, 18 Dec 2019 10:22:27 +0100
Jonathan Brielmaier <jonathan.brielmaier <at> web.de> wrote:

> On 17.12.19 23:32, Björn Höfling wrote:
> > Thanks for your review and further information, pushed as
> >
> > 356a79becc4061d158c68718ad169abac1ab672f
> >
> > Closing this ticket.  
> 
> I guess the "origin//" in the comment should be "origin/" :)

Hi Jonathan,

thanks for that hint, fixed in:

6afea7489b76c8db58d4f389fdbedc7c2b8992bd

Björn

[Message part 2 (application/pgp-signature, inline)]

Message #22 received at 38630-done <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
Cc: 38630-done <at> debbugs.gnu.org
Subject: Re: bug#38630: Software Heritage (swh): Fix API change, causing
 repeatedly submitting archives
Date: Fri, 20 Dec 2019 01:48:11 +0100

On 18.12.19 22:44, Björn Höfling wrote:
> On Wed, 18 Dec 2019 10:22:27 +0100
> Jonathan Brielmaier <jonathan.brielmaier <at> web.de> wrote:
>
>> On 17.12.19 23:32, Björn Höfling wrote:
>>> Thanks for your review and further information, pushed as
>>>
>>> 356a79becc4061d158c68718ad169abac1ab672f
>>>
>>> Closing this ticket.
>>
>> I guess the "origin//" in the comment should be "origin/" :)
>
> Hi Jonathan,
>
> thanks for that hint, fixed in:
>
> 6afea7489b76c8db58d4f389fdbedc7c2b8992bd

Now we lost the h in https, but it's only a comment so not really
important :)

Message #25 received at 38630-done <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Mark H Weaver <mhw <at> netris.org>
Cc: 38630-done <at> debbugs.gnu.org,
 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Re: guix: swh: Fix example URI in comment for <origin>.
Date: Thu, 26 Dec 2019 00:27:23 +0100

[Message part 1 (text/plain, inline)]

Hi Mark and Jonathan,

On Wed, 18 Dec 2019 21:42:38 -0500
Mark H Weaver <mhw <at> netris.org> wrote:

> Hi Björn,
> 
> Your recent commit 6afea7489b76c8db58d4f389fdbedc7c2b8992bd is
> erroneous.  It claims to remove a slash from an example URI, but it
> actually removed both a slash and the 'h' from 'https'.  See the diff
> below.

What a shame. Thanks for looking into the details.

I hope that:

e507d30c482cf018b44e70931a6153e5d3ea93f1

is the last in that series :-)

Björn

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.