GNU bug report logs - #38596
[PATCH] Add PureScript

Previous Next

Full log

View this message in rfc822 format

From: John Soo <jsoo1 <at> asu.edu>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 38596 <at> debbugs.gnu.org
Subject: [bug#38596] [PATCH] gnu: Add PureScript.
Date: Sat, 18 Apr 2020 15:31:43 -0700

[Message part 1 (text/plain, inline)]

Hi,

Christopher Baines <mail <at> cbaines.net> writes:

> I've had an initial look through these now, sorry it's taken so long!

No problem. I was thinking I ought to do some qa and review, myself.

> ghc-utf8-light could do with a better description, something a little
> more informative.

I think I made this better as well as fixing some other descriptions
lacking full sentences.

> The ghc-sourcemap and ghc-mtl-compat tests are disabled, it would be
> good to at least add a comments as to why.

I added a comment for sourcemap. I realized mtl-compat's tests and
haddocks worked just fine so those are re-enabled.

> The ghc-protolude synopsis could potentially be more informative.

I think I added some more commentary there. It's a bit tricky since I
have not used protolude myself so I am not sure what to provide aside
from their stated description.

> I think adding specific versions of dependencies for purescript is OK,
> but only if they're justified, like if the package only builds with that
> version. The justification should also be noted in the purescript
> package description.

Ah, thanks. Would a comment above the dependencies suffice? The packages
won't be searchable since they are not define-public (yet?).


> I don't think it's necessary to go through all the custom versions of
> packages you've added, but it would be good to at least see if there's
> one case where the upstream specification is overly strict, and the
> slightly different version from Guix would work. That at least would
> provide an example of how to override versions going forward.

Ah thanks for the suggestion here. I found one that could be taken from
the existing package in (gnu packages haskell-xyz). The rest seemed to
be either pinned exactly or too strict to take from guix packages.

Thanks for your help and tools!

John

[0001-gnu-Add-ghc-utf8-light.patch (text/x-patch, attachment)]

[0002-gnu-Add-ghc-transformers.patch (text/x-patch, attachment)]

[0003-gnu-Add-ghc-tasty-hspec.patch (text/x-patch, attachment)]

[0004-gnu-Add-ghc-websockets.patch (text/x-patch, attachment)]

[0005-gnu-Add-ghc-wai-websockets.patch (text/x-patch, attachment)]

[0006-gnu-Add-ghc-sourcemap.patch (text/x-patch, attachment)]

[0007-gnu-Add-ghc-mtl-compat.patch (text/x-patch, attachment)]

[0008-gnu-Add-ghc-protolude.patch (text/x-patch, attachment)]

[0009-gnu-Add-ghc-pattern-arrows.patch (text/x-patch, attachment)]

[0010-gnu-Add-ghc-language-javascript.patch (text/x-patch, attachment)]

[0011-gnu-Add-ghc-bower-json.patch (text/x-patch, attachment)]

[0012-gnu-Add-ghc-aeson-better-errors.patch (text/x-patch, attachment)]

[0013-gnu-Add-ghc-assoc.patch (text/x-patch, attachment)]

[0014-gnu-Add-ghc-these.patch (text/x-patch, attachment)]

[0015-gnu-Add-ghc-semialign.patch (text/x-patch, attachment)]

[0016-gnu-Add-ghc-happy-1.19.9.patch (text/x-patch, attachment)]

[0017-gnu-Add-ghc-clock-0.7.2.patch (text/x-patch, attachment)]

[0018-gnu-Add-ghc-glob-0.9.3.patch (text/x-patch, attachment)]

[0019-gnu-Add-ghc-ansi-terminal-0.8.2.patch (text/x-patch, attachment)]

[0020-gnu-Add-ghc-network-3.0.1.1.patch (text/x-patch, attachment)]

[0021-gnu-Add-purescript.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.