GNU bug report logs - #38596
[PATCH] Add PureScript

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38596 in the body.
You can then email your comments to 38596 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add PureScript
Date: Fri, 13 Dec 2019 18:46:33 +0000

[Message part 1 (text/plain, inline)]

Hi Guix,

Here are my patches for PureScript, a haskell inspired language that
compiles to JavaScript.

I took all dependencies with the exception of one from stackage lts14.

The exception is language-javascript. What do I do about that?

There were a few more dependencies that are not in the stackage lts, but I
did not make them publically available and placed them in purescript.scm.

I did a lint and fixed most of the errors I could and built with --rounds=2
--check.

Thanks!

John

[Message part 2 (text/html, inline)]

[0001-gnu-Add-ghc-utf8-light.patch (text/x-patch, attachment)]

[0002-gnu-Add-ghc-transformers.patch (text/x-patch, attachment)]

[0005-gnu-Add-ghc-wai-websockets.patch (text/x-patch, attachment)]

[0004-gnu-Add-ghc-websockets.patch (text/x-patch, attachment)]

[0003-gnu-Add-ghc-tasty-hspec.patch (text/x-patch, attachment)]

[0006-gnu-Add-ghc-sourcemap.patch (text/x-patch, attachment)]

[0007-gnu-Add-ghc-mtl-compat.patch (text/x-patch, attachment)]

[0008-gnu-Add-ghc-protolude.patch (text/x-patch, attachment)]

[0009-gnu-Add-ghc-pattern-arrows.patch (text/x-patch, attachment)]

[0010-gnu-Add-ghc-language-javascript.patch (text/x-patch, attachment)]

[0011-gnu-Add-ghc-bower-json.patch (text/x-patch, attachment)]

[0013-gnu-Add-ghc-assoc.patch (text/x-patch, attachment)]

[0015-gnu-Add-ghc-semialign.patch (text/x-patch, attachment)]

[0014-gnu-Add-ghc-these.patch (text/x-patch, attachment)]

[0012-gnu-Add-ghc-aeson-better-errors.patch (text/x-patch, attachment)]

[0016-gnu-Add-ghc-happy-1.19.9.patch (text/x-patch, attachment)]

[0017-gnu-Add-ghc-clock-0.7.2.patch (text/x-patch, attachment)]

[0018-gnu-Add-ghc-glob-0.9.3.patch (text/x-patch, attachment)]

[0019-gnu-Add-ghc-ansi-terminal-0.8.2.patch (text/x-patch, attachment)]

[0020-gnu-Add-ghc-lifted-async-0.10.0.4.patch (text/x-patch, attachment)]

[0022-gnu-Add-purescript.patch (text/x-patch, attachment)]

[0021-gnu-Add-ghc-network-3.0.1.1.patch (text/x-patch, attachment)]

Message #8 received at 38596 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: 38596 <at> debbugs.gnu.org, Brett Gilio <brettg <at> posteo.net>
Subject: [PATCH] Add PureScript
Date: Wed, 18 Dec 2019 13:50:41 +0000

[Message part 1 (text/plain, inline)]

Hi all,

I realized I had a typo in the final patch.

Here are my updated patches.

- John

[Message part 2 (text/html, inline)]

[0001-gnu-Add-ghc-utf8-light.patch (text/x-patch, attachment)]

[0003-gnu-Add-ghc-tasty-hspec.patch (text/x-patch, attachment)]

[0002-gnu-Add-ghc-transformers.patch (text/x-patch, attachment)]

[0004-gnu-Add-ghc-websockets.patch (text/x-patch, attachment)]

[0005-gnu-Add-ghc-wai-websockets.patch (text/x-patch, attachment)]

[0006-gnu-Add-ghc-sourcemap.patch (text/x-patch, attachment)]

[0007-gnu-Add-ghc-mtl-compat.patch (text/x-patch, attachment)]

[0009-gnu-Add-ghc-pattern-arrows.patch (text/x-patch, attachment)]

[0010-gnu-Add-ghc-language-javascript.patch (text/x-patch, attachment)]

[0008-gnu-Add-ghc-protolude.patch (text/x-patch, attachment)]

[0011-gnu-Add-ghc-bower-json.patch (text/x-patch, attachment)]

[0012-gnu-Add-ghc-aeson-better-errors.patch (text/x-patch, attachment)]

[0013-gnu-Add-ghc-assoc.patch (text/x-patch, attachment)]

[0014-gnu-Add-ghc-these.patch (text/x-patch, attachment)]

[0015-gnu-Add-ghc-semialign.patch (text/x-patch, attachment)]

[0017-gnu-Add-ghc-clock-0.7.2.patch (text/x-patch, attachment)]

[0018-gnu-Add-ghc-glob-0.9.3.patch (text/x-patch, attachment)]

[0016-gnu-Add-ghc-happy-1.19.9.patch (text/x-patch, attachment)]

[0019-gnu-Add-ghc-ansi-terminal-0.8.2.patch (text/x-patch, attachment)]

[0020-gnu-Add-ghc-lifted-async-0.10.0.4.patch (text/x-patch, attachment)]

[0021-gnu-Add-ghc-network-3.0.1.1.patch (text/x-patch, attachment)]

[0022-gnu-Add-purescript.patch (text/x-patch, attachment)]

Message #11 received at 38596 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: 38596 <at> debbugs.gnu.org, Brett Gilio <brettg <at> posteo.net>
Subject: [PATCH] Add PureScript
Date: Wed, 18 Dec 2019 14:30:06 +0000

[Message part 1 (text/plain, inline)]

Hi all,

I realized I made one final mistake. Here are the fixed patches.

- John

[Message part 2 (text/html, inline)]

[0002-gnu-Add-ghc-transformers.patch (text/x-patch, attachment)]

[0004-gnu-Add-ghc-websockets.patch (text/x-patch, attachment)]

[0003-gnu-Add-ghc-tasty-hspec.patch (text/x-patch, attachment)]

[0001-gnu-Add-ghc-utf8-light.patch (text/x-patch, attachment)]

[0005-gnu-Add-ghc-wai-websockets.patch (text/x-patch, attachment)]

[0007-gnu-Add-ghc-mtl-compat.patch (text/x-patch, attachment)]

[0008-gnu-Add-ghc-protolude.patch (text/x-patch, attachment)]

[0009-gnu-Add-ghc-pattern-arrows.patch (text/x-patch, attachment)]

[0006-gnu-Add-ghc-sourcemap.patch (text/x-patch, attachment)]

[0010-gnu-Add-ghc-language-javascript.patch (text/x-patch, attachment)]

[0013-gnu-Add-ghc-assoc.patch (text/x-patch, attachment)]

[0011-gnu-Add-ghc-bower-json.patch (text/x-patch, attachment)]

[0012-gnu-Add-ghc-aeson-better-errors.patch (text/x-patch, attachment)]

[0015-gnu-Add-ghc-semialign.patch (text/x-patch, attachment)]

[0014-gnu-Add-ghc-these.patch (text/x-patch, attachment)]

[0016-gnu-Add-ghc-happy-1.19.9.patch (text/x-patch, attachment)]

[0019-gnu-Add-ghc-ansi-terminal-0.8.2.patch (text/x-patch, attachment)]

[0017-gnu-Add-ghc-clock-0.7.2.patch (text/x-patch, attachment)]

[0020-gnu-Add-ghc-lifted-async-0.10.0.4.patch (text/x-patch, attachment)]

[0018-gnu-Add-ghc-glob-0.9.3.patch (text/x-patch, attachment)]

[0021-gnu-Add-ghc-network-3.0.1.1.patch (text/x-patch, attachment)]

[0022-gnu-Add-purescript.patch (text/x-patch, attachment)]

Message #14 received at 38596 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: 38596 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add PureScript.
Date: Sat, 11 Apr 2020 13:12:08 -0700

[Message part 1 (text/plain, inline)]

Hi Guix,

I rebased these patches on master.

Thanks!

John

[0001-gnu-Add-ghc-utf8-light.patch (text/x-patch, attachment)]

[0002-gnu-Add-ghc-transformers.patch (text/x-patch, attachment)]

[0003-gnu-Add-ghc-tasty-hspec.patch (text/x-patch, attachment)]

[0004-gnu-Add-ghc-websockets.patch (text/x-patch, attachment)]

[0005-gnu-Add-ghc-wai-websockets.patch (text/x-patch, attachment)]

[0006-gnu-Add-ghc-sourcemap.patch (text/x-patch, attachment)]

[0007-gnu-Add-ghc-mtl-compat.patch (text/x-patch, attachment)]

[0008-gnu-Add-ghc-protolude.patch (text/x-patch, attachment)]

[0009-gnu-Add-ghc-pattern-arrows.patch (text/x-patch, attachment)]

[0010-gnu-Add-ghc-language-javascript.patch (text/x-patch, attachment)]

[0011-gnu-Add-ghc-bower-json.patch (text/x-patch, attachment)]

[0012-gnu-Add-ghc-aeson-better-errors.patch (text/x-patch, attachment)]

[0013-gnu-Add-ghc-assoc.patch (text/x-patch, attachment)]

[0014-gnu-Add-ghc-these.patch (text/x-patch, attachment)]

[0015-gnu-Add-ghc-semialign.patch (text/x-patch, attachment)]

[0016-gnu-Add-ghc-happy-1.19.9.patch (text/x-patch, attachment)]

[0017-gnu-Add-ghc-clock-0.7.2.patch (text/x-patch, attachment)]

[0018-gnu-Add-ghc-glob-0.9.3.patch (text/x-patch, attachment)]

[0019-gnu-Add-ghc-ansi-terminal-0.8.2.patch (text/x-patch, attachment)]

[0020-gnu-Add-ghc-lifted-async-0.10.0.4.patch (text/x-patch, attachment)]

[0021-gnu-Add-ghc-network-3.0.1.1.patch (text/x-patch, attachment)]

[0022-gnu-Add-purescript.patch (text/x-patch, attachment)]

Message #17 received at 38596 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 38596 <at> debbugs.gnu.org
Subject: Re: [bug#38596] [PATCH] gnu: Add PureScript.
Date: Fri, 17 Apr 2020 20:21:58 +0100

[Message part 1 (text/plain, inline)]

John Soo <jsoo1 <at> asu.edu> writes:

> Hi Guix,
>
> I rebased these patches on master.

Hi John,

I've had an initial look through these now, sorry it's taken so long!

I think the patches are pretty much good to merge, but I do have a few
comments.

ghc-utf8-light could do with a better description, something a little
more informative.

The ghc-sourcemap and ghc-mtl-compat tests are disabled, it would be
good to at least add a comments as to why.

The ghc-protolude synopsis could potentially be more informative.

I think adding specific versions of dependencies for purescript is OK,
but only if they're justified, like if the package only builds with that
version. The justification should also be noted in the purescript
package description.

I don't think it's necessary to go through all the custom versions of
packages you've added, but it would be good to at least see if there's
one case where the upstream specification is overly strict, and the
slightly different version from Guix would work. That at least would
provide an example of how to override versions going forward.

Let me know what you think, thanks again,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 38596 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 38596 <at> debbugs.gnu.org
Subject: Re: [bug#38596] [PATCH] gnu: Add PureScript.
Date: Sat, 18 Apr 2020 15:31:43 -0700

[Message part 1 (text/plain, inline)]

Hi,

Christopher Baines <mail <at> cbaines.net> writes:

> I've had an initial look through these now, sorry it's taken so long!

No problem. I was thinking I ought to do some qa and review, myself.

> ghc-utf8-light could do with a better description, something a little
> more informative.

I think I made this better as well as fixing some other descriptions
lacking full sentences.

> The ghc-sourcemap and ghc-mtl-compat tests are disabled, it would be
> good to at least add a comments as to why.

I added a comment for sourcemap. I realized mtl-compat's tests and
haddocks worked just fine so those are re-enabled.

> The ghc-protolude synopsis could potentially be more informative.

I think I added some more commentary there. It's a bit tricky since I
have not used protolude myself so I am not sure what to provide aside
from their stated description.

> I think adding specific versions of dependencies for purescript is OK,
> but only if they're justified, like if the package only builds with that
> version. The justification should also be noted in the purescript
> package description.

Ah, thanks. Would a comment above the dependencies suffice? The packages
won't be searchable since they are not define-public (yet?).


> I don't think it's necessary to go through all the custom versions of
> packages you've added, but it would be good to at least see if there's
> one case where the upstream specification is overly strict, and the
> slightly different version from Guix would work. That at least would
> provide an example of how to override versions going forward.

Ah thanks for the suggestion here. I found one that could be taken from
the existing package in (gnu packages haskell-xyz). The rest seemed to
be either pinned exactly or too strict to take from guix packages.

Thanks for your help and tools!

John

[0001-gnu-Add-ghc-utf8-light.patch (text/x-patch, attachment)]

[0002-gnu-Add-ghc-transformers.patch (text/x-patch, attachment)]

[0003-gnu-Add-ghc-tasty-hspec.patch (text/x-patch, attachment)]

[0004-gnu-Add-ghc-websockets.patch (text/x-patch, attachment)]

[0005-gnu-Add-ghc-wai-websockets.patch (text/x-patch, attachment)]

[0006-gnu-Add-ghc-sourcemap.patch (text/x-patch, attachment)]

[0007-gnu-Add-ghc-mtl-compat.patch (text/x-patch, attachment)]

[0008-gnu-Add-ghc-protolude.patch (text/x-patch, attachment)]

[0009-gnu-Add-ghc-pattern-arrows.patch (text/x-patch, attachment)]

[0010-gnu-Add-ghc-language-javascript.patch (text/x-patch, attachment)]

[0011-gnu-Add-ghc-bower-json.patch (text/x-patch, attachment)]

[0012-gnu-Add-ghc-aeson-better-errors.patch (text/x-patch, attachment)]

[0013-gnu-Add-ghc-assoc.patch (text/x-patch, attachment)]

[0014-gnu-Add-ghc-these.patch (text/x-patch, attachment)]

[0015-gnu-Add-ghc-semialign.patch (text/x-patch, attachment)]

[0016-gnu-Add-ghc-happy-1.19.9.patch (text/x-patch, attachment)]

[0017-gnu-Add-ghc-clock-0.7.2.patch (text/x-patch, attachment)]

[0018-gnu-Add-ghc-glob-0.9.3.patch (text/x-patch, attachment)]

[0019-gnu-Add-ghc-ansi-terminal-0.8.2.patch (text/x-patch, attachment)]

[0020-gnu-Add-ghc-network-3.0.1.1.patch (text/x-patch, attachment)]

[0021-gnu-Add-purescript.patch (text/x-patch, attachment)]

Message #23 received at 38596 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 38596 <at> debbugs.gnu.org
Subject: Re: [bug#38596] [PATCH] gnu: Add PureScript.
Date: Tue, 21 Apr 2020 08:55:37 +0100

[Message part 1 (text/plain, inline)]

John Soo <jsoo1 <at> asu.edu> writes:

> Christopher Baines <mail <at> cbaines.net> writes:
>
>> I've had an initial look through these now, sorry it's taken so long!
>
> No problem. I was thinking I ought to do some qa and review, myself.
>
>> ghc-utf8-light could do with a better description, something a little
>> more informative.
>
> I think I made this better as well as fixing some other descriptions
> lacking full sentences.

Great :)

>> The ghc-sourcemap and ghc-mtl-compat tests are disabled, it would be
>> good to at least add a comments as to why.
>
> I added a comment for sourcemap. I realized mtl-compat's tests and
> haddocks worked just fine so those are re-enabled.

Cool.

>> The ghc-protolude synopsis could potentially be more informative.
>
> I think I added some more commentary there. It's a bit tricky since I
> have not used protolude myself so I am not sure what to provide aside
> from their stated description.

Sure, I think it's fine now.

Some really minor description things I missed earlier:

ghc-aeson-better-errors, ghc-transformers and ghc-websockets have URLs
in the description, @url could probably be used.

I'd also remove the following from the ghc-bower-json description, it
reads more like uninformative advertising to me and isn't really
relevant to this specific package:

  Bower is a package manager for the web (see http://bower.io).

>> I think adding specific versions of dependencies for purescript is OK,
>> but only if they're justified, like if the package only builds with that
>> version. The justification should also be noted in the purescript
>> package description.
>
> Ah, thanks. Would a comment above the dependencies suffice? The packages
> won't be searchable since they are not define-public (yet?).

Maybe it would be good to note why the package in Guix didn't work, like
I tried to use ghc-happy <at> 1.19.12, and the build phase failed with some
type errors. That'll at least point out clearly that there's an
incompatability. I don't think much detail is needed, the following
would be fine.

     `(("ghc-happy" ,ghc-happy-1.19.9)  ; build fails with 1.19.12

>> I don't think it's necessary to go through all the custom versions of
>> packages you've added, but it would be good to at least see if there's
>> one case where the upstream specification is overly strict, and the
>> slightly different version from Guix would work. That at least would
>> provide an example of how to override versions going forward.
>
> Ah thanks for the suggestion here. I found one that could be taken from
> the existing package in (gnu packages haskell-xyz). The rest seemed to
> be either pinned exactly or too strict to take from guix packages.

Thanks, although my intent was more about adding something like this.

  #:phases
  (modify-phases %standard-phases
    (add-after 'unpack 'patch
      (lambda _
        (substitute* "purescript.cabal"
          (("clock .*$")
           "clock,\n"))
        #t)))))


Now I'm not sure quite how risky this is, the purescript tests aren't
being run, but given this is Haskell and it compiles, hopefully that
provides some guarantees.

What do you think?

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 38596 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 38596 <at> debbugs.gnu.org
Subject: Re: [bug#38596] [PATCH] gnu: Add PureScript.
Date: Thu, 07 May 2020 17:32:18 -0700

[Message part 1 (text/plain, inline)]

Hello,

Christopher Baines <mail <at> cbaines.net> writes:

> Some really minor description things I missed earlier:
>
> ghc-aeson-better-errors, ghc-transformers and ghc-websockets have URLs
> in the description, @url could probably be used.
>
> I'd also remove the following from the ghc-bower-json description, it
> reads more like uninformative advertising to me and isn't really
> relevant to this specific package:
>
>   Bower is a package manager for the web (see http://bower.io).

Done!

> Maybe it would be good to note why the package in Guix didn't work, like
> I tried to use ghc-happy <at> 1.19.12, and the build phase failed with some
> type errors. That'll at least point out clearly that there's an
> incompatability. I don't think much detail is needed, the following
> would be fine.
>
>      `(("ghc-happy" ,ghc-happy-1.19.9)  ; build fails with 1.19.12

Done!

>> Ah thanks for the suggestion here. I found one that could be taken from
>> the existing package in (gnu packages haskell-xyz). The rest seemed to
>> be either pinned exactly or too strict to take from guix packages.
>
> Thanks, although my intent was more about adding something like this.
>
>   #:phases
>   (modify-phases %standard-phases
>     (add-after 'unpack 'patch
>       (lambda _
>         (substitute* "purescript.cabal"
>           (("clock .*$")
>            "clock,\n"))
>         #t)))))

With the addition of a patch I was able to relax most of the package
versions I introduced to ones we have. The final remaining required
dependency seems to be happy which I kept at 1.19.9.

> Now I'm not sure quite how risky this is, the purescript tests aren't
> being run, but given this is Haskell and it compiles, hopefully that
> provides some guarantees.
>
> What do you think?

My only caveat too is now I have not really tested this version. I had
done some work with a prior version.  I wish I could run the tests but
they seem to rely heavily on npm and bower.

Thanks again,

John

[0001-gnu-Add-ghc-utf8-light.patch (text/x-patch, attachment)]

[0002-gnu-Add-ghc-transformers.patch (text/x-patch, attachment)]

[0003-gnu-Add-ghc-tasty-hspec.patch (text/x-patch, attachment)]

[0004-gnu-Add-ghc-websockets.patch (text/x-patch, attachment)]

[0005-gnu-Add-ghc-wai-websockets.patch (text/x-patch, attachment)]

[0006-gnu-Add-ghc-sourcemap.patch (text/x-patch, attachment)]

[0007-gnu-Add-ghc-mtl-compat.patch (text/x-patch, attachment)]

[0008-gnu-Add-ghc-protolude.patch (text/x-patch, attachment)]

[0009-gnu-Add-ghc-pattern-arrows.patch (text/x-patch, attachment)]

[0010-gnu-Add-ghc-language-javascript.patch (text/x-patch, attachment)]

[0011-gnu-Add-ghc-bower-json.patch (text/x-patch, attachment)]

[0012-gnu-Add-ghc-aeson-better-errors.patch (text/x-patch, attachment)]

[0013-gnu-Add-ghc-assoc.patch (text/x-patch, attachment)]

[0014-gnu-Add-ghc-these.patch (text/x-patch, attachment)]

[0015-gnu-Add-ghc-semialign.patch (text/x-patch, attachment)]

[0016-gnu-Add-ghc-happy-1.19.9.patch (text/x-patch, attachment)]

[0017-gnu-Add-purescript.patch (text/x-patch, attachment)]

Message #31 received at 38596-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 38596-done <at> debbugs.gnu.org
Subject: Re: [bug#38596] [PATCH] gnu: Add PureScript.
Date: Fri, 08 May 2020 10:13:25 +0100

[Message part 1 (text/plain, inline)]

John Soo <jsoo1 <at> asu.edu> writes:

> Christopher Baines <mail <at> cbaines.net> writes:
>
>> Some really minor description things I missed earlier:
>>
>> ghc-aeson-better-errors, ghc-transformers and ghc-websockets have URLs
>> in the description, @url could probably be used.
>>
>> I'd also remove the following from the ghc-bower-json description, it
>> reads more like uninformative advertising to me and isn't really
>> relevant to this specific package:
>>
>>   Bower is a package manager for the web (see http://bower.io).
>
> Done!
>
>> Maybe it would be good to note why the package in Guix didn't work, like
>> I tried to use ghc-happy <at> 1.19.12, and the build phase failed with some
>> type errors. That'll at least point out clearly that there's an
>> incompatability. I don't think much detail is needed, the following
>> would be fine.
>>
>>      `(("ghc-happy" ,ghc-happy-1.19.9)  ; build fails with 1.19.12
>
> Done!
>
>>> Ah thanks for the suggestion here. I found one that could be taken from
>>> the existing package in (gnu packages haskell-xyz). The rest seemed to
>>> be either pinned exactly or too strict to take from guix packages.
>>
>> Thanks, although my intent was more about adding something like this.
>>
>>   #:phases
>>   (modify-phases %standard-phases
>>     (add-after 'unpack 'patch
>>       (lambda _
>>         (substitute* "purescript.cabal"
>>           (("clock .*$")
>>            "clock,\n"))
>>         #t)))))
>
> With the addition of a patch I was able to relax most of the package
> versions I introduced to ones we have. The final remaining required
> dependency seems to be happy which I kept at 1.19.9.

Awesome. I added the patch to the list in gnu/local.mk, which I think is
necessary when building the guix package for guix at least. I also added
a small comment to the top of the patch.

>> Now I'm not sure quite how risky this is, the purescript tests aren't
>> being run, but given this is Haskell and it compiles, hopefully that
>> provides some guarantees.
>>
>> What do you think?
>
> My only caveat too is now I have not really tested this version. I had
> done some work with a prior version.  I wish I could run the tests but
> they seem to rely heavily on npm and bower.

Personally, I think that's fine for the moment. It builds at least and I
can run purs to at least get the help.

I've gone ahead and pushed these patches as
de488b3a5fff4535471f6706da03e1b74e6a37fd, thanks for all your work!

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.