GNU bug report logs - #38395
[PATCH] gnu: mumble: Update to 1.3.0.

Previous Next

Full log

Message #23 received at 38395 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Vilata i Balaguer <ivan <at> selidor.net>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 38395 <at> debbugs.gnu.org, Ivan Vilata i Balaguer <ivan <at> selidor.net>
Subject: Re: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to
 1.3.0.)
Date: Sun, 15 Dec 2019 20:44:11 -0500

[Message part 1 (text/plain, inline)]

Efraim Flashner (2019-12-05 11:02:36 +0200) wrote:

> With the 'staging' branch being merged into master the patch no longer
> cleanly applies.
> 
> Also, since you've removed a patch from the gnu/packages/patches folder
> you need to remove it also from gnu/local.mk. The two other things are
> the commit message doesn't list all of the changes and with the new
> qt-build-system that would probably be a better choice than wrapping the
> binaries yourself, but with an updated patch without that I can help
> work on that since it is such a new change.

Hi!  I'm attaching a reviewed set of patches.  The first patch updates the
original one to fix the copyright line (so it applies cleanly again), the
`local.mk` line removal and commit message completeness.  The second patch
adds the update to `qt-build-system`.  From the comments in
`guix/build-system/qt.scm` I gather that no other changes are missing, but I
may be wrong.

Thanks!

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

[0001-gnu-mumble-Update-to-1.3.0.patch (text/plain, attachment)]

[0002-gnu-mumble-Use-qt-build-system.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.