GNU bug report logs - #38395
[PATCH] gnu: mumble: Update to 1.3.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38395 in the body.
You can then email your comments to 38395 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ivan Vilata i Balaguer <ivan <at> selidor.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: mumble: Update to 1.3.0.
Date: Tue, 26 Nov 2019 20:40:38 -0500

[Message part 1 (text/plain, inline)]

Hi!  This patch updates Mumble to 1.3.0.  It came about as a fix to
<https://issues.guix.gnu.org/issue/38054>, but I'm posting it here directly
since fixing that issue was just a byproduct of the version update.

Notes from the patch comment indicating other differences with the previous
package version:

> Besides the update in itself, bundled software components are enabled as
> long as they are not already implemented in an existing package (in which
> case the package is used instead).  Some comments were added to indicate why
> bundled software components are kept or removed, why features are disabled,
> and the reason to include each license.

Cheers!

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

[0001-gnu-mumble-Update-to-1.3.0.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 38395 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Vilata i Balaguer <ivan <at> selidor.net>
To: 38395 <at> debbugs.gnu.org
Subject: Re: bug#38395: Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.)
Date: Wed, 4 Dec 2019 15:17:18 -0500

Is there anything still missing in the patch that I could work on for it to
get merged?  Thanks!

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
To: guix-patches <at> gnu.org
Cc: 38395 <at> debbugs.gnu.org
Subject: Re: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to
 1.3.0.)
Date: Wed, 04 Dec 2019 18:24:16 -0500

Ivan Vilata i Balaguer writes:

> Is there anything still missing in the patch that I could work on for it to
> get merged?  Thanks!

Hi!

I tried getting it to run but I ran into errors compiling it.  But then
I didn't get around to posting what they were to the list and something
else came up and I don't remember what they were. :\

I can see if I can find time to look again soon but I can't promise
anything.

Message #17 received at 38395 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Ivan Vilata i Balaguer <ivan <at> selidor.net>
Cc: 38395 <at> debbugs.gnu.org
Subject: Re: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to
 1.3.0.)
Date: Thu, 5 Dec 2019 11:02:36 +0200

[Message part 1 (text/plain, inline)]

On Wed, Dec 04, 2019 at 03:17:18PM -0500, Ivan Vilata i Balaguer wrote:
> Is there anything still missing in the patch that I could work on for it to
> get merged?  Thanks!
> 

With the 'staging' branch being merged into master the patch no longer
cleanly applies.

Also, since you've removed a patch from the gnu/packages/patches folder
you need to remove it also from gnu/local.mk. The two other things are
the commit message doesn't list all of the changes and with the new
qt-build-system that would probably be a better choice than wrapping the
binaries yourself, but with an updated patch without that I can help
work on that since it is such a new change.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 38395 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Vilata i Balaguer <ivan <at> selidor.net>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 38395 <at> debbugs.gnu.org, Ivan Vilata i Balaguer <ivan <at> selidor.net>
Subject: Re: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to
 1.3.0.)
Date: Fri, 6 Dec 2019 13:28:26 -0500

Efraim Flashner (2019-12-05 11:02:36 +0200) wrote:

> On Wed, Dec 04, 2019 at 03:17:18PM -0500, Ivan Vilata i Balaguer wrote:
> > Is there anything still missing in the patch that I could work on for it to
> > get merged?  Thanks!
> > 
> 
> With the 'staging' branch being merged into master the patch no longer
> cleanly applies.
> 
> Also, since you've removed a patch from the gnu/packages/patches folder
> you need to remove it also from gnu/local.mk. The two other things are
> the commit message doesn't list all of the changes and with the new
> qt-build-system that would probably be a better choice than wrapping the
> binaries yourself, but with an updated patch without that I can help
> work on that since it is such a new change.

Thanks Efraim for the info!  I don't think I'll have time to work on this
during the next week, but I'll try again ASAP and get back to you.

Cheers,

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

Message #23 received at 38395 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Vilata i Balaguer <ivan <at> selidor.net>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 38395 <at> debbugs.gnu.org, Ivan Vilata i Balaguer <ivan <at> selidor.net>
Subject: Re: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to
 1.3.0.)
Date: Sun, 15 Dec 2019 20:44:11 -0500

[Message part 1 (text/plain, inline)]

Efraim Flashner (2019-12-05 11:02:36 +0200) wrote:

> With the 'staging' branch being merged into master the patch no longer
> cleanly applies.
> 
> Also, since you've removed a patch from the gnu/packages/patches folder
> you need to remove it also from gnu/local.mk. The two other things are
> the commit message doesn't list all of the changes and with the new
> qt-build-system that would probably be a better choice than wrapping the
> binaries yourself, but with an updated patch without that I can help
> work on that since it is such a new change.

Hi!  I'm attaching a reviewed set of patches.  The first patch updates the
original one to fix the copyright line (so it applies cleanly again), the
`local.mk` line removal and commit message completeness.  The second patch
adds the update to `qt-build-system`.  From the comments in
`guix/build-system/qt.scm` I gather that no other changes are missing, but I
may be wrong.

Thanks!

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

[0001-gnu-mumble-Update-to-1.3.0.patch (text/plain, attachment)]

[0002-gnu-mumble-Use-qt-build-system.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 38395-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Ivan Vilata i Balaguer <ivan <at> selidor.net>
Cc: 38054-done <at> debbugs.gnu.org, 38395-done <at> debbugs.gnu.org
Subject: Re: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to
 1.3.0.)
Date: Thu, 19 Dec 2019 15:03:11 +0200

[Message part 1 (text/plain, inline)]

I merged the two patches together, made sure all the phases returned #t
and flushed out the commit message some more.


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #31 received at 38395-done <at> debbugs.gnu.org (full text, mbox):

From: Ivan Vilata i Balaguer <ivan <at> selidor.net>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 38054-done <at> debbugs.gnu.org, 38395-done <at> debbugs.gnu.org,
 Ivan Vilata i Balaguer <ivan <at> selidor.net>
Subject: Re: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to
 1.3.0.)
Date: Thu, 19 Dec 2019 11:51:55 -0500

Efraim Flashner (2019-12-19 15:03:11 +0200) wrote:

> I merged the two patches together, made sure all the phases returned #t
> and flushed out the commit message some more.

Thanks a lot!  Comparing your final patch against mine was also very
instructive. `:)`

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

Message #34 received at 38395-done <at> debbugs.gnu.org (full text, mbox):

From: Ivan Vilata i Balaguer <ivan <at> selidor.net>
To: Ivan Vilata i Balaguer <ivan <at> selidor.net>
Cc: 38054-done <at> debbugs.gnu.org, 38395-done <at> debbugs.gnu.org,
 Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to
 1.3.0.)
Date: Fri, 20 Dec 2019 11:07:58 -0500

Ivan Vilata i Balaguer (2019-12-19 11:51:55 -0500) wrote:

> Efraim Flashner (2019-12-19 15:03:11 +0200) wrote:
> 
> > I merged the two patches together, made sure all the phases returned #t
> > and flushed out the commit message some more.
> 
> Thanks a lot!  Comparing your final patch against mine was also very
> instructive. `:)`

Before you close this issue, I upgraded my `mumble` package and many icons are
missing.  I didn't yet have time to further investigate it, but maybe it's
because of a difference I noticed between your patch:

    (modify-phases %standard-phases

and mine:

    (modify-phases (@ (guix build qt-build-system) %standard-phases)

So maybe the problem is that the final, wrapping phase of `qt-build-system` is
not being run.  Actually I see that `mumble` is a plain binary while in the
output from my patch, it was a wrapper script.

Thanks!

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

Message #37 received at 38395-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Ivan Vilata i Balaguer <ivan <at> selidor.net>
Cc: 38054-done <at> debbugs.gnu.org, 38395-done <at> debbugs.gnu.org
Subject: Re: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to
 1.3.0.)
Date: Sun, 22 Dec 2019 12:56:04 +0200

[Message part 1 (text/plain, inline)]

On Fri, Dec 20, 2019 at 11:07:58AM -0500, Ivan Vilata i Balaguer wrote:
> Ivan Vilata i Balaguer (2019-12-19 11:51:55 -0500) wrote:
> 
> > Efraim Flashner (2019-12-19 15:03:11 +0200) wrote:
> > 
> > > I merged the two patches together, made sure all the phases returned #t
> > > and flushed out the commit message some more.
> > 
> > Thanks a lot!  Comparing your final patch against mine was also very
> > instructive. `:)`
> 
> Before you close this issue, I upgraded my `mumble` package and many icons are
> missing.  I didn't yet have time to further investigate it, but maybe it's
> because of a difference I noticed between your patch:
> 
>     (modify-phases %standard-phases
> 
> and mine:
> 
>     (modify-phases (@ (guix build qt-build-system) %standard-phases)
> 
> So maybe the problem is that the final, wrapping phase of `qt-build-system` is
> not being run.  Actually I see that `mumble` is a plain binary while in the
> output from my patch, it was a wrapper script.
> 

I'm not sure what happened with the wrapping phase, but I changed it
back and now everything should be working as expected.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #40 received at 38395-done <at> debbugs.gnu.org (full text, mbox):

From: Ivan Vilata i Balaguer <ivan <at> selidor.net>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 38054-done <at> debbugs.gnu.org, 38395-done <at> debbugs.gnu.org,
 Ivan Vilata i Balaguer <ivan <at> selidor.net>
Subject: Re: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to
 1.3.0.)
Date: Sun, 22 Dec 2019 13:16:38 -0500

Efraim Flashner (2019-12-22 12:56:04 +0200) wrote:

> On Fri, Dec 20, 2019 at 11:07:58AM -0500, Ivan Vilata i Balaguer wrote:
> > 
> > Before you close this issue, I upgraded my `mumble` package and many icons are
> > missing.  I didn't yet have time to further investigate it, but maybe it's
> > because of a difference I noticed between your patch:
> > 
> >     (modify-phases %standard-phases
> > 
> > and mine:
> > 
> >     (modify-phases (@ (guix build qt-build-system) %standard-phases)
> > 
> > So maybe the problem is that the final, wrapping phase of `qt-build-system` is
> > not being run.  Actually I see that `mumble` is a plain binary while in the
> > output from my patch, it was a wrapper script.
> 
> I'm not sure what happened with the wrapping phase, but I changed it
> back and now everything should be working as expected.

Works indeed now, than you! `:)`

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.