GNU bug report logs - #38157
[PATCH] gnu: Add font-dseg.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alexandros Theodotou <alex <at> zrythm.org>
Subject: bug#38157: closed (Re: [bug#38157] [PATCH] gnu: Add font-dseg.)
Date: Tue, 19 Nov 2019 09:52:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#38157: [PATCH] gnu: Add font-dseg.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 38157 <at> debbugs.gnu.org.

-- 
38157: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38157
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Alexandros Theodotou <alex <at> zrythm.org>
Cc: 38157-done <at> debbugs.gnu.org, Tobias Geerinckx-Rice <me <at> tobias.gr>
Subject: Re: [bug#38157] [PATCH] gnu: Add font-dseg.
Date: Tue, 19 Nov 2019 10:51:19 +0100

[Message part 3 (text/plain, inline)]

Hello Alexandros,

Alexandros Theodotou <alex <at> zrythm.org> skribis:

> From ec6c88abe3de6346087d821539e43afb3dff42c8 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Sun, 10 Nov 2019 01:25:28 +0000
> Subject: [PATCH] gnu: Add font-dseg.
>
> * gnu/packages/fonts.scm (font-dseg): New variable.

Nice.  Applied with the minor changes below: addressing a ‘guix lint’
warning, and using an even more appropriate string function.  ;-)

Thanks,
Ludo’.

[Message part 4 (text/x-patch, inline)]

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 7fe0aee20b..83c97444bf 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -1537,7 +1537,7 @@ have been designed to be very distinguishable from each other.")
           (string-append "https://github.com/keshikan/DSEG/"
                          "releases/download/v" version
                          "/fonts-DSEG_v"
-                         (apply string-append (string-split version #\.))
+                         (string-concatenate (string-split version #\.))
                          ".zip"))
         (sha256
           (base32
@@ -1561,6 +1561,7 @@ have been designed to be very distinguishable from each other.")
     (home-page "https://www.keshikan.net/fonts-e.html")
     (synopsis "DSEG: 7-segment and 14-segment fonts")
     (description
-     "DSEG is a font family that imitates seven and fourteen segment
-display (7SEG,14SEG). DSEG includes the roman alphabet and symbol glyphs.")
+     "DSEG is a font family that imitates seven- and fourteen-segment LCD
+displays (7SEG, 14SEG).  DSEG includes the roman alphabet and symbol glyphs.
+This package provides the TrueType fonts.")
     (license license:silofl1.1)))

[Message part 5 (message/rfc822, inline)]

From: Alexandros Theodotou <alex <at> zrythm.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add font-dseg.
Date: Sun, 10 Nov 2019 03:20:05 +0000

[Message part 6 (text/plain, inline)]

There's probably an easy way to remove the dot from the version but I
can't figure it out. Any modifications welcome.

[0001-gnu-Add-font-dseg.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.