GNU bug report logs - #38156
27.0.50; [PATCH] VC: ability to skip update buffers prompt

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38156 in the body.
You can then email your comments to 38156 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; [PATCH] VC: ability to skip update buffers prompt
Date: Sat, 9 Nov 2019 22:29:28 +0200

[Message part 1 (text/plain, inline)]

Hi,

The `update' argument of `vc-retrieve-tag' is ignored by git, hg and svn
vc backends so the answer for "Update any affected buffers?" prompt
doesn't matter.  This prompt can be omitted.

[0001-VC-ability-to-skip-update-buffers-prompt.patch (application/octet-stream, attachment)]

Message #8 received at 38156 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Cc: 38156 <at> debbugs.gnu.org
Subject: Re: bug#38156: 27.0.50; [PATCH] VC: ability to skip update buffers
 prompt
Date: Thu, 14 Nov 2019 06:55:58 +0100

Andrii Kolomoiets <andreyk.mad <at> gmail.com> writes:

> The `update' argument of `vc-retrieve-tag' is ignored by git, hg and svn
> vc backends so the answer for "Update any affected buffers?" prompt
> doesn't matter.  This prompt can be omitted.

Would it be possible to make those backends respect the UPDATE argument
instead?  I had a quick peek at vc-cvs-retrieve-tag (which does respect
the argument), and it looks a bit painful, and I'm not sure whether it
looks that useful.

Anybody got an opinion?

I applied the patch anyway, because it provides a way to make the
backends say whether they support it or not, which seems generally
useful.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 38156 <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 38156 <at> debbugs.gnu.org
Subject: Re: bug#38156: 27.0.50; [PATCH] VC: ability to skip update buffers
 prompt
Date: Thu, 14 Nov 2019 09:13:33 +0200

[Message part 1 (text/plain, inline)]

Hi Lars,

> On 14 Nov 2019, at 07:55, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:
> 
> I applied the patch anyway, because it provides a way to make the
> backends say whether they support it or not, which seems generally
> useful.

Please install attached patch. Totally missed that default vc functions
are called with `backend` argument.

Thanks.

[0001-lisp-vc-vc.el-vc-default-update-on-retrieve-tag-Acce.patch (application/octet-stream, attachment)]

Message #14 received at 38156 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Cc: 38156 <at> debbugs.gnu.org
Subject: Re: bug#38156: 27.0.50; [PATCH] VC: ability to skip update buffers
 prompt
Date: Thu, 14 Nov 2019 08:18:37 +0100

Andrii Kolomoiets <andreyk.mad <at> gmail.com> writes:

> Please install attached patch. Totally missed that default vc functions
> are called with `backend` argument.

OK; installed.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 38156 <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 38156 <at> debbugs.gnu.org
Subject: Re: bug#38156: 27.0.50; [PATCH] VC: ability to skip update buffers
 prompt
Date: Thu, 14 Nov 2019 11:54:07 +0200

Hi Lars,

> On 14 Nov 2019, at 07:55, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:
> 
> Andrii Kolomoiets <andreyk.mad <at> gmail.com> writes:
> 
>> The `update' argument of `vc-retrieve-tag' is ignored by git, hg and svn
>> vc backends so the answer for "Update any affected buffers?" prompt
>> doesn't matter.  This prompt can be omitted.
> 
> Would it be possible to make those backends respect the UPDATE argument
> instead?  I had a quick peek at vc-cvs-retrieve-tag (which does respect
> the argument), and it looks a bit painful, and I'm not sure whether it
> looks that useful.

vc-retrieve-tag is already updating buffers by calling
(vc-resynch-buffer dir t t t)

Maybe this commits are related:
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5828f6cacc5
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5f4f2ae4f96

IMO there are nothing more those backends can do with buffers so
`update` argument is mean nothing to them.

Don't know about cvs backend though.

Message #20 received at 38156 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Cc: 38156 <at> debbugs.gnu.org
Subject: Re: bug#38156: 27.0.50; [PATCH] VC: ability to skip update buffers
 prompt
Date: Sat, 16 Nov 2019 08:13:25 +0100

Andrii Kolomoiets <andreyk.mad <at> gmail.com> writes:

> vc-retrieve-tag is already updating buffers by calling
> (vc-resynch-buffer dir t t t)
>
> Maybe this commits are related:
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5828f6cacc5
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5f4f2ae4f96
>
> IMO there are nothing more those backends can do with buffers so
> `update` argument is mean nothing to them.

OK; closing.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.