GNU bug report logs - #38127
[PATCH] gnu: Add x42-plugins.

Previous Next

Package: guix-patches;

Reported by: Alexandros Theodotou <alex <at> zrythm.org>

Date: Fri, 8 Nov 2019 10:58:02 UTC

Severity: normal

Tags: patch

Done: Marius Bakke <mbakke <at> fastmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Marius Bakke <mbakke <at> fastmail.com>, 38127 <at> debbugs.gnu.org
Subject: [bug#38127] [PATCH] gnu: Add x42-plugins.
Date: Mon, 11 Nov 2019 01:53:02 +0000
[Message part 1 (text/plain, inline)]
Thanks for the pointers!

> The patch LGTM overall, but indentation seems to be off.  Can you run
> this through "./etc/indent-code.el"?
That script gives me weird indentation that I don't see in any
packages, like:
(define-public dpf-plugins
  (package
   (name
   ^ missing space

Hopefully the updated patch looks better, I tried to match the other
packages in music.scm.

> > +audio and MIDI plugins that can also run as standalone JACK 
> > applications.")
> > +    (home-page "https://x42-plugins.com/x42/")
> > +    (license license:gpl2+)))
> 
> I notice in the FAQ that "Some binaries are provided as demo.  A
> license/signature file is required to remove the evaluation
> restrictions".
> 
> If there are such binaries in the source tarball, they must be
> removed
> with a source 'snippet' to ensure 'guix build --source' contains only
> free software.
This tarball only contains sources and is specifically targeted at
distro packagers (see https://github.com/x42/x42-plugins). I believe
the binaries are provided as separate downloads on the website.
[0001-gnu-Add-x42-plugins.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 5 years and 196 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.