GNU bug report logs - #38128
[PATCH] gnu: Add boost-with-python3

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38128 in the body.
You can then email your comments to 38128 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: goodoldpaul <at> autistici.org
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add boost-with-python3
Date: Fri, 08 Nov 2019 10:59:26 +0000

[Message part 1 (text/plain, inline)]

Hello Guixers!

Given the recent discussion about dropping python 2 completely I thought 
it's time to build our libboost against python 3. I didn't have the time 
to check if every boost dependency (there are a lot ;) ) supported 
python 3, so I added a new variable "boost-with-python3". I'm not sure 
if I should have made it hidden or if I should have update directly 
boost definition so any feedback is welcome.

Thanks for your patience reviewing this patch,

Giacomo

[0001-gnu-Add-boost-with-python3.patch (text/x-diff, attachment)]

Message #10 received at 38128-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: goodoldpaul <at> autistici.org, 38128-done <at> debbugs.gnu.org
Subject: Re: [bug#38128] [PATCH] gnu: Add boost-with-python3
Date: Sun, 10 Nov 2019 22:50:18 +0100

[Message part 1 (text/plain, inline)]

Giacomo,

goodoldpaul <at> autistici.org writes:

> Hello Guixers!
>
> Given the recent discussion about dropping python 2 completely I thought 
> it's time to build our libboost against python 3. I didn't have the time 
> to check if every boost dependency (there are a lot ;) ) supported 
> python 3, so I added a new variable "boost-with-python3". I'm not sure 
> if I should have made it hidden or if I should have update directly 
> boost definition so any feedback is welcome.

Thank you for this patch!  Have you tried building anything with this
new Boost yet?

Boost has 4623 dependent packages according to 'guix refresh -l boost',
so we can not change the package definition on the master branch.  Such
changes has to go through the 'core-updates' branch.  Adding a separate
variable was the right choice.

It would be great if you could work on a follow-up patch for
'core-updates' that merges this variant with the regular 'Boost'.  I
left that as a TODO comment.  :-)

> From 6eef72ea2bc904ff1371fbbe1211a3890625d99c Mon Sep 17 00:00:00 2001
> From: Giacomo Leidi <goodoldpaul <at> autistici.org>
> Date: Fri, 8 Nov 2019 11:52:42 +0100
> Subject: [PATCH] gnu: Add boost-with-python3.
>
> * gnu/packages/boost.scm (boost-with-python3): New variable.

[...]
  
> +(define-public boost-with-python3
> +  (package
> +    (inherit boost)
> +    (source (origin
> +              (inherit (package-source boost))))

I removed this part, as the source is already inherited.

I also gave it a different name (boost-python3) to avoid a naming
conflict on the CLI.

[...]

> +                     (replace 'provide-libboost_python
> +                       (lambda* (#:key outputs #:allow-other-keys)
> +                         (let ((out (assoc-ref outputs "out")))
> +                           (with-directory-excursion (string-append out "/lib")
> +                             ;; Boost can build support for both Python 2 and Python 3 since
> +                             ;; version 1.67.0, and suffixes each library with the Python
> +                             ;; version.  Many consumers only check for libboost_python
> +                             ;; however, so we provide it here as suggested in
> +                             ;; <https://github.com/boostorg/python/issues/203>.

...and dropped this comment, since it is already explained in the
regular Boost package.

Applied, thanks!

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 38128 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 38128 <at> debbugs.gnu.org, mbakke <at> fastmail.com, goodoldpaul <at> autistici.org
Subject: Re: bug#38128: [PATCH] gnu: Add boost-with-python3
Date: Mon, 11 Nov 2019 11:36:37 +0200

[Message part 1 (text/plain, inline)]

I'm going to re-open this one, sorry.

Can we replace the '--with-python-version=3.7' and 'libboost_python37.so'
with parameterized python variables so we don't have to bump it when we
get a new python version?

Also, I've attached a package that I've never actually built that uses
boost built with python3 if you want something to test it out with :)


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[epour.scm (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 38128 <at> debbugs.gnu.org (full text, mbox):

From: goodoldpaul <at> autistici.org
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: mbakke <at> fastmail.com, 38128 <at> debbugs.gnu.org
Subject: Re: bug#38128: [PATCH] gnu: Add boost-with-python3
Date: Tue, 12 Nov 2019 00:06:37 +0000

[Message part 1 (text/plain, inline)]

On 2019-11-11 09:36, Efraim Flashner wrote:
> I'm going to re-open this one, sorry.
> 
> Can we replace the '--with-python-version=3.7' and 
> 'libboost_python37.so'
> with parameterized python variables so we don't have to bump it when we
> get a new python version?
> 
> Also, I've attached a package that I've never actually built that uses
> boost built with python3 if you want something to test it out with :)

I'm not sure how to send a patch for core-updates, I never did it so I 
attached it here. Please tell me if I should open another patch.

The patch builds boost with python3 and parameterizes the python 
version, as Efraim suggested. I built it successfully on core updates. 
When I tried building Epour on core-updates and saw that Guix was 
starting to build Bash 5.0 I renounced (:D) and I built it on master 
with boost-with-python3 .

Libtorrent-rasterbar seems to build fine on master but some tests fail 
to pass and they all seem to be network related but then again this is 
torrent we are talking about. I didn't investigate further but I attach 
the log.

I also tried boost-with-python3 with Malmo ( 
https://github.com/microsoft/malmo ) and it seemed to compile fine just 
but that package has other problems such as trying to start gradle so I 
nerver managed to actually run it.

Let me know what you think about the patch,

Bye

Giacomo

[0001-gnu-boost-Build-with-python3.patch (text/x-diff, attachment)]

[epour.log (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.