GNU bug report logs - #3800
[emacs-devel] emacs-23.0.96 make install misbehavior

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 3800 in the body.
You can then email your comments to 3800 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Nelson H. F. Beebe" <beebe <at> math.utah.edu>
To: emacs-pretest-bug <at> gnu.org
Cc: beebe <at> math.utah.edu
Subject: [emacs-devel] emacs-23.0.96 make install misbehavior
Date: Thu, 9 Jul 2009 14:12:58 -0600 (MDT)

I'm doing "make install" for several builds of emacs-23.0.96, and I
just noticed this output (with the GNU default of prefix=/usr/local):

chmod -R a+r \
	/usr/local/share/emacs/23.0.96 \
	/usr/local/share/emacs/site-lisp \
	/usr/local/share/emacs/23.0.96/etc \
	/usr/local/share/emacs/23.0.96/lisp \
	/usr/local/share/info

While it is appropriate to run chmod at installation time for a
package's own files, it is HIGHLY INAPPROPRIATE to run chmod on
directories and files belonging to other packages.  The directories

	/usr/local/share/emacs/site-lisp
	/usr/local/share/info

need to be removed from the install command chmod processing.

Their contents, and file permissions, are not the business of
emacs-x.y.z release installations.  A given site, including ours, may
have local reasons for nondefault permissions in those directories.

-------------------------------------------------------------------------------
- Nelson H. F. Beebe                    Tel: +1 801 581 5254                  -
- University of Utah                    FAX: +1 801 581 4148                  -
- Department of Mathematics, 110 LCB    Internet e-mail: beebe <at> math.utah.edu  -
- 155 S 1400 E RM 233                       beebe <at> acm.org  beebe <at> computer.org -
- Salt Lake City, UT 84112-0090, USA    URL: http://www.math.utah.edu/~beebe/ -
-------------------------------------------------------------------------------

Message #10 received at 3800 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: "Nelson H. F. Beebe" <beebe <at> math.utah.edu>
Cc: 3800 <at> debbugs.gnu.org
Subject: Re: [emacs-devel] emacs-23.0.96 make install misbehavior
Date: Sun, 12 Jul 2009 14:50:58 -0400

> chmod -R a+r \
> 	/usr/local/share/emacs/23.0.96 \
> 	/usr/local/share/emacs/site-lisp \
> 	/usr/local/share/emacs/23.0.96/etc \
> 	/usr/local/share/emacs/23.0.96/lisp \
> 	/usr/local/share/info
>
> While it is appropriate to run chmod at installation time for a
> package's own files, it is HIGHLY INAPPROPRIATE to run chmod on
> directories and files belonging to other packages.  The directories
>
> 	/usr/local/share/emacs/site-lisp
> 	/usr/local/share/info
>
> need to be removed from the install command chmod processing.

Fair enough.  But the installation process needs to read the contents of
/usr/local/share/emacs/site-lisp and /usr/local/share/info in order to
function properly.

How about doing `u+r' instead of `a+r' for those directories?

Message #13 received at 3800 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 3800 <at> debbugs.gnu.org,
        "Nelson H. F. Beebe" <beebe <at> math.utah.edu>
Subject: Re: bug#3800: [emacs-devel] emacs-23.0.96 make install misbehavior
Date: Sun, 12 Jul 2009 20:31:51 -0400

Chong Yidong wrote:

>> chmod -R a+r \
[...]
> Fair enough.  But the installation process needs to read the contents of
> /usr/local/share/emacs/site-lisp and /usr/local/share/info in order to
> function properly.
>
> How about doing `u+r' instead of `a+r' for those directories?

("u" is probably root when installing)

I imagine it is the "-R" that is the problem. I guess the install
should make sure the directories themselves, and those files we
install in them, are readable, but leave other things under these
directories alone.

Message #18 received at 3800 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 3800 <at> debbugs.gnu.org,
        "Nelson H. F. Beebe" <beebe <at> math.utah.edu>
Subject: Re: bug#3800: [emacs-devel] emacs-23.0.96 make install misbehavior
Date: Sun, 12 Jul 2009 22:44:28 -0400

Glenn Morris <rgm <at> gnu.org> writes:

> I imagine it is the "-R" that is the problem. I guess the install
> should make sure the directories themselves, and those files we
> install in them, are readable, but leave other things under these
> directories alone.

No, the reporter specifically complained about making these readable:

	/usr/local/share/emacs/site-lisp
	/usr/local/share/info

Message #21 received at 3800 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 3800 <at> debbugs.gnu.org,
        "Nelson H. F. Beebe" <beebe <at> math.utah.edu>
Subject: Re: bug#3800: [emacs-devel] emacs-23.0.96 make install misbehavior
Date: Mon, 13 Jul 2009 02:30:04 -0400

Chong Yidong wrote:

> No, the reporter specifically complained about making these readable:
>
> 	/usr/local/share/emacs/site-lisp
> 	/usr/local/share/info

That I can't understand.

Super-top-secret info files can be installed in a non-standard
location, and added to the INFOPATH of those who need them.
Ditto with site-lisp-files-that-aren't-really-site-lisp-files.

Or emacs can be installed somewhere else than /usr/local.

Message #24 received at 3800 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 3800 <at> debbugs.gnu.org
Cc: Chong Yidong <cyd <at> stupidchicken.com>,
        "Nelson H. F. Beebe" <beebe <at> math.utah.edu>
Subject: Re: bug#3800: [emacs-devel] emacs-23.0.96 make install misbehavior
Date: Mon, 13 Jul 2009 02:44:43 -0400

Glenn Morris wrote:

> Chong Yidong wrote:
>
>> No, the reporter specifically complained about making these readable:
>>
>> 	/usr/local/share/emacs/site-lisp
>> 	/usr/local/share/info
>
> That I can't understand.

But if that is the issue, how about only setting the permissions if we
create those directories?

Message #29 received at 3800 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Nelson H. F. Beebe" <beebe <at> math.utah.edu>
To: Glenn Morris <rgm <at> gnu.org>
Cc: beebe <at> math.utah.edu, 3800 <at> debbugs.gnu.org,
        Chong Yidong <cyd <at> stupidchicken.com>,
        "Nelson H. F. Beebe" <beebe <at> math.utah.edu>
Subject: Re: bug#3800: [emacs-devel] emacs-23.0.96 make install misbehavior
Date: Mon, 13 Jul 2009 13:04:18 -0600 (MDT)

>> how about only setting the permissions if we create those directories?

That is fine, because there is no change to the permissions of
existing files and subdirectories.

-------------------------------------------------------------------------------
- Nelson H. F. Beebe                    Tel: +1 801 581 5254                  -
- University of Utah                    FAX: +1 801 581 4148                  -
- Department of Mathematics, 110 LCB    Internet e-mail: beebe <at> math.utah.edu  -
- 155 S 1400 E RM 233                       beebe <at> acm.org  beebe <at> computer.org -
- Salt Lake City, UT 84112-0090, USA    URL: http://www.math.utah.edu/~beebe/ -
-------------------------------------------------------------------------------

Message #32 received at 3800 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Nelson H. F. Beebe" <beebe <at> math.utah.edu>
To: Glenn Morris <rgm <at> gnu.org>
Cc: beebe <at> math.utah.edu, Chong Yidong <cyd <at> stupidchicken.com>
Subject: Re: bug#3800: [emacs-devel] emacs-23.0.96 make install misbehavior
Date: Mon, 13 Jul 2009 13:03:14 -0600 (MDT)

>> I imagine it is the "-R" that is the problem. I guess the install
>> should make sure the directories themselves, and those files we
>> install in them, are readable ...

The permissions of directories not owned by the package must not
be touched.  If a specific permission mode is needed, and an
existing file or directory lacks that permission, then "make install"
should warn about the problem.

-------------------------------------------------------------------------------
- Nelson H. F. Beebe                    Tel: +1 801 581 5254                  -
- University of Utah                    FAX: +1 801 581 4148                  -
- Department of Mathematics, 110 LCB    Internet e-mail: beebe <at> math.utah.edu  -
- 155 S 1400 E RM 233                       beebe <at> acm.org  beebe <at> computer.org -
- Salt Lake City, UT 84112-0090, USA    URL: http://www.math.utah.edu/~beebe/ -
-------------------------------------------------------------------------------

Message #37 received at 3800-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 3800-done <at> debbugs.gnu.org
Subject: Re: bug#3800: [emacs-devel] emacs-23.0.96 make install misbehavior
Date: Tue, 08 Sep 2009 22:34:37 -0400

I believe this is fixed now.

  * Makefile.in (install-arch-indep): Don't recursively change perms of
  site-lisp and infodir. There may be non-Emacs files in here, and the
  files supplied by Emacs are all handled explicitly already.  (Bug#3800)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.