GNU bug report logs - #37988
[PATCH 0/6] Add flowWorkspace from BioConductor

Previous Next

Full log

View this message in rfc822 format

From: Ricardo Wurmus <rekado <at> elephly.net>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 37988 <at> debbugs.gnu.org
Subject: [bug#37988] [PATCH 3/6] gnu: Add r-rprotobuflib.
Date: Wed, 30 Oct 2019 12:39:12 +0100

Hi,

thank you for the patches!

> * gnu/packages/bioconductor.scm (r-rprotobuflib): New variable.

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         ;; Contains unverified binaries:
> +         ;; src/win/lib/{i386,x64}/libprotobuf.a
> +         (add-after 'unpack 'remove-win-folder
> +           (lambda _
> +             (delete-file-recursively "src/win")
> +             #t))

This should be done in a snippet instead.

> +         ;; Fix non-conventional packaging.
> +         ;; The dependency to protobuf-2.6.0 is included as tgz and build
> +         ;; by the R package itself.
> +         (add-after 'unpack 'fix-wrong-hard-coded
> +           (lambda _
> +             (with-directory-excursion "src"
> +               (invoke "tar" "xf" "protobuf-2.6.0.tgz"))
> +             (substitute* "src/protobuf-2.6.0/configure"
> +               (("#! /bin/sh") (string-append "#!" (which "sh"))))
> +             #t)))))

Can we just use our protobuf package instead of using the bundled sources?

> +    (description "This package provides the headers and static library of
> +Protocol buffers 2.6.0 for other R packages to compile and link
> against.")

I would prefer not to mention the specific version here.

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.